From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id KHs8OWzORmPb9QAAbAwnHQ (envelope-from ) for ; Wed, 12 Oct 2022 16:25:49 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id +II8OWzORmPZYAAAauVa8A (envelope-from ) for ; Wed, 12 Oct 2022 16:25:48 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ACAA617783 for ; Wed, 12 Oct 2022 16:25:48 +0200 (CEST) Received: from localhost ([::1]:59394 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oicg5-00078t-HJ for larch@yhetil.org; Wed, 12 Oct 2022 10:25:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oicfP-00075N-Hy for bug-guix@gnu.org; Wed, 12 Oct 2022 10:25:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59086) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oicfP-0004ak-7k for bug-guix@gnu.org; Wed, 12 Oct 2022 10:25:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oicfP-0007Ev-32 for bug-guix@gnu.org; Wed, 12 Oct 2022 10:25:03 -0400 Subject: bug#22608: Module system thread unsafety and .go compilation Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Wed, 12 Oct 2022 14:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 22608 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 22608-done@debbugs.gnu.org Mail-Followup-To: 22608@debbugs.gnu.org, maxim.cournoyer@gmail.com, taylanbayirli@gmail.com Received: via spool by 22608-done@debbugs.gnu.org id=D22608.166558470027799 (code D ref 22608); Wed, 12 Oct 2022 14:25:02 +0000 Received: (at 22608-done) by debbugs.gnu.org; 12 Oct 2022 14:25:00 +0000 Received: from localhost ([127.0.0.1]:58159 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oicfL-0007EI-Rr for submit@debbugs.gnu.org; Wed, 12 Oct 2022 10:25:00 -0400 Received: from mail-qt1-f169.google.com ([209.85.160.169]:33295) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oicfJ-0007E0-Sd for 22608-done@debbugs.gnu.org; Wed, 12 Oct 2022 10:24:58 -0400 Received: by mail-qt1-f169.google.com with SMTP id jr1so2218958qtb.0 for <22608-done@debbugs.gnu.org>; Wed, 12 Oct 2022 07:24:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=fmlzmpxj0bOP+wkPHR4VKJ/FMh3P8InSVwppxEdS/7c=; b=MuKyRGqNVw0VyGP0Vp/c3pJVgI2Cr2wfce3sRZrjhFIiA3RRggKi3/saGQDQoGMy8P 0vjj2t/bHG894nlEFaaXxUY7osAXsjdKFle6dYzzAg4w9KY0PYDDJp6nM7RnDuyOzh4J 7e1wMGpIqV9JqV7g/KF7kn0biMw59O01+8qSRsfoPEw2zIg0HOznqXN4ZgXMNNY7TVDo BLVNzPthin2utw5EJFx4sjkb0bKxDojHo0TOGYLXZmv0FRZifMoJG4k77hpG4yG7SMsm GD/2P9agGkK1flBxckJsg3K5QLcdbgm0fUjontnoVMRKhi/7LCYHxpx7PW7rS4Reac7h e2DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fmlzmpxj0bOP+wkPHR4VKJ/FMh3P8InSVwppxEdS/7c=; b=JM170kMMVYowSgb78CopJC58pp4MSU3XD8vrZkDv337DNlJpXzRilDvaINc6cJKrV2 YQHBVF9SiFe5bfkhwZ5eEKbjaQNvfWeMGNi+G8IwRoYA3HoDlgIJ7kvBRZS6JmbnjS5g vY/Y1t88w5iS2li1rNy2cfF7BIvo4yv/xfO3g2/yjW3ucwhFvJpnwpDmR7B0QhItzmg0 s50YY169DLyUkOJwt5XkiwnE5FIqrgTuAEQ+qmht/9dGELWgOGDzAXmooMJUuLp5/lkI sArXNZ0VqaMmQlOrSP6ijUhp7AX2pmdd6AefFFpPbNUulIHASOArJ7hCk6UsP7vQOSYH rB1Q== X-Gm-Message-State: ACrzQf2at1LXSIUeirr07YlfwJaW4KsFsCSRe5GgAAb3CwQMI8tBJjVV hCJqIt4cZb+pOAHKQu6syqTlrKKRqLc= X-Google-Smtp-Source: AMsMyM7IkX7jKNjsnedMqX9NtZiomiro6gwKh1qmHJsZE3F9uFHsT1r3FJYCmDwOPo57UxOgzyasZQ== X-Received: by 2002:a05:622a:3cf:b0:394:fc49:b4a8 with SMTP id k15-20020a05622a03cf00b00394fc49b4a8mr23855094qtx.249.1665584692181; Wed, 12 Oct 2022 07:24:52 -0700 (PDT) Received: from hurd (dsl-153-107.b2b2c.ca. [66.158.153.107]) by smtp.gmail.com with ESMTPSA id s13-20020a05620a0bcd00b006b95b0a714esm16500383qki.17.2022.10.12.07.24.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 07:24:51 -0700 (PDT) From: Maxim Cournoyer References: <8737t1k5yk.fsf@T420.taylan> <87d0w4ezst.fsf@gnu.org> <87lepr412m.fsf@gmail.com> <87v8os3xur.fsf@gnu.org> Date: Wed, 12 Oct 2022 14:24:50 +0000 In-Reply-To: <87v8os3xur.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 10 Oct 2022 10:07:56 +0200") Message-ID: <87czax15n1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1665584748; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=fmlzmpxj0bOP+wkPHR4VKJ/FMh3P8InSVwppxEdS/7c=; b=n3DJY1g210YsGvdJEECOOhsS6/4LTvFADcAfi0IPW+ZCIWjF2gX68Sc9nj25tGinB4f+Xx 5tv7yBL5J51xT67nvEIGe+5TAmiLoEoJLCcD/cYLRsmAVl8xPMEfADXOI3B8SrQ4xLuDsS nt1x6OGWYMgnAH86YPb38tfCD4Inzz8L2VJRl+3GRQzrg97y6qXYDZaCSxYbWdQl68Yib3 kU1nhYdDqA2T3OOBK7qMzSTrAUJjudUQBXaWVFYv5JPoC1AvYsprnG6CmFneXEPmwAEMNp ntX3aYy58/ZQUeFxgxHtC5snd8r2xpPq7M5DwkH97TdreySzc0q/CkQ/N8cZmA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1665584748; a=rsa-sha256; cv=none; b=RDCUXMCFW16jZVOUb9m+rvtA6FZg3hrqSTUFOea9R2jS+S5UAdOu1fTx0yObePLo4lEp2l 8l1qEi/LnitD/+ZqSl0w+dLedqEBlcAEgLImE7iV6oAb8LlpuyHOucQYr4KAN1QKgyBOBu ZLkU1MNoYME8o8gzCyyjHFQUdN7XlWVm46X9UFlh3zVHMjne5erYqqLqrw+HlwZ4HpH10O bNgLWEfQsrqhZkS4nDgsiFPBoN4zzeiCK1gdyUwZly1Vc2ifWM9zlkK0Bj9tuRJrDYYlLN 5InGPu0FTz4qghSkllVcO1mkne5CBbbEnef7rVYQF1vtknoqglD+JFLXy9CN7g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MuKyRGqN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: 5.50 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=MuKyRGqN; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: ACAA617783 X-Spam-Score: 5.50 X-Migadu-Scanner: scn0.migadu.com X-TUID: Ay8uxA/jNul/ Hi, Ludovic Court=C3=A8s writes: > Hi! > > Maxim Cournoyer skribis: > >> ludo@gnu.org (Ludovic Court=C3=A8s) writes: > > [...] > >>> For the record, these issues should be fixed in Guile 2.2.4: >>> >>> 533e3ff17 * Serialize accesses to submodule hash tables. >>> 46bcbfa56 * Module import obarrays are accessed in a critical section. >>> 761cf0fb8 * Make module autoloading thread-safe. >>> >>> =E2=80=98guix pull=E2=80=99 now defaults to 2.2.4, so we=E2=80=99ll see= if indeed those crashes >>> disappear. >> >> I think we haven't seen these in the last 4 years! We still have >> references to https://bugs.gnu.org/15602 in our code base though; >> although the upstream issue appears to have been fixed. Could we remove >> the workarounds now? > > The module thread-safety issue discussed here appears to be done. Alright, I'm closing this one then. > However the workarounds for must remain: > that specific issue is still there. Thanks for the heads-up! --=20 Maxim