From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id sFhpM2+y7mPXOgAAbAwnHQ (envelope-from ) for ; Thu, 16 Feb 2023 23:47:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id YNkzM2+y7mPWlwAAauVa8A (envelope-from ) for ; Thu, 16 Feb 2023 23:47:11 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9974E2E0F1 for ; Thu, 16 Feb 2023 23:47:10 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676587630; a=rsa-sha256; cv=none; b=SVK2gHcTZWoNpU0QqNx39qEgwq1oCl55lo99rLFXYU/MUFHO8EruJ6ZNiIU26cqWhixFK5 UdjK/5FhkqqPvPMAOM6Uhhp3qGlrCyLxZc68bzYrrRDYsa2CGI5O1/xUlQk8E5EllPA+w4 EIWEyRfdj5Smmxr5kNLTt0SGLwf7gwSnsYyQjCb4OmbsTqv9lFimVnRhtLyn2B5sqagOhR IjKDrFh/I8rI5wyX5m3OrSP++ywvl3/KNM/FduoMuBAu0HbhN2LmHQO2Dz1raM3a+qoaxF wBJO5d7Cbk3tFHPeH4ATuehT9rPZHKF1ExIzl0x5z1D2d2UdcZHrAIfewaM7EQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676587630; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post; bh=8+uuxH1bfo9rYm4xLs8ngsmTAKibw1GA8ahKOyLISgo=; b=XmWUox9LCqoHMf04nVV71jULWxNFkDKgZdTYsVvFoo3skHNcpWn7+bnaPqm/oPdvy/vYVA VW1hRG7/f1Jg9SHG+C36eF/SUyr1e4f/h/Jz0C8Y9wFIntQsM5f7hAZM4sn62ntLF4831X mOrue0+j120TKvmpGbtqIYNktFxV3xAO3hfrl8huzGfIlhKwoCG1twRW0DLzq793/kXgMI ZNlVwkiEZEGTKU4A3vfb67wuE6T2lAF0wpyTiQlKlai0XwmeGpSVh0vcrNWjEa4m78jt0A X50RLnyNuO3smPUUZq/FhXVo/hJrLs77olLlTvN2n4y955ej4COnMSlcBD0fmg== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSn1r-0006yt-A5; Thu, 16 Feb 2023 17:47:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSn1q-0006yl-8m for bug-guix@gnu.org; Thu, 16 Feb 2023 17:47:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSn1q-0008Jx-1F for bug-guix@gnu.org; Thu, 16 Feb 2023 17:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSn1p-0002Yp-UK for bug-guix@gnu.org; Thu, 16 Feb 2023 17:47:01 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 05/10] gnu: Add icecat-l10n and icedove-l10n. Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 16 Feb 2023 22:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Maxim Cournoyer , 32026@debbugs.gnu.org Cc: ludo@gnu.org, Jonathan Brielmaier , Maxim Cournoyer Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.16765876119826 (code B ref 32026); Thu, 16 Feb 2023 22:47:01 +0000 Received: (at 32026) by debbugs.gnu.org; 16 Feb 2023 22:46:51 +0000 Received: from localhost ([127.0.0.1]:37895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSn1f-0002YP-BC for submit@debbugs.gnu.org; Thu, 16 Feb 2023 17:46:51 -0500 Received: from world.peace.net ([64.112.178.59]:38008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSn1d-0002Xv-P7 for 32026@debbugs.gnu.org; Thu, 16 Feb 2023 17:46:50 -0500 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSn1V-0001kU-S4; Thu, 16 Feb 2023 17:46:42 -0500 From: Mark H Weaver In-Reply-To: <20230216043649.32119-5-maxim.cournoyer@gmail.com> References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> <20230216043649.32119-5-maxim.cournoyer@gmail.com> Date: Thu, 16 Feb 2023 17:45:49 -0500 Message-ID: <87cz69fcuf.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: 9974E2E0F1 X-Spam-Score: 0.88 X-Migadu-Spam-Score: 0.88 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: VYP/TNwdEFzM Hi Maxim, Maxim Cournoyer writes: > * gnu/packages/gnuzilla.scm (%icecat-locales, %icedove-locales): New variable. > (make-l10n-package): New procedure. > (icecat-l10n, icedove-l10n): New variables. Thanks very much for this important work. Our lack of support for language packs has been sore spot for several years, and I'm profoundly grateful to you for taking this on and getting it done! For now, I have just two general questions/comments: (1) Instead of generating the locales in separate "*-locales" packages and then merging them with the main package (which must then be renamed to "*-minimal"), how feasible would it be to incorporate the locale generation directly into the existing packages? (2) In terms of the API, I very much dislike the approach of having the 'make-l10n-package' accept just one argument: a symbol, which it uses to construct the variable names of toplevel variables that must be looked up using 'module-ref'. I'd greatly prefer to simply pass in all of the variables that are needed. What do you think? I'll hold off on a more detailed review until we can (hopefully) reach agreement on the overall approach. Thanks again! Mark