From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CHEgILhATWQYygAASxT56A (envelope-from ) for ; Sat, 29 Apr 2023 18:07:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id WNYGILhATWT+GwAA9RJhRA (envelope-from ) for ; Sat, 29 Apr 2023 18:07:20 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3C47B36DA9 for ; Sat, 29 Apr 2023 18:07:20 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1psn6G-0007Xd-1G; Sat, 29 Apr 2023 12:07:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1psn6E-0007XI-Oy for bug-guix@gnu.org; Sat, 29 Apr 2023 12:07:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1psn6E-0005WI-GQ for bug-guix@gnu.org; Sat, 29 Apr 2023 12:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1psn6D-0006L7-S3 for bug-guix@gnu.org; Sat, 29 Apr 2023 12:07:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#63082: [PATCH 07/17] services: mpd: Log to syslog by default. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 29 Apr 2023 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63082 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Bruno Victal Cc: 63082@debbugs.gnu.org Received: via spool by 63082-submit@debbugs.gnu.org id=B63082.168278439024323 (code B ref 63082); Sat, 29 Apr 2023 16:07:01 +0000 Received: (at 63082) by debbugs.gnu.org; 29 Apr 2023 16:06:30 +0000 Received: from localhost ([127.0.0.1]:36415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psn5h-0006KF-RD for submit@debbugs.gnu.org; Sat, 29 Apr 2023 12:06:30 -0400 Received: from mail-qt1-f178.google.com ([209.85.160.178]:50386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1psn5f-0006Jz-Dj for 63082@debbugs.gnu.org; Sat, 29 Apr 2023 12:06:28 -0400 Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-3ef2f81a96cso11596751cf.0 for <63082@debbugs.gnu.org>; Sat, 29 Apr 2023 09:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682784381; x=1685376381; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kZ1WJypOGT4878BjWglhaxo2cOcbMJWnkRPblaxg7Po=; b=JsNmQgskRJl9T6G4i0SpYqoPtCrVL1eNYvwdmKcQPgC+yV1rVDUD6klAuPBrJWuMu1 N70XFtOXj5pq3RFtUVClnaImxv7FunZHdwx+UyfY0mpSNXYMqV57/M84rcD6+pbGELku QrRh0XkSE1BYvBKBafm6AOHAiH8FyWK7EJVuhJtq62WoMBIU4T/2lUtOZqk2fbEU/Frk jVHrJYOPdH4JAMqZUdY3UQSduxV645URKlZoqqijzmkgiz6WduKTYqvtD1eb4RFGT3VK g0yRVlidshGUxvR3DPf54XA3L0GqN+4ZeVh2Mka8LNkWsehjFNqOGXeeNOjrfS01GzYD UCZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682784381; x=1685376381; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kZ1WJypOGT4878BjWglhaxo2cOcbMJWnkRPblaxg7Po=; b=AvQJ8yub76zouTkE9rP6G3KyDXwz/ShThCvXiaKIr1WgRLQxq3kEL0V/k3/fItWycI akPqGP5nuWmpyVvAvv4coma8F/YUmnu+vh82dJ+tGHBORXuj259fEi+5TfXIR7laBVQU vdOvbxjG9bFv0SIXxGqvX60nd3fpqYabGDMdxc7ostTlFigwPAFnS+yxaNW2bEpxwOpb drUG1PHNZwZjKIz5+kMEwRDBHr3U03EHeg55lbYqvjeCU7D34/Axs6W56+3w5UngAnRA hR86I5b5Gci5hUN1H85Mk21smsGJk2sqUPVo/rU+d2Hz+9T/tZPmXeGOSNEvJgtRMrY5 aEnw== X-Gm-Message-State: AC+VfDywwR4X5DwLDivMYYgnXp0mDyrldpsG41Nqs7rA6wXSzKnfw5lb 1plvhR1TeT7WTy5Hj7T3KYQqMnrRknA= X-Google-Smtp-Source: ACHHUZ6wX5Odiv3IP7wWLLw5nmu5RhaLKBQV+8Zq5Y3AkiI4KT2YRG9KTwvTC2DpsrKGSw/wRLMbXg== X-Received: by 2002:a05:622a:308:b0:3ef:389b:3ee2 with SMTP id q8-20020a05622a030800b003ef389b3ee2mr13892556qtw.43.1682784381434; Sat, 29 Apr 2023 09:06:21 -0700 (PDT) Received: from hurd (dsl-155-245.b2b2c.ca. [66.158.155.245]) by smtp.gmail.com with ESMTPSA id g11-20020a05620a218b00b0074a0051fcd4sm7544041qka.88.2023.04.29.09.06.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 29 Apr 2023 09:06:20 -0700 (PDT) From: Maxim Cournoyer References: <44c9a5cf9836a71db9bf78c2eba005a40a006fff.1682690696.git.maxim.cournoyer@gmail.com> <93e9013b-561a-0549-bf84-9752796e5c4a@makinata.eu> Date: Sat, 29 Apr 2023 12:06:19 -0400 In-Reply-To: <93e9013b-561a-0549-bf84-9752796e5c4a@makinata.eu> (Bruno Victal's message of "Fri, 28 Apr 2023 23:02:21 +0100") Message-ID: <87cz3mad1g.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682784440; a=rsa-sha256; cv=none; b=uLXwOJB0uyND6U8Hdnb18l+FdYjBOgFTnmtXmDzQCuqszi15/i7EEfnYtJtyLVKpJFq2tn Z5GYprzRhveRkGC3STWTqMLrG/BO0rIhNmv/6WMa5y2S7XBOA1cL5renPVnwWSxU5RVOJJ KrQ/lSNwd5h6Oh/8vSHj7veUBNvsUjYKPlM7iw/5c+hRszb2BSJg1g7Tk/28dMF1rR2g4p fkJh/Uel74bnJWIvjXd04gH4cDWurQjv8Cog3lKC9Q8enuPMWXz/LlEVYHVcifjSRPC1oh /ZzcSdeKWDoy2xwc1I/mV/Omsz2QBYo85BlhFUoxs7WJua6ZJ899pBggQbafqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=JsNmQgsk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682784440; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=kZ1WJypOGT4878BjWglhaxo2cOcbMJWnkRPblaxg7Po=; b=FOIblM76nel1R4d+RlHquj2+gqZmBc9cqf4mriCMPVsC7DNKQhu6mtb9jT9HtJQQtMErSa nTzcPxrAcTebTGX72u8JhArgBBetTyWBgoB15Kb454ncKUGCSQOJp14iFd3MKLRY/BgoUM JnYe/hPLCfRSlFj/f2HfKSyy3opHFPTthvyG1rptln5vinYHgdDLVfH2Bh62xyGD7GxY8B tz9EA6QBV6hr53fvnZaw0Q5d1LjQHV73B9R1pVsOtgjh8mX5Dc/EvAWmNJb3abs92azAty TlbzqbeRV759DyoJGD/12Tnxkpp0x9LC7GoiNzTCgcC3eGBSVCAnH0F9zCZU9Q== X-Migadu-Spam-Score: 0.19 X-Spam-Score: 0.19 X-Migadu-Queue-Id: 3C47B36DA9 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=JsNmQgsk; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: pNjcuDalZV3K Hi, Bruno Victal writes: > On 2023-04-28 15:27, Maxim Cournoyer wrote: >> Rationale: the tristate value was awkward to deal with, the default log file >> name was odd (/var/log/mpd/log) and it required special attention to create >> the 'mpd' parent directory as root and chowning it to the MPD user. It also >> didn't match the default behavior of MPD, which is to log to systemd or syslog >> unless a log file is specified. >> >> * gnu/services/audio.scm (mpd-log-file-sanitizer): New procedure. >> (mpd-configuration) [log-file]: Remove default maybe value. Add sanitizer. >> (mpd-shepherd-service): Validate the log file parent directory exists and has >> the right permissions. >> * doc/guix.texi (Audio Services): Update doc. > > How about a similar approach taken in mympd for handling the logging parameter? > In any case, I'd like to remind you that mpd-service-type also has a rottlog service extension > so that also needs to be taken into account. Done, in yet to be sent v2. -- Thanks, Maxim