From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jelle Licht Subject: bug#23723: patch-shebang phase breaks symlinks Date: Mon, 13 Jun 2016 21:50:01 +0200 Message-ID: <87bn3427iu.fsf@fsfe.org> References: <87fusowopk.fsf@fsfe.org> <87r3c51agw.fsf@gnu.org> <87r3c33l79.fsf@fsfe.org> <8737oiog2n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCXt4-0000Xc-Ou for bug-guix@gnu.org; Mon, 13 Jun 2016 15:51:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCXt0-0007y8-Kb for bug-guix@gnu.org; Mon, 13 Jun 2016 15:51:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:55175) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCXt0-0007y4-Gl for bug-guix@gnu.org; Mon, 13 Jun 2016 15:51:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bCXt0-0004G9-7E for bug-guix@gnu.org; Mon, 13 Jun 2016 15:51:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <8737oiog2n.fsf@gnu.org> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 23723@debbugs.gnu.org, Jelle Licht Ludovic Courtès writes: > Jelle Licht skribis: > >> Ludovic Courtès writes: >>> Hello! >>> >>> Jelle Licht skribis: >>> >>>> It seems that the patch-shebang functionality does not deal gracefully >>>> with symlinks: it just overwrites them! >>>> >>>> After struggling somewhat with getting the recently packaged node 6.0.0 >>>> to behave, I found out that `patch-shebang' in (guix build >>>> gnu-build-system) does not work properly on symlinks. >>> >>> There’s ‘patch-shebangs’ (plural) in this file, but it explicitly >>> touches only regular files (see ‘list-of-files’). >>> >> >> It seems I made a mistake when writing the bug report; I am talking >> about the `patch-shebang' defined in (guix build utils). My apologies. >> >> Also, seeing as my experience with the stat utility and similarly styled >> programming libraries was lacking, I decided to play around with the >> definition of `list-of-files': It actually does include symlinks, as >> (stat:type (stat "some-symlinked-file")) gives us a plain old 'regular. >> Looking into this a bit more, it seems that calling `stat' gives the >> exact same results on both the linked-to-file and the symlink to that >> file. >> >> For the particular problem I ran into to be fixed, it is imperative that >> `list-of-files' of `patch-shebangs' includes the symlink; it does after >> all need to be patched. The way this patching currently happens just >> clobbers symlinks. > > My bad, indeed, ‘list-of-files’ should use ‘lstat’ instead of ‘stat’. This would be one way of fixing this bug. I'd rather see that `patch-shebang' in (guix build utils) checks for symlinks, and if so, patches the actual file instead of the symlink. This is the approach I currently use in my tree to use node 6.0. Would there be any downside to this approach? > > I think a patch like attached should solve the problem. WDYT? > > We can apply it to core-updates-next if that’s fine with you. > > Thanks, > Ludo’. If this is the approach you'd rather follow, that is okay with me as well. I just think that a phase that transparently patches all files in bin/sbin, whether they are actual files or symlinks, would be more useful. Greetings, - Jelle