From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#27551: guile-cairo switch to Guile 2.2 breaks (gnu build svg) Date: Sun, 02 Jul 2017 23:01:34 +0200 Message-ID: <87bmp24kpd.fsf@gnu.org> References: <20170630212107.15122.15546@vcs0.savannah.gnu.org> <20170630212109.17CA522E1B@vcs0.savannah.gnu.org> <20170701192325.GA21895@jasmine.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dRm0L-00031v-HX for bug-guix@gnu.org; Sun, 02 Jul 2017 17:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dRm0I-0006HI-Dq for bug-guix@gnu.org; Sun, 02 Jul 2017 17:02:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:46442) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dRm0I-0006HC-AU for bug-guix@gnu.org; Sun, 02 Jul 2017 17:02:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dRm0I-00007h-3K for bug-guix@gnu.org; Sun, 02 Jul 2017 17:02:02 -0400 Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Message-ID: In-Reply-To: <20170701192325.GA21895@jasmine.lan> (Leo Famulari's message of "Sat, 1 Jul 2017 15:23:25 -0400") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Leo Famulari Cc: 27551-done@debbugs.gnu.org Leo Famulari skribis: > On Fri, Jun 30, 2017 at 05:21:08PM -0400, Ludovic Court=EF=BF=BDs wrote: >> civodul pushed a commit to branch master >> in repository guix. >>=20 >> commit e3ddb1e83296c10338d35bc687772242b2f5eac6 >> Author: Ludovic Court=C3=A8s >> Date: Fri Jun 30 23:10:46 2017 +0200 >>=20 >> gnu: guile-cairo: Switch to Guile 2.2. >>=20=20=20=20=20 >> This patch adjusts dependent packages accordingly. >>=20=20=20=20=20 >> * gnu/packages/gtk.scm (guile-cairo)[inputs]: Switch to GUILE-2.2 and >> GUILE-LIB. >> (guile-rsvg)[inputs]: Likewise. >> (guile-present)[inputs]: Likewise. >> (guile-gnome)[inputs]: Likewise. >> * gnu/packages/plotutils.scm (guile-charting)[inputs]: Switch go >> GUILE-2.2. > > This commit introduced some problems with (gnu build svg), which > prevents reconfiguring GuixSD: [...] > In ./gnu/build/svg.scm: > 51: 0 [svg->png "/gnu/store/w893227m8wllganabxqx7sn2mgga8083-guix-artwo= rk-6998d30-checkout/grub/GuixSD-fully-black-4-3.svg" ...] > > ./gnu/build/svg.scm:51:4: In procedure svg->png: > ./gnu/build/svg.scm:51:4: In procedure module-lookup: Unbound variable: r= svg-handle-new-from-file > builder for `/gnu/store/nldcbaghx031b799mq9bdh8l00hg4fz6-grub-image.png.d= rv' failed with exit code 1 Apologies for not noticing this earlier! I fixed it in a single commit, 1b0f266e40aead09be95a984bd9c6cec3dff397e, that reinstates the original commits and fixes the problem. I considered re-reverting the commits individually but that didn=E2=80=99t se= em very nice either. The problem was that Guile-RSVG was switched to Guile 2.2 but derivations are still built with Guile 2.0 by default. Thus, the derivation that creates =E2=80=9Cgrub-image.png=E2=80=9D would not find Gui= le-RSVG. The fix I committed is to explicitly build this derivation with 2.2. I agree with what you wrote: CI could in theory help avoid such problems, but we lack the resources right now. We=E2=80=99d also need to c= hange our workflow to commit to a staging branch and have a robot that automatically merges branches that pass the tests. Not trivial. For now, reverting the changes promptly was the right thing to do, so thanks for doing it. Ludo=E2=80=99.