From: Marius Bakke <mbakke@fastmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 30006-done@debbugs.gnu.org
Subject: bug#30006: bzip2 does not provide libbz2.so
Date: Tue, 27 Mar 2018 22:49:19 +0200 [thread overview]
Message-ID: <87bmf9gs6o.fsf@fastmail.com> (raw)
In-Reply-To: <87370m0y9x.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
Ludovic Courtès <ludo@gnu.org> writes:
> Hello Marius,
>
> Marius Bakke <mbakke@fastmail.com> skribis:
>
>> Ludovic Courtès <ludo@gnu.org> writes:
>>
>>> There’s no such function, which is unfortunate. But I agree it’s nicer
>>> to preserve symlinks in this case.
>>>
>>> Perhaps we should actually do:
>>>
>>> (with-directory-excursion libdir
>>> (symlink … "libbz2.so"))
>>
>> Thanks for the feedback everyone. I settled on a slightly different
>> solution, that first extracts the (full) soversion from the built
>> library, then creates symlinks for each "sub-version".
>>
>> It assumes that the major version is "1". That could be circumvented
>> with a regex, but I'm not sure if it's worth the effort.
>>
>> As an added bonus, this also creates "libbz2.so.1" which was missing too.
>>
>> WDYT of this approach? Can it be made simpler?
>
> Sounds reasonable to me. I have a suggestion:
[...]
> To avoid ‘set!’, I’d write it along these lines:
>
> ;; Create symlinks libbz2.so.1.2 -> libbz2.so.1, etc.
> (let loop ((base "libbz2.so")
> (numbers (string-split soversion #\.)))
> (unless (null? numbers)
> (let ((so-file (string-append base "." (car numbers))))
> (symlink so-file base)
> (loop so-file (cdr numbers)))))
This is much nicer, thanks! I've pushed the patch with this improvement.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2018-03-27 20:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 13:29 bug#30006: bzip2 does not provide libbz2.so Ludovic Courtès
2018-03-23 12:02 ` Marius Bakke
2018-03-23 12:19 ` Tobias Geerinckx-Rice
2018-03-23 12:38 ` Marius Bakke
2018-03-24 17:01 ` Ludovic Courtès
2018-03-26 17:36 ` Marius Bakke
2018-03-27 7:32 ` Ludovic Courtès
2018-03-27 20:49 ` Marius Bakke [this message]
2018-03-23 20:50 ` Mark H Weaver
2018-03-24 1:17 ` Tobias Geerinckx-Rice
2018-03-24 16:54 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bmf9gs6o.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=30006-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).