ludo@gnu.org (Ludovic Courtès) writes: > Here’s a revision of the patch with several modifications: I added > comments in the patch (though they don’t explain the Python-related > changes for instance; could you add a line about these?), stripped > unnecessary additions from the patch, added it to gnu/local.mk, fixed > an issue reported by ‘guix lint’ in the description. > > However, could you explain why we have #:tests? #f ? In general > disabling tests should be accompanied with a comment explaining the > reason (lack of a test suite, or “unsolvable” test failures.) If there > are test failures, we’d rather investigate than disable the tests. > > Could you send an updated patch? > Hi Ludo': Thank you for your fixes! I've attached a revised patch. I'm well beyond my comfort zone, so I hope it applies cleanly and works. The default location of pymolcas is a little sketchy, being placed in the first writable location in PATH, and I believe will not be fixed upstream: https://gitlab.com/Molcas/OpenMolcas/issues/70 I have added comments to the chemistry.scm file. I have removed the out-of-source build statement and re-enabled tests, simply by omitting those flags. Best regards, Eric