unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Marius Bakke <mbakke@fastmail.com>
Cc: 39869-done@debbugs.gnu.org
Subject: bug#39869: python-orator build fails
Date: Fri, 20 Mar 2020 21:41:06 -0400	[thread overview]
Message-ID: <87bloq4h8t.fsf@gmail.com> (raw)
In-Reply-To: <87a74a7lb6.fsf@devup.no> (Marius Bakke's message of "Fri, 20 Mar 2020 22:45:01 +0100")

Hey Marius!

Marius Bakke <mbakke@fastmail.com> writes:

> This was a surprisingly deep rabbit hole that ended pretty
> unsatisfactory with commit 51d42caa94515f43d677bdd76d53bf8bb8c7bc4e.
>
> According to a comment in the package definition, the tests were never
> supposed to run, so in the end they were just disabled.
>
> I discovered a pattern that I hadn't seen yet in the Python ecosystem:
> orator and many of its dependencies are no longer using setup.py.
> Instead they have a file called pyproject.toml and calls out to a tool
> called "poetry" to create distribution tarballs, run tests, etc; and it
> apparently also creates a setup.py for the PyPI distribution.

Interesting!

> I did not study poetry enough to figure out how it works, but we might
> need a poetry-build-system or some such if the trend continues.  Mainly
> because all packages using it seem to be stripping tests from the PyPI
> release!  :-/

Yeah.  Or make the python-build-system smart at detecting many
situations (as we discussed on IRC today such as guessing how to run the
test suite).

Thanks for fixing it!

Maxim

      reply	other threads:[~2020-03-21  1:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 18:08 bug#39869: python-orator build fails Maxim Cournoyer
2020-03-20 21:45 ` Marius Bakke
2020-03-21  1:41   ` Maxim Cournoyer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87bloq4h8t.fsf@gmail.com \
    --to=maxim.cournoyer@gmail.com \
    --cc=39869-done@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).