From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GNarFafnU1/NQAAA0tVLHw (envelope-from ) for ; Sat, 05 Sep 2020 19:31:51 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OAKgEafnU18efwAA1q6Kng (envelope-from ) for ; Sat, 05 Sep 2020 19:31:51 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id ED1759404D4 for ; Sat, 5 Sep 2020 19:31:50 +0000 (UTC) Received: from localhost ([::1]:33900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEduf-0005e7-Oc for larch@yhetil.org; Sat, 05 Sep 2020 15:31:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48438) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEdtu-0005dn-LA for bug-guix@gnu.org; Sat, 05 Sep 2020 15:31:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:60804) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEdtu-0004Qo-47 for bug-guix@gnu.org; Sat, 05 Sep 2020 15:31:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEdtu-0001tz-0x for bug-guix@gnu.org; Sat, 05 Sep 2020 15:31:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43228: r-v8 doesn't build since node 10.22 update Resent-From: Pierre Langlois Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 05 Sep 2020 19:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43228 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43228-submit@debbugs.gnu.org id=B43228.15993342167256 (code B ref 43228); Sat, 05 Sep 2020 19:31:01 +0000 Received: (at 43228) by debbugs.gnu.org; 5 Sep 2020 19:30:16 +0000 Received: from localhost ([127.0.0.1]:44117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEdtA-0001sx-0M for submit@debbugs.gnu.org; Sat, 05 Sep 2020 15:30:16 -0400 Received: from mout.gmx.net ([212.227.15.18]:44237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEdt8-0001sl-F8 for 43228@debbugs.gnu.org; Sat, 05 Sep 2020 15:30:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1599334207; bh=WnD+KR0A9eEK2ifCWpfAxF0SC2fPgRZWNbuSgNaRl84=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:In-reply-to:Date; b=OSsgc0aZZX3DBy7aSkn0xbUUDOFGpDR/oAcWCdVRk/fxcXaz0yWKOrxdAhic0yYwc sc24yr1z3BWHNJrL3dLhtegtQ5rgqKxRM3+nQ+x5Ke+q8BHGbV6EJmGO/TUTGZG4GV CTVHLRB4JUhgsLHyCKsM/6nkqx8chRUw/L+vPCyM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from e119807-lin ([82.69.64.142]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MmlXA-1kx0mG4BEs-00jrGl; Sat, 05 Sep 2020 21:30:07 +0200 References: <87sgbwi0dn.fsf@gmx.com> <87tuwcqdek.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Pierre Langlois In-reply-to: <87tuwcqdek.fsf@netris.org> Date: Sat, 05 Sep 2020 20:29:37 +0100 Message-ID: <87blikhvj2.fsf@gmx.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:Nh0apE9+VYN0xN6B3YGZ/uPkrZCJj8xhCpPW4LgmYefEzu+auS4 8fZkxXAs97Xf2zhnPZoE4m31gDCC0mbMMzTVlLgK/l/DSDiTwGQyI3mWWL6AnLNKOPdHyK0 +gkJzDBU8fBkhdXwuv6FcAbK3jl0RiYi+5Lp31VFm7ZnvsCLR4/J4xpQzv9WsotKWTkAuwf iMBlwnAILyuKSGIbBkvgw== X-UI-Out-Filterresults: notjunk:1;V03:K0:6TIBVGO/SyY=:vESXH3H/wIYrQ0HwbX/a5l th8dqubNtGGwpva6FSjyOahNCaXbbX4+vP1E18xuHded3FOQyw4pDst4MFWL0QfOc5t4+IJbe D5pbNu2yNJSt16E5FdW39EWpsDNiUHvsNJ4LUg40eB8hWoH9WlXsOsR/NPxznWO/T7iMCFxxe Tc1CPMCAYyXThas8gERi8G79xV2J70v6KHQbrmXHY7HYtKZb6vut5V+D42EGS/pbbF3sZKJ3D OI1tI9rAqBrWm7rYY8w6XoDN3rc64h1xh0sndtwZtkVow6Dalj7WPMQX140Ozun0WSjQvHh+W Ve+84NOFCU+9Ugfb2+qH92s7pX5Mn78ZYVM1juED9rzzRrkwOq5i8WXupGs2wdTYUNZGLug1x /66XSkSfu8VyBBAvz+rCu/SjxT8qz0FYj89hBaKxpHwlDiYCiHIRw71P6YtcBfbqQ039sPN9Y KWUUWIbgIXnPMZxep1f/179i3/h0PbDF0QV5sRu4kElFJBt7/9TgrFywQkAEbGhkU4wsqqVO4 +wjoOYevEFTWclHK87OLx1WCDSOcYSEKJq/n2m5Jq5liTZNJpMRitMutQj1W0mxj2tUywfCP5 njDAc0LT70AcjYhgw/3WM3AbcXsrKPeQNUkdfXMA86nELQj2RZL+HbYdP02ohKBKWkjtf370U 8xelFsRZ9pUjf4qzr4tU/BhcIkt23s5NEPYGLJg/v53guT1yo6jDT9zIRNDg4mJQnf/LnVm7V eg68D8GsWAcRy1J0Y08FbZmSh2oXO4XcknZxATuozp6VoR4UxaW4twkrwKh9DIwI+c0Y1Ok4J 56gZ/qDIdWM4F+m8iM2b8o6WFrHWJJhZwdO6QqZDNKTddc5WdeJ2Ib+jMCujtWCt/Baa13kqv ns/6H/sanWRqJRZPjtZc+GLdrjojiM8t0xBa+X3W1j4YBT+4xlxpduZU7tN4e77gYx/3FUKy6 jfV+Gw6bOvicP+4g157SzRHrPuzT2r4UaWU6CzhFzcH1saSYfCtiXIMQRNHIk/9FdvYQAU4np Z2/n2w4GSGZXPIk3pneiKVeEM9bA0dKJGYlU2p59+5erYD/2LdYkJ2WMvwW3VFtaWFlkBpfHR 1XVKH6HfNDdc0AFT/AV6qTRhoU71GtXiIYL692wy2usSvk2WCmxewsg5pINiaS13wYSITil7w rsIkk5PGOlfAz2sxwxdSwmO/o5nMY6VvTeyEWzeDU6N7hvDAhpNkqhL8aWC1ZaTfX1v7E4Vwz nit/Fbpfdza1tDbhIVss2YsFbtdhjI7uK7WeyJA== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43228@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmx.net header.s=badeba3b8450 header.b=OSsgc0aZ; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.39 X-TUID: apklKwDwCR5a --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Mark, Mark H Weaver writes: > Hi Pierre, > > I'm quoting your message out of order to ease my reply. > > Pierre Langlois writes: > >> I'm afraid I broke r-v8 and a few of its dependants by updating node, >> sorry about that! > [...] >> I'm not sure how to fix this, I'm happy to revert the node update if >> needed, let me know! Then we'd have to wait for the next core-updates >> cycle so that we no longer graft nghttp2. > > We will actually need node-10.22 (or at least 10.21) in 'master' in just > over 2 weeks, when we'll be compelled to update IceCat to version 78. > On Sept 22, Mozilla is scheduled to release a new batch of security > fixes in 78.3, and there will be no corresponding 68.x release. Oooh cool! Looking forwards to icecat 78! > (In fact, I had an *identical* commit on my private branch to update > 'node' to 10.22, to allow testing IceCat 78 WIP.) > > However, if needed, I suppose it might be sufficient for my purposes to > leave 'node' at 10.19.0, and to bind a separate 'node-10.22' variable to > the new version. > >> AFAIK, the new node uses a function from nghttp2 1.41 that's not >> present in 1.40, `nghttp2_option_set_max_settings'. However, since curl >> depends on nghttp2 we've grafted 1.40 -> 1.41 to avoid a full rebuild. >> >> Looking at r-v8's log [0], it complains that the symbol is missing, >> indicating it's trying to link with the old version 1.40. I /believe/ >> it's inherited it through r-curl. > > If grafting is working as it should, then nghttp2-1.40 should never be > linked at runtime. However, it is certainly the case that most things > (except node-10.22) are *built* against nghttp2-1.40, where the > aforementioned symbol is missing. > > One possible solution might be to update the replacement (graft) for > _curl_ so that it's *built* against nghttp2-1.41. Something like this > (untested): > > --8<---------------cut here---------------start------------->8--- > diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm > index 55b7e4393b..bfcb52b678 100644 > --- a/gnu/packages/curl.scm > +++ b/gnu/packages/curl.scm > @@ -183,6 +183,9 @@ tunneling, and so on.") > (sha256 > (base32 > "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd"))= )) > + (inputs > + `(("nghttp2" ,nghttp2-1.41 "lib") > + ,@(alist-delete "nghttp2" (package-inputs curl)))) > (arguments > (substitute-keyword-arguments (package-arguments curl) > ((#:phases phases) > --8<---------------cut here---------------end--------------->8--- > > Would you like to try this and see if it solves the problem? I'm afraid this still doesn't solve the problem. AFAIU, grafting the new curl happens after building r-v8, so at link time it still sees the old nghttp2 version. Thinking about this, since the new node essentially uses a new ABI to link with nghttp2 by requiring a new symbol, this isn't something we can fix with grafting I believe. It's possible to make r-curl specifically depend on the new curl like so: =2D-8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm index 2c202e8508..16022c695d 100644 =2D-- a/gnu/packages/cran.scm +++ b/gnu/packages/cran.scm @@ -1038,7 +1038,7 @@ if(_ca_bundle !=3D NULL) { curl_easy_setopt(handle, C= URLOPT_CAINFO, _ca_bundle); } " m))) #t))))) (inputs =2D `(("libcurl" ,curl) + `(("libcurl" ,curl-7.71.0) ("zlib" ,zlib))) (native-inputs `(("pkg-config" ,pkg-config))) diff --git a/gnu/packages/curl.scm b/gnu/packages/curl.scm index 55b7e4393b..aa103306a6 100644 =2D-- a/gnu/packages/curl.scm +++ b/gnu/packages/curl.scm @@ -172,7 +172,7 @@ tunneling, and so on.") (inputs (alist-delete "openldap" (package-inputs curl)))))) =20 ;; Replacement package to fix CVE-2020-8169 and CVE-2020-8177. =2D(define curl-7.71.0 +(define-public curl-7.71.0 (package (inherit curl) (version "7.71.0") @@ -183,6 +183,9 @@ tunneling, and so on.") (sha256 (base32 "0wlppmx9iry8slh4pqcxj7lwc6fqwnlhh9ri2pcym2rx76a8gwfd")))) + (inputs + `(("nghttp2" ,nghttp2-1.41 "lib") + ,@(alist-delete "nghttp2" (package-inputs curl)))) (arguments (substitute-keyword-arguments (package-arguments curl) ((#:phases phases) =2D-8<---------------cut here---------------end--------------->8--- But I'm not sure I like this very much, this is getting a bit messy. Instead, I'm thinking your suggestion of leaving 'node' at 10.19 for now (or 10.20, I can try that) and then introduce a 'node-10.22' package that can be used for Icecat is better. I can do that. How does that sound? Thanks, Pierre --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQFMBAEBCAA2FiEEctU9gYy29KFyWDdMqPyeRH9PfVQFAl9T5yEYHHBpZXJyZS5s YW5nbG9pc0BnbXguY29tAAoJEKj8nkR/T31U1FwH+gOHU7kaXjGVnnQmwMkuIHyT JDM55/wUtEyzVFJjpH8EC8k5KoBn2zKHljQv3Z/329y96wjJ++C/R4dJgCv7Fx2e v+SOffrBFEB+ANSqHSDAZLAIBoUJl+ewQWWpJMi4aZSiv+gPje15COJD0cUBKnJu S5uA6rcRTxqPZAGhyTT22WCnzxJ8APyTHw1fDuuA8Tzd5QusKV1vTqAMccepSRoK VizgxLX0ZYXMqYgzcEVXSKzwqyKcCIO92CEgrgMjpzcYqxCy1P8gQAxPckYCdpI0 3QCmwo2SAO6PGCOa6gmDS5rxAGhtsgrYbJlbMfotb9sbj+2ppnbAcvKUey2cZ18= =cjHU -----END PGP SIGNATURE----- --=-=-=--