From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KGTICngtYV9vNAAA0tVLHw (envelope-from ) for ; Tue, 15 Sep 2020 21:09:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id Iuv1BHgtYV/MawAAbx9fmQ (envelope-from ) for ; Tue, 15 Sep 2020 21:09:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8F92694066B for ; Tue, 15 Sep 2020 21:09:11 +0000 (UTC) Received: from localhost ([::1]:50948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIICM-0003mY-Io for larch@yhetil.org; Tue, 15 Sep 2020 17:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42776) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIICE-0003lu-6f for bug-guix@gnu.org; Tue, 15 Sep 2020 17:09:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:49149) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIICD-0008VN-TJ for bug-guix@gnu.org; Tue, 15 Sep 2020 17:09:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIICD-0003W6-OD for bug-guix@gnu.org; Tue, 15 Sep 2020 17:09:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43232: [PATCH] gnu: jack-2: Update to 1.9.14. Resent-From: Mike Rosset Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 15 Sep 2020 21:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43232 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Received: via spool by 43232-submit@debbugs.gnu.org id=B43232.160020408213425 (code B ref 43232); Tue, 15 Sep 2020 21:09:01 +0000 Received: (at 43232) by debbugs.gnu.org; 15 Sep 2020 21:08:02 +0000 Received: from localhost ([127.0.0.1]:60692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIIBG-0003UI-1p for submit@debbugs.gnu.org; Tue, 15 Sep 2020 17:08:02 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:43449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIIBC-0003Tx-G0 for 43232@debbugs.gnu.org; Tue, 15 Sep 2020 17:08:00 -0400 Received: by mail-pf1-f195.google.com with SMTP id f18so2660664pfa.10 for <43232@debbugs.gnu.org>; Tue, 15 Sep 2020 14:07:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version; bh=2SPkFXa81hWhwvqrnw56GjBrwGtSkUhPATLRg6aomBI=; b=DzjyCoW39r1xDIOuRR0D3+issb3IhAz/rGXC9h6IN1FaMQhkL6T199mkl+lSb+I9pQ 6J4ws9UjBo4fy8z7FGTr/eQ0ME9tNO8xn+NyXh3OgAkDMHDRQ7KB+q94hOLiU8WTOUhO QZAP5v2PNCZ1YjqfdhWky9HyRptkBJo0V8J6ks6oM9xE4H8ts4wJTEeXddMdYQ1RdJn9 liCW//qh/3tU+pN+Yh4Khfwpm0rgvDX0VsJ5tenWENq4zR+knlR1vzJXUYOdtB3xB8al ZPmAeVEc6/YVuuA/taVwdgFTcqA3VDfdPcv2LkUMJYEazfJJgU9Ydo1NWpVWEDE8tQmL sc+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version; bh=2SPkFXa81hWhwvqrnw56GjBrwGtSkUhPATLRg6aomBI=; b=diEmYn9Q1nj8GJ60dCm54ql3bhCwKMaqeXdo/LU3CDETBVx8ByIXhyh8xocXOBCnGe xfUycZqVGLN65g1jzt/gXmkzinqF0dv7b6gGeHdVGmoLfds5zAlJfmcti1TXKZLiN7b3 gep4RGFL6bdoWUyRKeuqs3QdJRPuvmEjQyFuVzEZP5Ue7aPfwsjFdxa+nhLhkdiPrdAH JZ6eb1O9aedRweFwhxYE8alzWTsho4twOzPr6aVDiXRagGRa5l8ii+8B/lqNumizAX2h iqH6oPLqFnV0qvJHL8iKcgItoOYylff0Uyfq+pPLHnbs4XBnWuSC4XI7NmdGIlERKNwy vgew== X-Gm-Message-State: AOAM533+4jWCDabxGacX+YTmjtkSx7GA1jG/bV3YJXVIFmgAZ/tX6WJ4 ncHgkh/5IFdmSyoW8eIrITn8DrFvAME= X-Google-Smtp-Source: ABdhPJyphmAGp62MMJb+oTx2598XNvSEHC9/9W6EuPCjDQkVjw9ZhWAlquB3SolcIwI+MhnT5p/4Qg== X-Received: by 2002:a63:5f03:: with SMTP id t3mr15942691pgb.258.1600204072217; Tue, 15 Sep 2020 14:07:52 -0700 (PDT) Received: from neutron (S010664777da04f43.vf.shawcable.net. [70.68.94.152]) by smtp.gmail.com with ESMTPSA id bx22sm394118pjb.23.2020.09.15.14.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Sep 2020 14:07:51 -0700 (PDT) References: <87363v7e7j.fsf@disroot.org> <20200915042525.4186311-1-mike.rosset@gmail.com> <20200915062139.GF17272@E5400> <87ft7ibwpz.fsf@netris.org> User-agent: mu4e 1.4.13; emacs 27.1 From: Mike Rosset In-reply-to: <87ft7ibwpz.fsf@netris.org> Date: Tue, 15 Sep 2020 14:07:50 -0700 Message-ID: <87bli6ycih.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43232@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=DzjyCoW3; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: dCP+AKkqPBHR Mark H Weaver writes: > Efraim Flashner writes: > >> On Mon, Sep 14, 2020 at 09:25:25PM -0700, Mike Rosset wrote: >>> * gnu/packages/audio.scm (jack-2): Update to 1.9.14. >>> [arguments]: new 'declare-for-int phase after unpack that declares 'i in the >>> for initialize statement. Add -lstdc++ to LDFLAGS 'set-linkflags phase >>> ensures -lstdc++ is at the tail. > [...] >>> @@ -2047,8 +2047,18 @@ synchronous execution of all clients, and low latency operation.") >>> "--alsa") >>> #:phases >>> (modify-phases %standard-phases >>> + (add-after 'unpack 'declare-for-int >>> + (lambda _ >>> + ;; Declare the for loop i incrementer. >>> + (substitute* "dbus/sigsegv.c" >>> + (("for\\(i = 0") "for(int i = 0")) >>> + #t)) >> >> Any chance of an upstream bug number or something for this? It seems >> like the type of thing that might be put into a snippet. > > I agree that somehow this fix should be in the 'origin', so that this > fix will be in the output of "guix build --source". However, I'd go > further and suggest that it should be a patch instead of a call to > 'substitute*'. > > Although patches are larger and a bit more work to create, they are far > more robust. When this bug is eventually fixed upstream, a patch to fix > it will begin raising an error, alerting us that it's time to remove it. > > In contrast, a call to 'substitute*' will silently start doing nothing, > and may easily be forgotten. To make matters worse, a future version of > jack-2 might add another 'for' loop in that file, matching the same > pattern but where it is important that 'i' _not_ be initialized to 0. > This 'substitute*' call, likely vestigial by that time but long since > forgotten, could start silently introducing a new bug. > > What do you think? > > Thanks, > Mark Hello Mark, Turns out version 1.9.14 is not effected by this. So the version bump is good enough. I resubmitted a first in series with just the version bump and linker change. Which Andreas has merged into master. Mike