From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id KEzcMff3YV8ccgAA0tVLHw (envelope-from ) for ; Wed, 16 Sep 2020 11:33:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OIKzLff3YV/UBAAA1q6Kng (envelope-from ) for ; Wed, 16 Sep 2020 11:33:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4A1849404D7 for ; Wed, 16 Sep 2020 11:33:11 +0000 (UTC) Received: from localhost ([::1]:51076 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kIVgU-0000Vc-6t for larch@yhetil.org; Wed, 16 Sep 2020 07:33:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIVgM-0000Tt-C6 for bug-guix@gnu.org; Wed, 16 Sep 2020 07:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:50105) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kIVgL-0005vp-RP for bug-guix@gnu.org; Wed, 16 Sep 2020 07:33:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kIVgL-0003xU-NB for bug-guix@gnu.org; Wed, 16 Sep 2020 07:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43418: ffprobe/avprobe and ffmpeg/avconv should be added as dependencies of youtube-dl so it will function correctly Resent-From: Mark H Weaver Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 16 Sep 2020 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43418 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Tobias Geerinckx-Rice X-Debbugs-Original-Cc: ncdehnel@gmail.com, 43418@debbugs.gnu.org, bug-guix@gnu.org, Leo Famulari Received: via spool by submit@debbugs.gnu.org id=B.160025592413547 (code B ref -1); Wed, 16 Sep 2020 11:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 Sep 2020 11:32:04 +0000 Received: from localhost ([127.0.0.1]:33413 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVfP-0003WG-SB for submit@debbugs.gnu.org; Wed, 16 Sep 2020 07:32:04 -0400 Received: from lists.gnu.org ([209.51.188.17]:43840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kIVfO-0003V3-Ei for submit@debbugs.gnu.org; Wed, 16 Sep 2020 07:32:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIVfO-000879-1o for bug-guix@gnu.org; Wed, 16 Sep 2020 07:32:02 -0400 Received: from world.peace.net ([64.112.178.59]:33972) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kIVfL-0005oW-8P for bug-guix@gnu.org; Wed, 16 Sep 2020 07:32:01 -0400 Received: from mhw by world.peace.net with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kIVfG-0000vv-W9; Wed, 16 Sep 2020 07:31:55 -0400 From: Mark H Weaver In-Reply-To: <875z8ertcp.fsf@nckx> References: <87bli7s0r0.fsf@nckx> <20200915231706.GB20807@jasmine.lan> <87mu1q9lyw.fsf@netris.org> <875z8ertcp.fsf@nckx> Date: Wed, 16 Sep 2020 07:30:35 -0400 Message-ID: <87bli69cw9.fsf@netris.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=64.112.178.59; envelope-from=mhw@netris.org; helo=world.peace.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/16 07:31:55 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -2.3 (--) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ncdehnel@gmail.com, 43418@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: pUAIaKbmCgs9 Hi Tobias, Tobias Geerinckx-Rice writes: > Mark H Weaver =E5=86=99=E9=81=93=EF=BC=9A > >> I see two possible approaches: ffmpeg could be added to youtube-dl's >> propagated-inputs, or it could be instead be added to 'inputs', and >> we could substitute hardcoded paths to 'ffmpeg' in the built >> 'youtube-dl'. I generally tend to favor the latter approach, but >> there are valid arguments for each approach and I don't feel strongly >> about it. > > Which advantages does the former have? I wasn't aware of any. The former approach is arguably simpler, easier to maintain, and if the user upgrades only 'ffmpeg' while leaving 'youtube-dl' unchanged, with the latter approach 'youtube-dl' will continue using the old 'ffmpeg' with its potential security holes, which users unfamiliar with Guix might not expect. I still generally prefer the latter approach for several reasons, most notably because it means fewer dynamically-determined dependencies, which are contrary to our goals for reproducible behavior, i.e. that if the software in a given store item works today for your use case, it will work the same way tomorrow. However, it's worth noting that this property is less useful for a program like 'youtube-dl', because a copy of 'youtube-dl' that works today might well stop working tomorrow because of changes made on the server side, regardless of our efforts. Mark