From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id oPZ2GhMEhV9gCAAA0tVLHw (envelope-from ) for ; Tue, 13 Oct 2020 01:34:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id SNJRFhMEhV8qHAAAbx9fmQ (envelope-from ) for ; Tue, 13 Oct 2020 01:34:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 37C9F9400D3 for ; Tue, 13 Oct 2020 01:34:10 +0000 (UTC) Received: from localhost ([::1]:51086 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kS9Ca-0000Nk-KB for larch@yhetil.org; Mon, 12 Oct 2020 21:34:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38478) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kS9CU-0000Nb-Cx for bug-guix@gnu.org; Mon, 12 Oct 2020 21:34:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:32996) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kS9CU-0003wk-2K for bug-guix@gnu.org; Mon, 12 Oct 2020 21:34:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kS9CT-0008Ss-Vb for bug-guix@gnu.org; Mon, 12 Oct 2020 21:34:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#43893: [PATCH] maint: update-guix-package: Ensure sources are clean. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 13 Oct 2020 01:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43893 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 43893-submit@debbugs.gnu.org id=B43893.160255281532505 (code B ref 43893); Tue, 13 Oct 2020 01:34:01 +0000 Received: (at 43893) by debbugs.gnu.org; 13 Oct 2020 01:33:35 +0000 Received: from localhost ([127.0.0.1]:44542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9C2-0008SD-V8 for submit@debbugs.gnu.org; Mon, 12 Oct 2020 21:33:35 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:37922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kS9C1-0008Rz-9h for 43893@debbugs.gnu.org; Mon, 12 Oct 2020 21:33:33 -0400 Received: by mail-qk1-f196.google.com with SMTP id f21so6619096qko.5 for <43893@debbugs.gnu.org>; Mon, 12 Oct 2020 18:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=9mPjx18hwIdDmWQzIlfiNTKBM70KlWbH2rNPzuWwsuE=; b=DtoPmsklsrTMQYY2fA82ZKg+UYFHFInwqg2EP+rUQY0gp8JZEiKmoc7CZMOhY9/FTT HY1bBqvPlPt4c0pDNYw/XgLAL48Fx8uwRLQFqPxHSzAwdP9cci0awVTLtzmbAokZP7gw kb/rXtwli5zlx3mjjhK8IG6qFZKztVEmSe59WCWzRrChfeCfN/nln7P9k+CUNo5XMkvI eUqqAhV5BixSigK4ZmFRx0ernXRzl3Z0XGapV8ebSwG9N25Hu4W1Ja7hZ6oMyGNLuesK B8Ccba2RHM9c/GYd7BnhJdRnPWRsKOQzLQjeXpWoaGryUIJtpBR90zGcKnfNyzJ4zlug gl1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=9mPjx18hwIdDmWQzIlfiNTKBM70KlWbH2rNPzuWwsuE=; b=pV45s+ZibBlDae1C7qsY4TjDqPoOet8ZG41weVAk8t2/J44cCZrEU104mcf3I1sK0A NC7M0aOXoBNFxF8xVS6FwSeExcmvPQETw6aSyynhHqDy7hwj1V1XwyqyulGl2cH0qq1B aSnJifWnsPKIQaKfYlo65zGAfZY+sIX56AK3eQBESwgke3UY+R1xlBqPsBllkrV3iY3L e9sdFITH/LSyIKFhkObR/hclXl8YwZaZHs10zswRrXV64uwnFrPB2kLoCYJuUUGFkt8f T0CMVQJMtGt2YnVA1eaMMIUAX85rJhDOaXKQEkMHELVWyW6J4wUIsk5mbsVZxRDzi0i7 6hTw== X-Gm-Message-State: AOAM5306RcqBRIZ6yPtx32qurY1z9gHd3HHZgdcoEJ0GhcpBAXmYk+Zr VJURBt7OqCEUmfg4RLCHSIaVQ/A9ADA= X-Google-Smtp-Source: ABdhPJxcHyujzQfyvOL7jPfpMSLwMhW3D0PWTorMvIqBI623PS8ZesxqmDVB2w9F6xbdBU9LF28xcg== X-Received: by 2002:a37:480f:: with SMTP id v15mr12328439qka.279.1602552807457; Mon, 12 Oct 2020 18:33:27 -0700 (PDT) Received: from hurd (dsl-10-136-39.b2b2c.ca. [72.10.136.39]) by smtp.gmail.com with ESMTPSA id d129sm13940819qkg.127.2020.10.12.18.33.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Oct 2020 18:33:26 -0700 (PDT) From: Maxim Cournoyer References: <87eem7qcxc.fsf@gmail.com> <20201010050852.19975-1-maxim.cournoyer@gmail.com> <871ri5j13g.fsf@gnu.org> <875z7gtupi.fsf@gmail.com> <87lfgbvky6.fsf@gnu.org> Date: Mon, 12 Oct 2020 21:33:26 -0400 In-Reply-To: <87lfgbvky6.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Mon, 12 Oct 2020 11:43:13 +0200") Message-ID: <87blh69aft.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.0 (-) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 43893@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=gmail.com header.s=20161025 header.b=DtoPmskl; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: oofVtd5uHiyC Hi Ludovic, Ludovic Court=C3=A8s writes: > Hi, > > Maxim Cournoyer skribis: > >> Ludovic Court=C3=A8s writes: >> >> [...] >> >>>> * build-aux/update-guix-package.scm (git-add-worktree): New procedure. >>>> (main): Use it to checkout a clean copy of the used commit, and comput= e the >>>> hash from it. Print a user warning after completion. >>> >>> I=E2=80=99m not quite enthusiastic about the tool creating a worktree b= ehind my >>> back. >> >> May I ask why? It's not something you'd (need to) be aware of (it >> doesn't leave traces in my v2 as 'git worktree prune' clears up the >> temporary worktree entries), and it's quite cheap to create. > > To me, this is all my workspace, and I generally assume I=E2=80=99m the o= nly one > touching it; it=E2=80=99s more about the mental model, I guess. I see. I understand your position, but also feel it's not a big deal here, given you wouldn't be able to notice a new worktree unless you watch the output of 'git worktree list' in a loop while updating the guix package ;-). I think the change brings good guarantees to guard against breaking 'guix pull' with a 'make update-guix-package' as it is, and also documents the thing. If it's OK with you I'd like to merge it in the coming days. Thanks, Maxim