From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 4LZHIb7ZnV/hMwAA0tVLHw (envelope-from ) for ; Sat, 31 Oct 2020 21:40:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id cCYLHb7ZnV+VWAAAbx9fmQ (envelope-from ) for ; Sat, 31 Oct 2020 21:40:14 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 21B63940430 for ; Sat, 31 Oct 2020 21:40:14 +0000 (UTC) Received: from localhost ([::1]:38602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYybd-0000KC-4b for larch@yhetil.org; Sat, 31 Oct 2020 17:40:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:39948) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYybT-0000Jn-BE for bug-guix@gnu.org; Sat, 31 Oct 2020 17:40:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51391) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYybR-0007rp-Jk for bug-guix@gnu.org; Sat, 31 Oct 2020 17:40:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kYybR-0005Ls-HO for bug-guix@gnu.org; Sat, 31 Oct 2020 17:40:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#44196: [PATCH 2/3] system: Add store-directory-prefix to boot-parameters. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 31 Oct 2020 21:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44196 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas Received: via spool by 44196-submit@debbugs.gnu.org id=B44196.160418039020551 (code B ref 44196); Sat, 31 Oct 2020 21:40:01 +0000 Received: (at 44196) by debbugs.gnu.org; 31 Oct 2020 21:39:50 +0000 Received: from localhost ([127.0.0.1]:34704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYybG-0005LO-HO for submit@debbugs.gnu.org; Sat, 31 Oct 2020 17:39:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYybE-0005LC-De for 44196@debbugs.gnu.org; Sat, 31 Oct 2020 17:39:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43933) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYyb9-0007pP-24; Sat, 31 Oct 2020 17:39:43 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46208 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYyb8-0006z7-1Y; Sat, 31 Oct 2020 17:39:42 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <878sbvh5j4.fsf@gmail.com> <87y2jvfqon.fsf@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 10 Brumaire an 229 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sat, 31 Oct 2020 22:39:40 +0100 In-Reply-To: <87y2jvfqon.fsf@gmail.com> ("Miguel =?UTF-8?Q?=C3=81ngel?= Arruga Vivas"'s message of "Sat, 24 Oct 2020 20:02:16 +0200") Message-ID: <87blgit6qr.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 44196@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: ns3122888.ip-94-23-21.eu Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.51 X-TUID: XnOYcRVWtJu3 Hi! Miguel =C3=81ngel Arruga Vivas skribis: > From 527a9271122f7b83f31dc0b910c6704af81bde66 Mon Sep 17 00:00:00 2001 > From: =3D?UTF-8?q?Miguel=3D20=3DC3=3D81ngel=3D20Arruga=3D20Vivas?=3D > > Date: Sat, 24 Oct 2020 18:15:53 +0200 > Subject: [PATCH 2/2] system: Add store-directory-prefix to boot-parameter= s. > > * gnu/machine/ssh.scm (roll-back-managed-host): Use > boot-parameters-store-directory-prefix. > * gnu/system.scm (define-module): Export > boot-parameters-store-directory-prefix. > ()[store-directory-prefix]: New field. > [boot-parameters-store-directory-prefix]: New accessor. > (read-boot-parameters): Read directory-prefix from store field. > (operating-system-boot-parameters-file): Add directory-prefix to > store field. > * guix/scripts/system.scm (reinstall-bootloader): Use > boot-parameters-store-directory-prefix. > * test/boot-parameters.scm (%default-btrfs-subvolume, > %default-store-directory-prefix): New variables. > (%grub-boot-parameters): Use %default-store-directory-prefix. > (%default-operating-system): Use %default-btrfs-subvolume. > (test-boot-parameters): Add directory-prefix. > (test optional fields): Add test for directory-prefix. > (test os store-directory-prefix): New test. [...] > +++ b/gnu/system.scm > @@ -148,6 +148,7 @@ > boot-parameters-bootloader-name > boot-parameters-bootloader-menu-entries > boot-parameters-store-device > + boot-parameters-store-directory-prefix > boot-parameters-store-mount-point > boot-parameters-locale > boot-parameters-kernel > @@ -299,6 +300,7 @@ directly by the user." > boot-parameters-bootloader-menu-entries) > (store-device boot-parameters-store-device) > (store-mount-point boot-parameters-store-mount-point) > + (store-directory-prefix boot-parameters-store-directory-prefix) Could you explain why we need =E2=80=98store-directory-prefix=E2=80=99 in a= ddition to =E2=80=98store-mount-point=E2=80=99? At first sight, looking at the fields= in there, these two can seem to be synonymous. Also patch #3 doesn=E2=80=99t depend on it, does it? Thanks, Ludo=E2=80=99.