From: Mark H Weaver <mhw@netris.org>
To: Jonathan Brielmaier <jonathan.brielmaier@web.de>, 48273@debbugs.gnu.org
Subject: bug#48273: Icedove 78.10.0 build stuck at 'unpack' phase
Date: Fri, 04 Jun 2021 20:42:32 -0400 [thread overview]
Message-ID: <87bl8lgmzw.fsf@netris.org> (raw)
In-Reply-To: <7726464e-4722-1d7f-816b-1e2bb07df9c0@web.de>
Hi Jonathan,
I wrote:
> Unfortunately, not all of our package definitions respect the --cores
> option. Our 'icecat' package does, but I can see now that our
> 'icedove' package does _not_ respect it. It would be good to fix that.
Jonathan Brielmaier <jonathan.brielmaier@web.de> replied:
> @Mark: Yes, it would by nice to fix that. Do we make something special
> in Icecat to achieve that? I couldn't find anything obvious on a first
> view...
There's nothing special in the IceCat package to achieve it. The
relevant code is in the default 'build' phase from 'gnu-build-system',
here:
<https://git.sv.gnu.org/cgit/guix.git/tree/guix/build/gnu-build-system.scm?id=7382aa00b82860762bc326dec6b45f8cd2161327#n338>
_ (define* (build #:key (make-flags '()) (parallel-build? #t)
_________________ #:allow-other-keys)
___ (apply invoke "make"
__________ `(,@(if parallel-build?
__________________ `("-j" ,(number->string (parallel-job-count)))
__________________ '())
____________ ,@make-flags)))
The problem is that the 'icedove' package has a custom 'build' phase
that does not honor (parallel-job-count).
Ultimately, the relevant difference between the two packages is that the
'icecat' package uses the 'gnu-build-system' approach of running
"./configure", "make" and "make install", whereas the 'icedove' package
uses the (Mozilla-preferred) approach of creating a ".mozconfig" file
and running "./mach configure", "./mach build" and "./mach install".
If I remember correctly (from when I looked at the process listings
provided in this bug report), "./mach build" seems to be passing a
"-j<N>" argument to "make", but at present we have no control over the
<N> is.
The best solution would be to find a way to tell "./mach build" to pass
a specific value of <N>. Ideally, <N> should be (parallel-job-count) if
'parallel-build?' is #t, otherwise it should be 1.
What do you think?
Thanks,
Mark
--
Disinformation flourishes because many people care deeply about injustice
but very few check the facts. Ask me about <https://stallmansupport.org>.
next prev parent reply other threads:[~2021-06-05 0:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-07 6:43 bug#48273: Icedove 78.10.0 build stuck at 'unpack' phase bo0od
2021-05-08 15:48 ` Leo Famulari
2021-05-08 19:19 ` bo0od
2021-05-08 19:59 ` Mark H Weaver
2021-05-11 0:21 ` bo0od
2021-05-11 1:30 ` Leo Famulari
2021-05-11 1:31 ` Leo Famulari
2021-05-13 18:36 ` Mark H Weaver
2021-05-13 19:28 ` bo0od
2021-05-13 19:33 ` bo0od
2021-05-14 16:13 ` Mark H Weaver
2021-05-15 4:07 ` bo0od
2021-06-04 9:43 ` Jonathan Brielmaier
2021-06-05 0:42 ` Mark H Weaver [this message]
2021-06-08 17:38 ` bug#48273: [PATCH] gnu: icedove: Respect parallel-job-count while building Jonathan Brielmaier
2021-06-18 9:34 ` Ludovic Courtès
2021-06-24 9:15 ` Jonathan Brielmaier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl8lgmzw.fsf@netris.org \
--to=mhw@netris.org \
--cc=48273@debbugs.gnu.org \
--cc=jonathan.brielmaier@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).