From: Simon South <simon@simonsouth.net>
To: 50346@debbugs.gnu.org
Subject: bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64
Date: Sat, 04 Sep 2021 15:51:30 -0400 [thread overview]
Message-ID: <87bl58w24d.fsf@simonsouth.net> (raw)
In-Reply-To: <87tuj1wdrm.fsf@simonsouth.net> (Simon South's message of "Fri, 03 Sep 2021 17:27:41 -0400")
Simon South <simon@simonsouth.net> writes:
> But this additional call _is_ expected on Guix systems, so the test
> cases ought to be modified to match.
Perhaps, but having looked into this it's complicated because
- The expected output from the tests is not contained in the source
bundle in a separate, easy-to-patch file but is actually generated by
the C code under test as it runs;
- Even if that weren't true, only one test must be patched for both to
succeed, and the choice depends on the target architecture so there
wouldn't be a single patch that could work in all cases; and
- The additional output that needs to be generated by the C code
actually embeds part of a store path, meaning this would need to be
determined by the code at runtime (possibly yielding even more
"readlink" calls that would need to be accounted for) in addition to
truncating and formatting the output to match what strace itself
produces...
It's too much. I'm going to follow up with a patch that basically
applies the diff above in a tidy manner, and I think that will be the
best solution. It is a very limited change that does not alter the
purpose of the tests; does not allow them to pass where they would
normally fail; and will work equally well on all systems, even if a
completely different glibc package is introduced. Certainly it is an
improvement over simply disabling both tests.
--
Simon South
simon@simonsouth.net
next prev parent reply other threads:[~2021-09-04 19:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 19:24 bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Simon South
2021-09-02 22:41 ` Simon South
2021-09-03 12:15 ` Bengt Richter
2021-09-03 14:00 ` Simon South
2021-09-03 16:53 ` Bengt Richter
2021-09-03 21:27 ` Simon South
2021-09-04 19:51 ` Simon South [this message]
2021-09-04 19:58 ` bug#50346: [PATCH core-updates-frozen] gnu: strace: Allow readlink, readlinkat tests to pass Simon South
2021-11-18 13:13 ` bug#50346: core-updates-frozen: strace 5.13 fails "make check" on AArch64 Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl58w24d.fsf@simonsouth.net \
--to=simon@simonsouth.net \
--cc=50346@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).