From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 51983@debbugs.gnu.org
Subject: bug#51983: guix build: error: integer expected from stream
Date: Wed, 24 Nov 2021 14:52:14 -0500 [thread overview]
Message-ID: <87bl29z5zl.fsf@gmail.com> (raw)
In-Reply-To: <87h7c77toj.fsf@nckx> (Tobias Geerinckx-Rice's message of "Fri, 19 Nov 2021 21:47:31 +0100")
Hello Tobias!
Tobias Geerinckx-Rice <me@tobias.gr> writes:
> Guix,
>
> I saw this reported by jlicht on #guix but I'm pretty sure that
> it's been reported a few times.
>
> Here's the error, with channel:
>
> (channel
> (name 'guix) (url "https://git.savannah.gnu.org/git/guix.git")
> (branch "core-updates-frozen")
> (introduction
> (make-channel-introduction
> "9edb3f66fd807b096b48283debdcddccfea34bad"
> (openpgp-fingerprint
> "BBB0 2DDF 2CEA F6A8 0D1D E643 A2A0 6DF2 A33A 54FA"))))
>
> And patch:
>
> From: Tobias Geerinckx-Rice <me@tobias.gr>
> Date: Fri, 19 Nov 2021 17:37:44 +0100
> Subject: [PATCH] daemon: Print the line whence we expect an
> integer.
>
> * nix/libstore/local-store.cc
> (LocalStore::getLineFromSubstituter):
> Include the malformed substituter stream line in the error
> message.
>
> ---
> nix/libstore/local-store.cc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/nix/libstore/local-store.cc
> b/nix/libstore/local-store.cc
> index 675d1ba66f..83b6681122 100644
> --- a/nix/libstore/local-store.cc
> +++ b/nix/libstore/local-store.cc
> @@ -839,7 +839,8 @@ template<class T> T
> LocalStore::getIntLineFromSubstituter(Agent & run)
> {
> string s = getLineFromSubstituter(run);
> T res;
> - if (!string2Int(s, res)) throw Error("integer expected from
> stream");
> + if (!string2Int(s, res))
> + throw Error(format("integer expected from stream: %1%") %
> s);
> return res;
> }
I just stumbled on this.
LGTM!
Maxim
prev parent reply other threads:[~2021-11-24 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 20:47 bug#51983: guix build: error: integer expected from stream Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-11-19 21:03 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2021-11-24 23:24 ` Ludovic Courtès
2021-11-24 19:52 ` Maxim Cournoyer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bl29z5zl.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=51983@debbugs.gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).