From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 54061@debbugs.gnu.org
Subject: bug#54061: thermald-2.4.7 build fail following upower update to 0.99.15
Date: Sat, 19 Feb 2022 21:52:53 +0100 [thread overview]
Message-ID: <87bkz24lzu.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <9922be8cfec9a0308994ace899a08e4f9d170525.camel@telenet.be> (Maxime Devos's message of "Sat, 19 Feb 2022 15:55:39 +0100")
Hello,
Maxime Devos <maximedevos@telenet.be> writes:
> `(#:configure-flags
> - (let ((out (assoc-ref %outputs "out")))
> - (list (string-append "--with-dbus-sys-dir="
> - out "/etc/dbus-1/system.d")
> - "--localstatedir=/var"))
> + ,#~(list (string-append "--with-dbus-sys-dir="
> + #$output "/etc/dbus-1/system.d")
> + "--localstatedir=/var")
The patches look good, but I'm not sure it is a good idea to publicize
the unquote+ungexp, alias ",#~", style. IIUC, in
<https://guix.gnu.org/fr/blog/2021/the-big-change/> there's some
reasoning against the abuse of unquoting. This kind of defeat the
simplicity introduced with G-expressions. So, I would favor writing:
(list
#:configure-flags
#~(list ...))
WDYT?
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2022-02-19 20:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 17:07 bug#54061: thermald-2.4.7 build fail following upower update to 0.99.15 Paul Jewell
2022-02-19 14:15 ` Paul Jewell
2022-02-19 14:55 ` Maxime Devos
2022-02-19 20:52 ` Nicolas Goaziou [this message]
2022-02-19 20:58 ` Paul Jewell
2022-03-02 17:03 ` Ludovic Courtès
2022-03-03 16:33 ` Paul Jewell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkz24lzu.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=54061@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).