From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id T9SDLexf8mMkdQEAbAwnHQ (envelope-from ) for ; Sun, 19 Feb 2023 18:44:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id kC2iLOxf8mMFQQAA9RJhRA (envelope-from ) for ; Sun, 19 Feb 2023 18:44:12 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0678DBFD for ; Sun, 19 Feb 2023 18:44:11 +0100 (CET) Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PzZaXght; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1676828652; a=rsa-sha256; cv=none; b=bBBgiS/lKGCUIYqI9q6mm1orsvT7VQowJ8JP8xbwCXK5lxnHf9iZ0jtzrQq30Ytwq+aNeR Hm/pi2cQJBw1Sgz7+mr61tONNWBjvZEPESbAEfFepgbECM9gESfwlu2hjAkhm0kPrUQUEa IaSVsROYTfmLyfU8mlrHLBYb23B7gIKPgZUve5L6Uiz3PncN5BsR71QdzbvX9mjusjObVQ xIlRXV+XrEIDqpPIumqZYnSXJKMe40gPURGTHciBDn+Wa6Bwym4Z8PmtvvfH1E77r1D02u AWorz47EYL7a6dZJ6zCMwUuA0hiK4lkxxisKK7QYIENReAs21uox4LbGurX52w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20210112 header.b=PzZaXght; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1676828652; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=zyaJU48qr6Q5VDnpWqHvveDdIZlmI+iZgMl4gz5dqcs=; b=gZ1umrOcIiDIzF5t0wG1yDuu9PYy3xXefOQ+aSRkTws2ZYHc4mGlwUapjWeBBzefnpGJeu KxS9CaeXO9eIW3wjEmwIH5VX2uVIajlPSIJg3tIj1WOhAkM+lADy7xIqC7Q0zhOkXpBv/V SoJ3rDSamXPXHCqvd5OOuDHGPVtjqAdoopE8vpifpWHqzyTc7u+ftbl5NQEGbvwFdVgeJ8 e7oFmEP2/KlFY6CXJ/qZoFIQ5g5eCAqBdWAlI/SfHLerFYnsbbsAk2e9tR2yGu26Yr/i5E TXLoWnq8rmOdJYSH40EBG+2lEzCOCd4IzzlWkGIlH79qVYtp7v0caiFhAIU9rw== Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pTnjJ-0007jp-2m; Sun, 19 Feb 2023 12:44:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pTnjG-0007jF-QH for bug-guix@gnu.org; Sun, 19 Feb 2023 12:44:02 -0500 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pTnjG-0005hJ-H5 for bug-guix@gnu.org; Sun, 19 Feb 2023 12:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pTnjG-0006Tq-5S for bug-guix@gnu.org; Sun, 19 Feb 2023 12:44:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#32026: [PATCH 03/10] gnu: Define UPSTREAM-FIREFOX-SOURCE at the top level. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sun, 19 Feb 2023 17:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32026 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Mark H Weaver Cc: 32026@debbugs.gnu.org, ludo@gnu.org, Jonathan Brielmaier Received: via spool by 32026-submit@debbugs.gnu.org id=B32026.167682862824877 (code B ref 32026); Sun, 19 Feb 2023 17:44:02 +0000 Received: (at 32026) by debbugs.gnu.org; 19 Feb 2023 17:43:48 +0000 Received: from localhost ([127.0.0.1]:49614 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTnj1-0006TB-UE for submit@debbugs.gnu.org; Sun, 19 Feb 2023 12:43:48 -0500 Received: from mail-qt1-f181.google.com ([209.85.160.181]:41954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pTniz-0006Sv-PJ for 32026@debbugs.gnu.org; Sun, 19 Feb 2023 12:43:46 -0500 Received: by mail-qt1-f181.google.com with SMTP id he27so473464qtb.8 for <32026@debbugs.gnu.org>; Sun, 19 Feb 2023 09:43:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=zyaJU48qr6Q5VDnpWqHvveDdIZlmI+iZgMl4gz5dqcs=; b=PzZaXghtmw3tenX7ow48MrL5e8ggqtzfQ5vUIHhS+rfMuv6YZ5QJTfocb+L7TbCGnJ IyIR0WghsLH7yGQHB9PtIuxKsN6og33fLv/SVZtIWQDTfXCh0ZRNAHi63c4UsO8uaGgw PNeEYGYYK0Uk8C/+4M3lI1D53tCOdxsA9oqToGsS/IOMvOnWh5hKxObMkcfAg2dIwa+3 aZNP1bLx5aHqX0Gn/431gxkWJ/XWg+RHkWXI5tRIBQCHVKoAympx2q53lxq2V3WKrxZj uuX00wRrECQpPgKUSkxGQ15ie003sMXvX0eLqWRnsyLz0zvBbh/16/pn9x8WvWDTEdUN 4hFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zyaJU48qr6Q5VDnpWqHvveDdIZlmI+iZgMl4gz5dqcs=; b=c07zcsddg/WgmSdgD2XqzqEEaw5WcbvO63Cp1sPhhCXToD76jK4qeg/W76DwxVrKyV iEtcGxJyUY+wh0yiu+jbuk+/e9mo8QnAt0WSnM9Y58AM1AUXM0/BbqohUexOdU9Qge9n fz7lHV5cczYdAh3RrCzrXFOS+KZLZCP58cuvzyFT5q0oR8xjl2kGCGMbry7qvkWQ2V/f d3uEZ/0Hj6qajfCyHtHlmXSHMw/anOMndP6vOoxPVXtGWa1YgIzznlsksX6hpwdOI0E+ JMWLURk4N1c8LSFERDRf8+abe2kQO10XnbfECTMLb8LJDL8iXYGEPB2YA6FphJYhR44W VzNA== X-Gm-Message-State: AO0yUKXri8qXuzh5R/azFBkZ/u7W2385cqGIcFCUdADu4Ckl1qN9wWcp pq7HpSLZyXtJdKcg8MpJ7GQ= X-Google-Smtp-Source: AK7set8ebAJk6DGQtC9QE1ZcczBxgu7+ceeYLx1iEb4BD/McYPE25/sXr7LonBc64XiASNF4ZZH5zA== X-Received: by 2002:a05:622a:e:b0:3b8:68ef:d538 with SMTP id x14-20020a05622a000e00b003b868efd538mr15119313qtw.52.1676828620217; Sun, 19 Feb 2023 09:43:40 -0800 (PST) Received: from hurd (dsl-158-213.b2b2c.ca. [66.158.158.213]) by smtp.gmail.com with ESMTPSA id q188-20020a378ec5000000b0073d82a8113bsm2421257qkd.126.2023.02.19.09.43.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 19 Feb 2023 09:43:39 -0800 (PST) From: Maxim Cournoyer References: <20230216043649.32119-1-maxim.cournoyer@gmail.com> <20230216043649.32119-3-maxim.cournoyer@gmail.com> <87h6vlfdq0.fsf@netris.org> <87pma9t2z7.fsf@gmail.com> <875yby1z2d.fsf@netris.org> Date: Sun, 19 Feb 2023 12:43:38 -0500 In-Reply-To: <875yby1z2d.fsf@netris.org> (Mark H. Weaver's message of "Sat, 18 Feb 2023 15:46:23 -0500") Message-ID: <87bklpo8j9.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: X-Migadu-Queue-Id: D0678DBFD X-Spam-Score: -2.34 X-Migadu-Spam-Score: -2.34 X-Migadu-Scanner: scn0.migadu.com List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-TUID: jtg8c0rkfOKG Hello, Mark H Weaver writes: > Hi Maxim, > > Maxim Cournoyer writes: > >> Mark H Weaver writes: >> >>> Maxim Cournoyer writes: >>> >>>> * gnu/packages/gnuzilla.scm (%icecat-base-version): New variable. >>>> (%upstream-firefox-version): Likewise. >>>> (%icecat-version): Define in terms of %icecat-base-version. >>>> (upstream-firefox-source): New variable. >>>> (icecat-source): Adjust to use the above newly introduced variables. >>> >>> I'm deeply uncomfortable binding toplevel variables, even unexported >>> ones, that provide non-FSDG-complaint software. I guess that the >>> primary motivation for this commit was to make it easier to use the >>> 'update-mozilla-locales' helper. >> >> While I appreciate your concern, I think "hiding" the upstream source >> would be akin to putting our head in the sand. We do need that upstream >> source to produce GNU IceCat from source, so it may as well be >> convenient to handle while hacking on the GNU IceCat package. As you've >> noted, it isn't exported, so I think it'd be a stretch to say that this >> private binding "steers" users toward non-FSDG software. Note that we >> also have a %upstream-linux-source procedure in (gnu packages linux). > > The '%upstream-linux-source' procedure was not easily avoidable, and > it's not at all convenient to use because it requires passing in the > nix-formatted hash. > > In contrast, the argument for adding 'unstream-firefox-source' as a > toplevel binding is a very slender thread, and it would immediately > enable users to type commands like: > > guix build -e '(@@ (gnu packages gnuzilla) upstream-firefox-source)' > At which point Guix would dutifully provide non-FSDG-compliant software > to the user. > > Moreover, in another of your proposed commits ("gnu: Add a > 'update-mozilla-locales' helper for maintenance"), in a comment, you > literally steer the user to download the Firefox source and provide the > precise command to do it. > > This is a slippery slope. It is not the role of core Guix to facilitate > downloading Firefox source code for purposes of IceCat development. > That is the domain of the IceCat project itself. We're already on a slippery slope for fetching the non-free source ourselves to process them, but I'd argue that this doesn't steer users toward non-free software, but rather empowers them to free the original source of the software they use. In an ideal GNU FSDG world put forward by some proponents, we'd not even let users' machine fetch the non-free source and instead host it somewhere else, ready to be used. > I feel very strongly about this. I don't really see how "obsfuscating" the non-free source we process makes it much different, or how having an easier access to that non-free source from the CLI would steer users toward "using" non-free software. A source is not a usable (executable) form. But anyway, with that opinion of mine expressed, I've reverted the offending bits so that we can move on, knowing that once we get the strings_all.tar.zst locales data planned in future releases, it won't matter much anyway. See the result in v4. -- Thanks, Maxim