From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id 0Pz3EqbURWRAWAAASxT56A (envelope-from ) for ; Mon, 24 Apr 2023 03:00:22 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id CM8REqbURWQ2IAAAG6o9tA (envelope-from ) for ; Mon, 24 Apr 2023 03:00:22 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 12B45477A5 for ; Mon, 24 Apr 2023 03:00:22 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqkYm-0005Ct-Tj; Sun, 23 Apr 2023 21:00:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqkYl-0005Ck-IN for bug-guix@gnu.org; Sun, 23 Apr 2023 21:00:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqkYl-00035t-8r for bug-guix@gnu.org; Sun, 23 Apr 2023 21:00:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqkYk-0008DB-Il for bug-guix@gnu.org; Sun, 23 Apr 2023 21:00:02 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#58813: [PATCH 3/5] teams: Add a configure-git action. Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Mon, 24 Apr 2023 01:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58813 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Liliana Marie Prikler Cc: ludo@gnu.org, 58813@debbugs.gnu.org, zimon.toutoune@gmail.com Received: via spool by 58813-submit@debbugs.gnu.org id=B58813.168229799231525 (code B ref 58813); Mon, 24 Apr 2023 01:00:02 +0000 Received: (at 58813) by debbugs.gnu.org; 24 Apr 2023 00:59:52 +0000 Received: from localhost ([127.0.0.1]:47157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkYa-0008CP-BA for submit@debbugs.gnu.org; Sun, 23 Apr 2023 20:59:52 -0400 Received: from mail-qk1-f172.google.com ([209.85.222.172]:62616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqkYX-0008CC-U1 for 58813@debbugs.gnu.org; Sun, 23 Apr 2023 20:59:50 -0400 Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-74dd7f52f18so1091161985a.0 for <58813@debbugs.gnu.org>; Sun, 23 Apr 2023 17:59:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682297984; x=1684889984; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=dedZEzpVV3Fzy4LACNNRYiAIhiGJfdYMcTU07Uabslg=; b=buFpjQkXB3xCad+tIBcErkaTxzHDoswy6cua1S4zh8wTm3fgv4TFguSbJEK8lqwCn3 qYKbkHGNiv1UKwYWDvuI9KkI7wZDCDjL1pY4hepftZtHLB1CGpGBY3h1vQjATvyTuW1i BEpIatB3jriLb8LDespVORUXtqxgLK4cnpKLlrItjxp2xZbvN92XNbg4plD7wnEnOc7U tV5tgED9W7vukxXQVIkcYUulg1d0V5W6pFUNV/ooHAw6LHgRLvJvn4a+K1+kqNNFBHoa GCBNP1e1WgXzY6nYetQ6rMzRLyOjplbJLK5t3zvepkWhcoO7tEO8CoKeo73582qp4xRU WnNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682297984; x=1684889984; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dedZEzpVV3Fzy4LACNNRYiAIhiGJfdYMcTU07Uabslg=; b=lwzv1imV2MgJl5ht/oVJUpu8xKkIlehmPggvubG8e7nUmsUET0QjxQl2pDrc+1IfhM BXvtYqo4cOMrEzFxhjr6EC43LyIbsKkZbsuM0yGiM+otABZapDZ62kAaRCW5Bc7iJWCC EF8LUAlI3LeTf/p1RRXlaB+1PFiUyxV9ubhw58Go4dtgdkWkMG01to7sjDkkVoM9UKRI HCNnb3yBUdP8hWj1JSUg4qXq5/V8mkKDfKl5npn3njI5r4PQJMeMKHnhD+mDiDCP5gU1 O2DTGzOO9OMB9NHpvW5Fe9fl9E4paEkqmA+J2eeKDYgsFnda1IOYH1yuo4ag/mKi0KW8 XdYA== X-Gm-Message-State: AAQBX9dIKk5r/R5jEkl24ZAJ31eXtsP+kUKMLTMgBnTc4ZcIpJ2w27Ql vSpMS+RpV7XfGMN1A6ohYsY= X-Google-Smtp-Source: AKy350ZRFz4b9URGyKJy8SPueW/NeO4z0WSpO2m0LTk0Ezk34tHKsmqbmTZmP2LYbs3rjp/t3boXgA== X-Received: by 2002:a05:622a:1355:b0:3ef:2a5:ee78 with SMTP id w21-20020a05622a135500b003ef02a5ee78mr20502473qtk.10.1682297983923; Sun, 23 Apr 2023 17:59:43 -0700 (PDT) Received: from hurd (dsl-141-20.b2b2c.ca. [66.158.141.20]) by smtp.gmail.com with ESMTPSA id f3-20020ac81343000000b003e3921077d9sm3190344qtj.38.2023.04.23.17.59.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 23 Apr 2023 17:59:43 -0700 (PDT) From: Maxim Cournoyer References: <878rg4snrf.fsf@gmail.com> <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> Date: Sun, 23 Apr 2023 20:59:42 -0400 In-Reply-To: <5b9af4fa77a89c6a4b169dc464f414b1a4166d60.camel@gmail.com> (Liliana Marie Prikler's message of "Sun, 23 Apr 2023 19:03:45 +0200") Message-ID: <87bkjeumbl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1682298022; a=rsa-sha256; cv=none; b=kNXDqZ2qCQ5rbXP/jG9lbA5n3cafRZ8B+rvgE0V/ZZJQ0Si58n3H5BXlk5qMT24elBJ3Ec bWDSkuw1jICY9wzb0uIi25le49riSTrLXKFLs2+FwALZ3lSN9uIX0be6OPZ5rQre3/z0D2 PgMCbpmc0rBPp8X/7jyLUTXuiJ/yQ+t2V7cjehdBxOCxSavV08EjgO+ZRqo9SSzmqg0yBO WtNrO7btABr97VbHLHdgEI5Xfr7neH2FMKXD6DwCdr2/SB0Unop8cMw3FWkI+UOX1jFUV1 UKjqbDenbNwfIXgC7ipkF61O9orDR7mAREwStC0J040+4e/PVfe9AuASKtQH/g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=buFpjQkX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1682298022; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=dedZEzpVV3Fzy4LACNNRYiAIhiGJfdYMcTU07Uabslg=; b=s2yA7cp/SApGkLzeyrpDidBTOECXlIinFIbCnzIVa+b5LOvYknsIks1daiXNdfaC7Om+je 88AlM/Oontqf+OuJxXmtP8/5gjjwD3rz7TnggrUmx8v4AWMs6avE6y9bza+HKOC3CvOtVu 7uTv6pH729054kSEKPypt/yjo33C+sYjvlD0u4wQ3Tm0qNWQ7l0QxOusColWQAVxHau95Q D+t9RsEzv/D/WyWImZyWtqGTDJ4w+cV2RrJD/Ou/F2eZCixeUuI0HuPj0584UnHnrKEK94 ZNh7/8hzSz90DNR++p05YZiQheYmrrlXhLLRnoU8PHN/OJ2JI4jLWYh57VekRg== X-Migadu-Spam-Score: -0.61 X-Spam-Score: -0.61 X-Migadu-Queue-Id: 12B45477A5 X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20221208 header.b=buFpjQkX; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-TUID: ED0OjWjlUoct Hi Liliana, Liliana Marie Prikler writes: > Am Sonntag, dem 23.04.2023 um 12:04 -0400 schrieb Maxim Cournoyer: >> * etc/git/gitconfig: Augment configuration template with useful >> options to >> allow for auto-configuration. >> * etc/teams.scm.in (configure-git): New procedure. >> (main): Register it and add documentation. > I think configure-git is somewhat out of scope inside teams.scm. We do > already tell people to set up their push hooks, so we probably ought to > solve this via documentation (or a separate dedicated script) as well. You're right that it feels a bit out of place. The other idea I had was to add it as a Makefile target. This one would have the benefit of being smart about when to re-run the command (if the gitconfig or pre-push files changed). Would that fit better? > Otherwise LGTM. OK! Thanks for weighing in. -- Thanks, Maxim