From: Maxim Cournoyer <maxim.cournoyer@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 65788@debbugs.gnu.org, Simon Tournier <zimon.toutoune@gmail.com>
Subject: bug#65788: poor information when updating using “guix time-machine”
Date: Tue, 31 Oct 2023 10:55:54 -0400 [thread overview]
Message-ID: <87bkcesux1.fsf@gmail.com> (raw)
In-Reply-To: <875y2q96hz.fsf@gnu.org> ("Ludovic Courtès"'s message of "Sat, 28 Oct 2023 16:16:56 +0200")
Hi,
Ludovic Courtès <ludo@gnu.org> writes:
[...]
> PS: We should define rules for “Reviewed-by” tags because I don’t think
> I LGTM’d commit 79ec651a286c71a3d4c72be33a1f80e76a560031 (?).
It was a friendly credit added based on substantial comments I received
and acted upon from your review,
e.g. https://issues.guix.gnu.org/64746#7.
I don't mind if we codify to add these only when the reviewer added
their 'LGTM' approval stamp; there's an ongoing change adding some
guidelines for reviews in bug#66436, we should add this bit in.
--
Thanks,
Maxim
next prev parent reply other threads:[~2023-10-31 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-06 16:57 bug#65788: poor information when updating using “guix time-machine” Simon Tournier
2023-10-28 14:16 ` Ludovic Courtès
2023-10-31 14:55 ` Maxim Cournoyer [this message]
2023-12-19 14:36 ` Simon Tournier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87bkcesux1.fsf@gmail.com \
--to=maxim.cournoyer@gmail.com \
--cc=65788@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=zimon.toutoune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).