bug#72939: guix import crate produce broken package definition

bug#72939: guix import crate produce broken package definition

[Aleksandr Vityazev via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

Hi,

guix import crate sanakirja-core

Restult:

(define-public rust-sanakirja-core-1
  (package
    (name "rust-sanakirja-core")
    (version "1.4.1")
    (source
     (origin
       (method url-fetch)
       (uri (crate-uri "sanakirja-core" version))
       (file-name (string-append name "-" version ".tar.gz"))
       (sha256
        (base32 "1xcb4d9gaxp61na4dyz9iiq3n1shhiivqs0iv5xnxb1ymqsdnxl3"))))
    (build-system cargo-build-system)
    (arguments
     `(#:cargo-inputs ,(list ("rust-crc32fast" ,rust-crc32fast-1)
                             ("rust-ed25519-zebra" ,rust-ed25519-zebra-2)
                             ("rust-sha2" ,rust-sha2-0.10)
                             ("rust-uuid" ,rust-uuid-1))))
    (home-page "https://nest.pijul.com/pijul/sanakirja")
    (synopsis
     "Copy-on-write datastructures, storable on disk (or elsewhere) with a stable format")
    (description
     "This package provides Copy-on-write datastructures, storable on disk (or elsewhere) with a stable
format.")
    (license (list license:expat license:asl2.0))))

quasiquote and unquote in arguments are unbalanced. Probably introduced
in b8af6694b9bbea96e8b0d1c9aea64b7f8e690812.


-- 
Best regards,
Aleksandr Vityazev

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

bug#72939: guix import crate produce broken package definition

[Ludovic Courtès]

Hi Aleksandr,

(Cc’ing potentially interested parties.)

Aleksandr Vityazev <avityazev@disroot.org> skribis:

> guix import crate sanakirja-core

[...]

>     (arguments
>      `(#:cargo-inputs ,(list ("rust-crc32fast" ,rust-crc32fast-1)
>                              ("rust-ed25519-zebra" ,rust-ed25519-zebra-2)
>                              ("rust-sha2" ,rust-sha2-0.10)
>                              ("rust-uuid" ,rust-uuid-1))))

[...]

> quasiquote and unquote in arguments are unbalanced. Probably introduced
> in b8af6694b9bbea96e8b0d1c9aea64b7f8e690812.

Indeed.  Fixed in 89413a11625dd6c548827dd0078ebe0191086597 by reverting
that commit.

Commit b8af6694b9bbea96e8b0d1c9aea64b7f8e690812 originates from
<https://issues.guix.gnu.org/49531>, which included more work, such as a
‘guix style’ feature to update Rust packages to this new style.  I don’t
think the part about Rust packages reached consensus though.

Thanks,
Ludo’.