[PATCH] Release 1.0.1 of GNU MPC

[PATCH] Release 1.0.1 of GNU MPC

[Andreas Enge]

[-- Attachment #1.1: Type: text/plain, Size: 546 bytes --]

Patch attached.

Unfortunately, I could not test it yet, since guix-package starts by 
building path(s) `/nix/store/9syafc8xvscaywjldyszzgkc8pljwpj6-gcc-cross-
boot0-4.7.2'

although gcc-4.7.2 (without "coss-boot") is already there. How come?
The previous mpc release built without problem without re-downloading gcc.

Actually, the same holds for the unmodified mpfr - after changing the
definition of mpc in multiprecision.scm, installing mpfr also starts by
redownloading gcc.

Is it related to the dependency of gcc on mpfr and mpc?

Andreas

[-- Attachment #1.2: Type: text/html, Size: 3224 bytes --]

[-- Attachment #2: patch --]
[-- Type: text/x-patch, Size: 1548 bytes --]

--- guix.alt/distro/packages/multiprecision.scm	2012-12-11 21:53:49.000000000 +0100
+++ guix/distro/packages/multiprecision.scm	2012-12-11 22:49:42.000000000 +0100
@@ -95,14 +95,13 @@
 (define-public mpc
   (package
    (name "mpc")
-   (version "1.0")
+   (version "1.0.1")
    (source (origin
             (method url-fetch)
             (uri (string-append
-                  "http://www.multiprecision.org/mpc/download/mpc-"
-                  version ".tar.gz"))
+                  "mirror://gnu/mpc/mpc-" version ".tar.gz"))
             (sha256 (base32
-                     "00rxjmkpqnv6zzcyw9aa5w6rzaav32ys87km25zgfcv9i32km5cw"))))
+                     "1zq0fidp1jii2j5k5n9hmx55a6wwid33gjzhimvxq9d5zrf82npd"))))
    (build-system gnu-build-system)
    (inputs `(("gmp" ,gmp)
              ("mpfr" ,mpfr)))
@@ -110,7 +109,11 @@
 with exact rounding")
    (description
     "GNU MPC is a C library for the arithmetic of complex numbers with
-arbitrarily high precision and correct rounding of the result.  It is built
-upon and follows the same principles as GNU MPFR.")
+arbitrarily high precision and correct rounding of the result. It extends
+the principles of the IEEE-754 standard for fixed precision real floating
+point numbers to complex numbers, providing well-defined semantics for
+every operation. At the same time, speed of operation at high precision
+is a major design goal. The library is built upon and follows the same
+principles as GNU MPFR.")
    (license "LGPLv3+")
    (home-page "http://mpc.multiprecision.org/")))

Re: [PATCH] Release 1.0.1 of GNU MPC

[Ludovic Courtès]

Hi,

Andreas Enge <andreas@enge.fr> skribis:

> Unfortunately, I could not test it yet, since guix-package starts by 
> building path(s) `/nix/store/9syafc8xvscaywjldyszzgkc8pljwpj6-gcc-cross-
> boot0-4.7.2'
>
> although gcc-4.7.2 (without "coss-boot") is already there. How come?
> The previous mpc release built without problem without re-downloading gcc.
>
> Actually, the same holds for the unmodified mpfr - after changing the
> definition of mpc in multiprecision.scm, installing mpfr also starts by
> redownloading gcc.
>
> Is it related to the dependency of gcc on mpfr and mpc?

Yes, exactly: “everything” depends on GCC, and GCC depends on GMP, MPFR,
and MPC.  Thus, upgrading one of these leads to a rebuild of everything.

The way to address it (as is done in Nixpkgs) is to have a staging
branch for such changes, and to merge it once in a while.  So now is the
time to inaugurate a new branch.  :-)

Would it be an option for you to send a ‘git format-patch’ kind of
patch?

Thanks!

Ludo’.

Re: [PATCH] Release 1.0.1 of GNU MPC

[Andreas Enge]

[-- Attachment #1.1: Type: text/plain, Size: 629 bytes --]

Am Mittwoch, 12. Dezember 2012 schrieb Ludovic Courtès:
> Yes, exactly: “everything” depends on GCC, and GCC depends on GMP, MPFR,
> and MPC.  Thus, upgrading one of these leads to a rebuild of everything.
> 
> The way to address it (as is done in Nixpkgs) is to have a staging
> branch for such changes, and to merge it once in a while.  So now is the
> time to inaugurate a new branch.  :-)

Okay. There will soon be a new release of gmp (5.1), this would be a good
time for a merge back.

> Would it be an option for you to send a ‘git format-patch’ kind of
> patch?

Why not, see attached.

Andreas

[-- Attachment #1.2: Type: text/html, Size: 3594 bytes --]

[-- Attachment #2: 0001-distro-packages-multiprecision.scm-updated-for-mpc-1.patch --]
[-- Type: text/x-patch, Size: 2106 bytes --]

From ed954467bef2fbd381ccaf1bd196afd835de7282 Mon Sep 17 00:00:00 2001
From: Andreas Enge <andreas@enge.fr>
Date: Wed, 12 Dec 2012 20:03:07 +0100
Subject: [PATCH] distro/packages/multiprecision.scm: updated for mpc-1.0.1

---
 distro/packages/multiprecision.scm |   15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/distro/packages/multiprecision.scm b/distro/packages/multiprecision.scm
index 9cfde88..73bceb3 100644
--- a/distro/packages/multiprecision.scm
+++ b/distro/packages/multiprecision.scm
@@ -95,14 +95,13 @@ double-precision floating-point arithmetic (53-bit mantissa).")
 (define-public mpc
   (package
    (name "mpc")
-   (version "1.0")
+   (version "1.0.1")
    (source (origin
             (method url-fetch)
             (uri (string-append
-                  "http://www.multiprecision.org/mpc/download/mpc-"
-                  version ".tar.gz"))
+                  "mirror://gnu/mpc/mpc-" version ".tar.gz"))
             (sha256 (base32
-                     "00rxjmkpqnv6zzcyw9aa5w6rzaav32ys87km25zgfcv9i32km5cw"))))
+                     "1zq0fidp1jii2j5k5n9hmx55a6wwid33gjzhimvxq9d5zrf82npd"))))
    (build-system gnu-build-system)
    (inputs `(("gmp" ,gmp)
              ("mpfr" ,mpfr)))
@@ -110,7 +109,11 @@ double-precision floating-point arithmetic (53-bit mantissa).")
 with exact rounding")
    (description
     "GNU MPC is a C library for the arithmetic of complex numbers with
-arbitrarily high precision and correct rounding of the result.  It is built
-upon and follows the same principles as GNU MPFR.")
+arbitrarily high precision and correct rounding of the result. It extends
+the principles of the IEEE-754 standard for fixed precision real floating
+point numbers to complex numbers, providing well-defined semantics for
+every operation. At the same time, speed of operation at high precision
+is a major design goal. The library is built upon and follows the same
+principles as GNU MPFR.")
    (license "LGPLv3+")
    (home-page "http://mpc.multiprecision.org/")))
-- 
1.7.10.4

Re: [PATCH] Release 1.0.1 of GNU MPC

[Ludovic Courtès]

Hi!

Andreas Enge <andreas@enge.fr> skribis:

> Okay. There will soon be a new release of gmp (5.1), this would be a good
> time for a merge back.

OK, good to know.

>> Would it be an option for you to send a ‘git format-patch’ kind of
>> patch?
>
> Why not, see attached.

[...]

> From ed954467bef2fbd381ccaf1bd196afd835de7282 Mon Sep 17 00:00:00 2001
> From: Andreas Enge <andreas@enge.fr>
> Date: Wed, 12 Dec 2012 20:03:07 +0100
> Subject: [PATCH] distro/packages/multiprecision.scm: updated for mpc-1.0.1
>
> ---
>  distro/packages/multiprecision.scm |   15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)

Thanks!  I just pushed it to the new ‘core-updates’ branch.

Note that we use ChangeLog-style commit logs, and conventions on the
subject line, so I changed yours accordingly:

  Author: Andreas Enge <andreas@enge.fr>
  Date:   Wed Dec 12 20:03:07 2012 +0100

      distro: mpc: Update to 1.0.1.

      * distro/packages/multiprecision.scm (mpc): Update to 1.0.1.

Thanks,
Ludo’.