From mboxrd@z Thu Jan 1 00:00:00 1970 From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Subject: bug#22078: failed builds due to exceeding max-silent-time not marked as failed in db Date: Mon, 14 Dec 2015 00:11:23 +0100 Message-ID: <87a8peuep0.fsf@gnu.org> References: <565F6A9B.9050406@gmx.net> <56621663.4080007@gmx.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8FoG-0000rg-Oz for bug-guix@gnu.org; Sun, 13 Dec 2015 18:12:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1a8FoA-0000JR-BD for bug-guix@gnu.org; Sun, 13 Dec 2015 18:12:08 -0500 Received: from debbugs.gnu.org ([208.118.235.43]:43110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1a8FoA-0000JM-7u for bug-guix@gnu.org; Sun, 13 Dec 2015 18:12:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1a8FoA-0002C3-1o for bug-guix@gnu.org; Sun, 13 Dec 2015 18:12:02 -0500 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <56621663.4080007@gmx.net> (Florian Paul Schmidt's message of "Fri, 4 Dec 2015 23:40:35 +0100") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org To: Florian Paul Schmidt Cc: 22078@debbugs.gnu.org Florian Paul Schmidt skribis: > Attached is a first stab at fixing this. There are additional options > to guix-daemons now: > > --cache-failures cache build failures > --cache-hook-failures cache build failures due to hook failures > (depends > on cache-failures) > --cache-timeout-failures cache build failures due to timeouts > (depends > on cache-failures) OK. I=E2=80=99m unsure whether it makes sense to cache failures due to tim= eout because, by definition, they=E2=80=99re non-deterministic. Another problem is that clients can choose what the timeout is (both max-silent-time and absolute max-time), so it=E2=80=99d be easy for a clien= t to force a timeout failure; on a multi-user system, that would amount to a DoS attack. I=E2=80=99m not sure how to address these issues, so I=E2=80=99m rather in = favor of the status quo. WDYT? Thanks, Ludo=E2=80=99.