unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 23094@debbugs.gnu.org
Subject: bug#23094: [PATCHv2] Re: bug#23094: icecat is missing a desktop file
Date: Sat, 28 May 2016 17:22:41 +0200	[thread overview]
Message-ID: <87a8jaky0u.fsf@gnu.org> (raw)
In-Reply-To: <20160416201516.7aeb07d7@scratchpost.org> (Danny Milosavljevic's message of "Sat, 16 Apr 2016 20:15:16 +0200")

[-- Attachment #1: Type: text/plain, Size: 150 bytes --]

Hi!

I figured there’s already a desktop entry template in the source, and
it’s more complete (it includes translations), hence this patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1367 bytes --]

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index 7e52534..2baf4d7 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -509,7 +509,23 @@ standards.")
               (format #t "configure flags: ~s~%" flags)
               (zero? (apply system* bash
                             (string-append srcdir "/configure")
-                            flags))))))))
+                            flags)))))
+         (add-after 'install 'install-desktop-entry
+           (lambda* (#:key outputs #:allow-other-keys)
+             (let* ((out (assoc-ref outputs "out"))
+                    (applications (string-append out "/share/applications")))
+               (mkdir-p applications)
+               (copy-file "debian/icecat.desktop.in"
+                          "debian/icecat.desktop")
+               (substitute* "debian/icecat.desktop"
+                 (("@MOZ_DISPLAY_NAME@")
+                  "GNU IceCat")
+                 (("^Exec=@MOZ_APP_NAME@")
+                  (string-append "Exec=" out "/bin/icecat"))
+                 (("@MOZ_APP_NAME@")
+                  "icecat"))
+               (install-file "debian/icecat.desktop" applications)
+               #t))))))
     (home-page "http://www.gnu.org/software/gnuzilla/")
     (synopsis "Entirely free browser derived from Mozilla Firefox")
     (description

[-- Attachment #3: Type: text/plain, Size: 87 bytes --]


I haven’t been able to test it, so your feedback is welcome!

Thanks,
Ludo’.

  reply	other threads:[~2016-05-28 15:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 19:20 bug#23094: icecat is missing a desktop file Danny Milosavljevic
2016-03-23 17:38 ` Leo Famulari
2016-04-10 10:04 ` bug#23094: [PATCH] " Danny Milosavljevic
2016-04-16 18:15   ` bug#23094: [PATCHv2] " Danny Milosavljevic
2016-05-28 15:22     ` Ludovic Courtès [this message]
2016-05-30 21:02       ` Danny Milosavljevic
2016-05-31 13:47         ` Ludovic Courtès
2016-06-01 22:45           ` Danny Milosavljevic
2016-06-02 19:32             ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8jaky0u.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=23094@debbugs.gnu.org \
    --cc=dannym@scratchpost.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).