unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Andy Patterson <ajpatter@uwaterloo.ca>
Cc: 25101@debbugs.gnu.org
Subject: bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant.
Date: Tue, 06 Dec 2016 10:10:57 +0100	[thread overview]
Message-ID: <87a8c9xw0u.fsf@gnu.org> (raw)
In-Reply-To: <20161205173827.49a9001a@uwaterloo.ca> (Andy Patterson's message of "Mon, 5 Dec 2016 17:38:27 -0500")

Andy Patterson <ajpatter@uwaterloo.ca> skribis:

> On Mon, 05 Dec 2016 21:48:36 +0100
> ludo@gnu.org (Ludovic Courtès) wrote:
>
>> > +(define-public sane-backends+hpaio  
>> 
>> Could you add a comment and a synopsis explaining what’s this is?
>> 
>
> Sure, is the following patch ok?

Yup!

>> > +  (package
>> > +    (inherit sane-backends)
>> > +    (name "sane-backends+hpaio")
>> > +    (inputs
>> > +     `(("hplip" ,(@ (gnu packages cups) hplip))
>> > +       ,@(package-inputs sane-backends)))  
>> 
>> The closure size of this is 290 MiB whereas it’s 87 MiB for
>> ‘sane-backends’.  I suppose that’s the reason to keep’em separated?
>>
>
> Yeah, and there's also the fact that hplip depends on sane-backends.
> But this is the reason I didn't change sane-backends into a private
> variable, and then make this the new sane-backends.

Oh right.

One last thing: should we renaming “sane-backends” to
“sane-backends-minimal”, and “sane-backends+hpaio” to “sane-backends”?

That way all scanners would work out of the box, at the expense of extra
disk usage, but that is roughly what patch 2/2 does anyway.

Thanks!

Ludo’.

  reply	other threads:[~2016-12-06  9:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03 18:41 bug#25101: simple-scan can't use hpaio Danny Milosavljevic
2016-12-04  4:00 ` Andy Patterson
2016-12-04  4:00   ` bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant Andy Patterson
2016-12-05 20:48     ` Ludovic Courtès
2016-12-05 22:38       ` Andy Patterson
2016-12-06  9:10         ` Ludovic Courtès [this message]
2016-12-12 20:11           ` Andy Patterson
2016-12-12 22:41             ` Ludovic Courtès
2016-12-14  5:03               ` Andy Patterson
2016-12-14  5:03                 ` bug#25101: [PATCH 1/3] gnu: sane-backends: Disable backend generation Andy Patterson
2016-12-14  5:03                 ` bug#25101: [PATCH 2/3] gnu: Add and use sane-backends-minimal Andy Patterson
2016-12-14  5:03                 ` bug#25101: [PATCH 3/3] gnu: Add and use sane-backends Andy Patterson
2016-12-17 22:12                 ` bug#25101: [PATCH 1/2] gnu: Add hpaio-enabled sane-backends variant Ludovic Courtès
2016-12-04  4:00   ` bug#25101: [PATCH 2/2] gnu: simple-scan: Enable hpaio support Andy Patterson
2016-12-04  4:18   ` bug#25101: simple-scan can't use hpaio Andy Patterson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a8c9xw0u.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=25101@debbugs.gnu.org \
    --cc=ajpatter@uwaterloo.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).