unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
@ 2017-11-01 14:40 Oleg Pykhalov
  2017-11-01 14:47 ` Oleg Pykhalov
  0 siblings, 1 reply; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-01 14:40 UTC (permalink / raw)
  To: 29106

[-- Attachment #1: Type: text/plain, Size: 5639 bytes --]

Hello Guix,

I have issue with building loop after changing pulseaudio and
emacs-ido-completing-read+ packages.

                               pulseaudio

diff --git a/gnu/packages/pulseaudio.scm b/gnu/packages/pulseaudio.scm
index 21753cf3f..3c9659b73 100644
--- a/gnu/packages/pulseaudio.scm
+++ b/gnu/packages/pulseaudio.scm
@@ -41,6 +41,7 @@
   #:use-module (gnu packages linux)
   #:use-module (gnu packages m4)
   #:use-module (gnu packages pkg-config)
+  #:use-module (gnu packages qt)
   #:use-module (gnu packages xiph))
 
 (define-public libsndfile
@@ -173,7 +174,8 @@ rates.")
        ("fftwf" ,fftwf)
        ("avahi" ,avahi)
        ("eudev" ,eudev)           ;for the detection of hardware audio devices
-       ("check" ,check)))
+       ("check" ,check)
+       ("python-pyqt" ,python-pyqt)))
     (native-inputs
      `(("pkg-config" ,pkg-config)))
     (propagated-inputs

$ make

$ time ./pre-inst-env guix build --verbosity=5 -n --no-substitutes pulseaudio

$ sort -u ~/screenlog.1

--8<---------------cut here---------------start------------->8---
acquiring global GC lock `/var/guix/gc.lock'
acquiring read lock on `/var/guix/temproots/9147'
acquiring write lock on `/var/guix/temproots/9147'
^C
downgrading to read lock on `/var/guix/temproots/9147'
httmakunitime ./pre-inst-env guix build --verbosity=5 -n --no-substitutes pulseaudio
natsu@magnolia ~/src/guix$ 
real	4m8.823s
sys	0m2.555s
user	4m11.696s
--8<---------------cut here---------------end--------------->8---

                       emacs-ido-completing-read+

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 4c5dd2ba8..7dee7fedf 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3777,48 +3777,35 @@ restrict the text width to 80 characters.")
 (define-public emacs-ido-completing-read+
   (package
     (name "emacs-ido-completing-read+")
-    (version "3.12")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://raw.githubusercontent.com"
-                                  "/DarwinAwardWinner/ido-ubiquitous/v"
-                                  version "/ido-completing-read+.el"))
-              (file-name (string-append "ido-completing-read+-" version ".el"))
-              (sha256
-               (base32
-                "1cyalb0p7nfsm4n6n9q6rjmvn6adqc0fq8ybnlj3n41n289dkfjf"))))
+    (version "4.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/"
+                           "DarwinAwardWinner/ido-completing-read-plus"
+                           "/archive/" "v" version ".tar.gz"))
+       (file-name (string-append "ido-completing-read+-" version ".el"))
+       (sha256
+        (base32
+         "00p6j3chyir3avdgbkb05hw4rr5xd1vyljfhn7pg67jx04z5a0f3"))))
     (build-system emacs-build-system)
-    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
-    (synopsis "Replacement for completing-read using ido")
+    (propagated-inputs
+     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)
+       ("emacs-s" ,emacs-s)
+       ("emacs-memoize" ,emacs-memoize)))
+    (home-page "https://github.com/DarwinAwardWinner/ido-completing-read-plus")
+    (synopsis "Use ido (nearly) everywhere")
     (description
-     "The ido-completing-read+ function is a wrapper for ido-completing-read.
-Importantly, it detects edge cases that ordinary ido cannot handle and either
-adjusts them so ido can handle them, or else simply falls back to the standard
-Emacs completion function instead.")
+     "@code{emacs-ido-completing-read+} provides ido-style completion for
+almost every function that uses the standard completion function
+completing-read.")
     (license license:gpl3+)))
 
 (define-public emacs-ido-ubiquitous
+  ;; Preserve for people already uses `emacs-ido-ubiquitous'
   (package
-    (name "emacs-ido-ubiquitous")
-    (version "3.12")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://raw.githubusercontent.com"
-                                  "/DarwinAwardWinner/ido-ubiquitous/v"
-                                  version "/ido-ubiquitous.el"))
-              (file-name (string-append "ido-ubiquitous-" version ".el"))
-              (sha256
-               (base32
-                "197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
-    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
-    (synopsis "Use ido (nearly) everywhere")
-    (description
-     "Ido-ubiquitous enables ido-style completion for almost every function
-that uses the standard completion function completing-read.")
-  (license license:gpl3+)))
+    (inherit emacs-ido-completing-read+)
+    (name "emacs-ido-ubiquitous")))
 
 (define-public emacs-yaml-mode
   (package

$ make

$ time ./pre-inst-env guix build --verbosity=5 -n --no-substitutes emacs-ido-completing-read+

$ sort -u ~/screenlog.1

--8<---------------cut here---------------start------------->8---
acquiring global GC lock `/var/guix/gc.lock'
acquiring read lock on `/var/guix/temproots/11388'
acquiring write lock on `/var/guix/temproots/11388'
^C
downgrading to read lock on `/var/guix/temproots/11388'
natsu@magnolia ~/src/guix$ 
real	4m3.979s
sys	0m1.712s
user	4m6.727s
--8<---------------cut here---------------end--------------->8---

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
  2017-11-01 14:40 bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+ Oleg Pykhalov
@ 2017-11-01 14:47 ` Oleg Pykhalov
  2017-11-05 16:07   ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-01 14:47 UTC (permalink / raw)
  To: 29106


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.1: 0001-gnu-emacs-ido-completing-read-Update-to-4.5.patch --]
[-- Type: text/x-patch, Size: 3915 bytes --]

From 9a012229f41d60610e37639363f3b513a3900465 Mon Sep 17 00:00:00 2001
From: Oleg Pykhalov <go.wigust@gmail.com>
Date: Wed, 1 Nov 2017 15:58:48 +0300
Subject: [PATCH] gnu: emacs-ido-completing-read+: Update to 4.5.

* gnu/packages/emacs.scm (emacs-ido-completing-read+): Update to 4.5.
---
 gnu/packages/emacs.scm | 59 ++++++++++++++++++++------------------------------
 1 file changed, 23 insertions(+), 36 deletions(-)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index ad96093c3..3607e00cb 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -3777,48 +3777,35 @@ restrict the text width to 80 characters.")
 (define-public emacs-ido-completing-read+
   (package
     (name "emacs-ido-completing-read+")
-    (version "3.12")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://raw.githubusercontent.com"
-                                  "/DarwinAwardWinner/ido-ubiquitous/v"
-                                  version "/ido-completing-read+.el"))
-              (file-name (string-append "ido-completing-read+-" version ".el"))
-              (sha256
-               (base32
-                "1cyalb0p7nfsm4n6n9q6rjmvn6adqc0fq8ybnlj3n41n289dkfjf"))))
+    (version "4.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/"
+                           "DarwinAwardWinner/ido-completing-read-plus"
+                           "/archive/" "v" version ".tar.gz"))
+       (file-name (string-append "ido-completing-read+-" version ".el"))
+       (sha256
+        (base32
+         "00p6j3chyir3avdgbkb05hw4rr5xd1vyljfhn7pg67jx04z5a0f3"))))
     (build-system emacs-build-system)
-    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
-    (synopsis "Replacement for completing-read using ido")
+    (propagated-inputs
+     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)
+       ("emacs-s" ,emacs-s)
+       ("emacs-memoize" ,emacs-memoize)))
+    (home-page "https://github.com/DarwinAwardWinner/ido-completing-read-plus")
+    (synopsis "Use ido (nearly) everywhere")
     (description
-     "The ido-completing-read+ function is a wrapper for ido-completing-read.
-Importantly, it detects edge cases that ordinary ido cannot handle and either
-adjusts them so ido can handle them, or else simply falls back to the standard
-Emacs completion function instead.")
+     "@code{emacs-ido-completing-read+} provides ido-style completion for
+almost every function that uses the standard completion function
+completing-read.")
     (license license:gpl3+)))
 
 (define-public emacs-ido-ubiquitous
+  ;; Preserve for people already uses `emacs-ido-ubiquitous'
   (package
-    (name "emacs-ido-ubiquitous")
-    (version "3.12")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "https://raw.githubusercontent.com"
-                                  "/DarwinAwardWinner/ido-ubiquitous/v"
-                                  version "/ido-ubiquitous.el"))
-              (file-name (string-append "ido-ubiquitous-" version ".el"))
-              (sha256
-               (base32
-                "197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"))))
-    (build-system emacs-build-system)
-    (propagated-inputs
-     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
-    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
-    (synopsis "Use ido (nearly) everywhere")
-    (description
-     "Ido-ubiquitous enables ido-style completion for almost every function
-that uses the standard completion function completing-read.")
-  (license license:gpl3+)))
+    (inherit emacs-ido-completing-read+)
+    (name "emacs-ido-ubiquitous")))
 
 (define-public emacs-yaml-mode
   (package
-- 
2.14.3


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
  2017-11-01 14:47 ` Oleg Pykhalov
@ 2017-11-05 16:07   ` Ludovic Courtès
  2017-11-24 17:26     ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2017-11-05 16:07 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 29106

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> From 9a012229f41d60610e37639363f3b513a3900465 Mon Sep 17 00:00:00 2001
> From: Oleg Pykhalov <go.wigust@gmail.com>
> Date: Wed, 1 Nov 2017 15:58:48 +0300
> Subject: [PATCH] gnu: emacs-ido-completing-read+: Update to 4.5.
>
> * gnu/packages/emacs.scm (emacs-ido-completing-read+): Update to 4.5.

Please also mention the ‘emacs-ido-ubiquitous’ changes.


[...]

>  (define-public emacs-ido-ubiquitous
> +  ;; Preserve for people already uses `emacs-ido-ubiquitous'
>    (package
> -    (name "emacs-ido-ubiquitous")
> -    (version "3.12")
> -    (source (origin
> -              (method url-fetch)
> -              (uri (string-append "https://raw.githubusercontent.com"
> -                                  "/DarwinAwardWinner/ido-ubiquitous/v"
> -                                  version "/ido-ubiquitous.el"))
> -              (file-name (string-append "ido-ubiquitous-" version ".el"))
> -              (sha256
> -               (base32
> -                "197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"))))
> -    (build-system emacs-build-system)
> -    (propagated-inputs
> -     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
> -    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
> -    (synopsis "Use ido (nearly) everywhere")
> -    (description
> -     "Ido-ubiquitous enables ido-style completion for almost every function
> -that uses the standard completion function completing-read.")
> -  (license license:gpl3+)))
> +    (inherit emacs-ido-completing-read+)
> +    (name "emacs-ido-ubiquitous")))

Should it be defined using ‘deprecated-package’ instead?

Also, is the “build loop” you mentioned fixed with this patch?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
  2017-11-05 16:07   ` Ludovic Courtès
@ 2017-11-24 17:26     ` Ludovic Courtès
  2017-11-29  4:45       ` Oleg Pykhalov
  0 siblings, 1 reply; 6+ messages in thread
From: Ludovic Courtès @ 2017-11-24 17:26 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 29106

Ping!

ludo@gnu.org (Ludovic Courtès) skribis:

> Oleg Pykhalov <go.wigust@gmail.com> skribis:
>
>> From 9a012229f41d60610e37639363f3b513a3900465 Mon Sep 17 00:00:00 2001
>> From: Oleg Pykhalov <go.wigust@gmail.com>
>> Date: Wed, 1 Nov 2017 15:58:48 +0300
>> Subject: [PATCH] gnu: emacs-ido-completing-read+: Update to 4.5.
>>
>> * gnu/packages/emacs.scm (emacs-ido-completing-read+): Update to 4.5.
>
> Please also mention the ‘emacs-ido-ubiquitous’ changes.
>
>
> [...]
>
>>  (define-public emacs-ido-ubiquitous
>> +  ;; Preserve for people already uses `emacs-ido-ubiquitous'
>>    (package
>> -    (name "emacs-ido-ubiquitous")
>> -    (version "3.12")
>> -    (source (origin
>> -              (method url-fetch)
>> -              (uri (string-append "https://raw.githubusercontent.com"
>> -                                  "/DarwinAwardWinner/ido-ubiquitous/v"
>> -                                  version "/ido-ubiquitous.el"))
>> -              (file-name (string-append "ido-ubiquitous-" version ".el"))
>> -              (sha256
>> -               (base32
>> -                "197ypji0fb6jsdcq40rpnknwlh3imas6s6jbsvkfm0pz9988c3q2"))))
>> -    (build-system emacs-build-system)
>> -    (propagated-inputs
>> -     `(("emacs-ido-completing-read+" ,emacs-ido-completing-read+)))
>> -    (home-page "https://github.com/DarwinAwardWinner/ido-ubiquitous")
>> -    (synopsis "Use ido (nearly) everywhere")
>> -    (description
>> -     "Ido-ubiquitous enables ido-style completion for almost every function
>> -that uses the standard completion function completing-read.")
>> -  (license license:gpl3+)))
>> +    (inherit emacs-ido-completing-read+)
>> +    (name "emacs-ido-ubiquitous")))
>
> Should it be defined using ‘deprecated-package’ instead?
>
> Also, is the “build loop” you mentioned fixed with this patch?
>
> Thanks,
> Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
  2017-11-24 17:26     ` Ludovic Courtès
@ 2017-11-29  4:45       ` Oleg Pykhalov
  2017-11-29 16:43         ` Ludovic Courtès
  0 siblings, 1 reply; 6+ messages in thread
From: Oleg Pykhalov @ 2017-11-29  4:45 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 29106

[-- Attachment #1: Type: text/plain, Size: 556 bytes --]

Hello Ludovic,

Apologies for late reply.

ludo@gnu.org (Ludovic Courtès) writes:

> Ping!
>> Also, is the “build loop” you mentioned fixed with this patch?

Sorry, I don't see any patches attached.

I still have never ending pulseaudio derivation build if I add
("python-pyqt" ,python-pyqt) to the inputs field.

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix build --no-substitutes --derivations pulseaudio
--8<---------------cut here---------------end--------------->8---

Thanks,
Oleg.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+
  2017-11-29  4:45       ` Oleg Pykhalov
@ 2017-11-29 16:43         ` Ludovic Courtès
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Courtès @ 2017-11-29 16:43 UTC (permalink / raw)
  To: Oleg Pykhalov; +Cc: 29106

Hi Oleg,

Oleg Pykhalov <go.wigust@gmail.com> skribis:

> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Ping!
>>> Also, is the “build loop” you mentioned fixed with this patch?
>
> Sorry, I don't see any patches attached.

See <https://bugs.gnu.org/29106> (the issue we’re talking about.)  There
you submitted an emacs-ido-completing-read+ patch¹, and it isn’t clear
to me how it relates to the initial problem you reported.

¹ https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29106#8

> I still have never ending pulseaudio derivation build if I add
> ("python-pyqt" ,python-pyqt) to the inputs field.

OK, I suppose that’s because python-pyqt indirectly depends on
pulseaudio (currently Guix doesn’t try to detect cycles around
derivations, which is why you get this “never-ending” behavior.)

The usual approach to break such cycles is by having a “-minimal”
variant of one of the packages in the loop.

Would it work for you?

Thanks,
Ludo’.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-11-29 16:45 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-01 14:40 bug#29106: Build loop after changing pulseaudio and emacs-ido-completing-read+ Oleg Pykhalov
2017-11-01 14:47 ` Oleg Pykhalov
2017-11-05 16:07   ` Ludovic Courtès
2017-11-24 17:26     ` Ludovic Courtès
2017-11-29  4:45       ` Oleg Pykhalov
2017-11-29 16:43         ` Ludovic Courtès

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).