From: Marius Bakke <mbakke@fastmail.com>
To: Rutger Helling <rhelling@mykolab.com>, 29363@debbugs.gnu.org
Subject: bug#29363: Single test failure building Guix
Date: Tue, 21 Nov 2017 01:31:04 +0100 [thread overview]
Message-ID: <87a7zgtquv.fsf@fastmail.com> (raw)
In-Reply-To: <89edb4cc307bfae5db7812abe3b4a37a@mykolab.com>
[-- Attachment #1.1: Type: text/plain, Size: 1181 bytes --]
Hi Rutger,
Rutger Helling <rhelling@mykolab.com> writes:
> when building Guix with 'guix build guix' I keep running into a single
> test failure. I've attached the test-suite.log.
Is this a Btrfs system by any chance, possibly on an SSD?
> test-name: dead path can be explicitly collected
> location: /tmp/guix-build-guix-0.13.0-10.0b4c385.drv-0/source/tests/store.scm:178
> source:
> + (test-assert
> + "dead path can be explicitly collected"
> + (let ((p (add-text-to-store
> + %store
> + "random-text"
> + (random-text)
> + '())))
> + (let-values
> + (((paths freed) (delete-paths %store (list p))))
> + (and (equal? paths (list p))
> + (> freed 0)
> + (not (file-exists? p))))))
> actual-value: #f
> result: FAIL
I can reproduce this error on two different systems that have
Btrfs+LUKS+SSD, and the problem is that freed == 0.
I suspect it's related to Btrfs' "lazy" reporting of disk space, but
haven't dug very far.
Until we figure out what's going on, I suggest applying the patch
below. Can you confirm that it works on your system?
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1.2: 0001-gnu-guix-Disable-test-that-fails-on-Btrfs.patch --]
[-- Type: text/x-patch, Size: 1993 bytes --]
From bdc7b5310111e21801529ea57e290f6eb72ac6ed Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Tue, 21 Nov 2017 00:27:08 +0100
Subject: [PATCH] gnu: guix: Disable test that fails on Btrfs.
Works around <https://bugs.gnu.org/29363>.
Reported by Rutger Helling <rhelling@mykolab.com>.
* gnu/packages/package-management.scm (guix)[arguments]: Rename
'disable-container-tests' phase to 'disable-failing-tests' and add substitution
to disable "dead path can be explicitly collected" test.
---
gnu/packages/package-management.scm | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/gnu/packages/package-management.scm b/gnu/packages/package-management.scm
index 4f1f7f577..3321ab1eb 100644
--- a/gnu/packages/package-management.scm
+++ b/gnu/packages/package-management.scm
@@ -169,8 +169,7 @@
(copy "armhf")
(copy "aarch64")
#t))
- (add-after
- 'unpack 'disable-container-tests
+ (add-after 'unpack 'disable-failing-tests
;; XXX FIXME: These tests fail within the build container.
(lambda _
(substitute* "tests/syscalls.scm"
@@ -183,6 +182,11 @@
(substitute* "tests/guix-environment-container.sh"
(("guix environment --version")
"exit 77\n")))
+ ;; XXX: This test may fail on some file systems.
+ ;; See <https://bugs.gnu.org/29363>.
+ (substitute* "tests/store.scm"
+ (("^(.*dead path can be explicitly collected\")" all)
+ (string-append "(test-skip 1)\n" all)))
#t))
(add-before 'check 'set-SHELL
(lambda _
--
2.15.0
[-- Attachment #1.3: Type: text/plain, Size: 13 bytes --]
Ludo, WDYT?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]
next prev parent reply other threads:[~2017-11-21 0:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:08 bug#29363: Single test failure building Guix Rutger Helling
2017-11-20 15:55 ` Ludovic Courtès
2017-11-20 17:49 ` Rutger Helling
2017-11-21 0:31 ` Marius Bakke [this message]
2017-11-21 7:31 ` Rutger Helling
2017-11-21 7:47 ` Ludovic Courtès
2017-11-21 9:10 ` Rutger Helling
2017-11-21 12:53 ` Ludovic Courtès
2017-11-21 14:50 ` Rutger Helling
2017-11-21 21:11 ` Marius Bakke
2017-11-21 21:39 ` Marius Bakke
2017-11-22 15:55 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7zgtquv.fsf@fastmail.com \
--to=mbakke@fastmail.com \
--cc=29363@debbugs.gnu.org \
--cc=rhelling@mykolab.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).