From: ludo@gnu.org (Ludovic Courtès)
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 32347@debbugs.gnu.org
Subject: bug#32347: gzip cannot be patched
Date: Sun, 19 Aug 2018 15:48:05 +0200 [thread overview]
Message-ID: <87a7piii22.fsf@gnu.org> (raw)
In-Reply-To: <20180802115718.GD13776@macbook41> (Efraim Flashner's message of "Thu, 2 Aug 2018 14:57:18 +0300")
Hello,
Efraim Flashner <efraim@flashner.co.il> skribis:
> On Thu, Aug 02, 2018 at 01:32:02PM +0200, Marius Bakke wrote:
>> Hello!
>>
>> I'm trying to add a patch to 'gzip', but it causes an infinite loop and
>> eventually the system runs out of memory.
>>
>> It can be reproduced by adding this hunk:
>>
>
>> modified gnu/packages/compression.scm
>> @@ -215,6 +215,7 @@ adding and extracting files to/from a tar archive.")
>> (method url-fetch)
>> (uri (string-append "mirror://gnu/gzip/gzip-"
>> version ".tar.xz"))
>> + (snippet '(#t))
>> (sha256
>> (base32
>> "16h8g4acy7fgfxcjacr3wijjsnixwsfd2jhz3zwdi2qrzi262l5f"))))
>>
>> [back]
>>
>> I guess this is because gzip itself is a patch input. Is this something
>> that can be fixed, or do we have to use "patching phases" in these cases?
>
> Its also in commencement.scm, so that might be the loop instead. You
> could try "unpatching" it there. It looks like it has a pseudo-package
> inside of glibc-utf8-locales-final, with grep-final a few packages lower
> being potential inspiration for undoing the modifications in "real
> gzip".
Indeed. The ‘bootstrap-origin’ procedure, defined in (gnu packages
bootstrap), arranges to use the bootstrap binaries of gzip, patch,
guile, etc. when patching origins.
Perhaps we’re missing a use of ‘bootstrap-origin’ somewhere in (gnu
packages commencement)?
HTH,
Ludo’.
next prev parent reply other threads:[~2018-08-19 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 11:32 bug#32347: gzip cannot be patched Marius Bakke
2018-08-02 11:57 ` Efraim Flashner
2018-08-19 13:48 ` Ludovic Courtès [this message]
2018-10-03 8:01 ` Efraim Flashner
2023-08-29 12:44 ` Maxim Cournoyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7piii22.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=32347@debbugs.gnu.org \
--cc=efraim@flashner.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).