From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Subject: bug#31974: If a phase returns #f, a warning is issued,
	but the build continues
Date: Wed, 09 Jan 2019 21:38:25 +0100
Message-ID: <87a7k936ta.fsf@gnu.org>
References: <87efgu8clc.fsf@netris.org>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:57269)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ghKcy-0006QF-6A
	for bug-guix@gnu.org; Wed, 09 Jan 2019 15:39:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ghKcx-0006GL-GO
	for bug-guix@gnu.org; Wed, 09 Jan 2019 15:39:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:53311)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ghKcx-0006G9-Cg
	for bug-guix@gnu.org; Wed, 09 Jan 2019 15:39:03 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ghKcx-0007Hl-AF
	for bug-guix@gnu.org; Wed, 09 Jan 2019 15:39:03 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-To: bug-guix@gnu.org
Resent-Message-ID: <handler.31974.D31974.154706631227947.done@debbugs.gnu.org>
In-Reply-To: <87efgu8clc.fsf@netris.org> (Mark H. Weaver's message of "Mon, 25
	Jun 2018 23:13:03 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Mark H Weaver <mhw@netris.org>
Cc: 31974-done@debbugs.gnu.org

Mark H Weaver <mhw@netris.org> skribis:

> I just noticed that I made a mistake in commit
> d8a3b1b9e847d4a44d2695f95af77170d4d2788f, which changed 'gnu-build' in
> (guix build gnu-build-system) to issue a warning if a phase returns a
> value other than #t.
>
> The result is that if a phase returns a value other than #t, a warning
> is issued, but the build nonetheless continues to the next phase, and
> the build could ultimately "succeed" even some phases returned #f.

This was fixed in commit 82230603ce06de7aa3e4aef2fa093a6dbf0ef8df.
Closing!

Ludo'.