unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Ricardo Wurmus <rekado@elephly.net>
To: 34207@debbugs.gnu.org
Subject: bug#34207: grantlee fails to build
Date: Sat, 26 Jan 2019 11:47:23 +0100	[thread overview]
Message-ID: <87a7jnvgp0.fsf@elephly.net> (raw)

Grantlee has two test failures:

--8<---------------cut here---------------start------------->8---
FAIL!  : TestFilters::testDateBasedFilters(date01) Compared values are not the same
   Actual   (result): ""
   Expected (output): "01"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/tests/testfilters.cpp(117)]
FAIL!  : TestFilters::testDateBasedFilters(date02) Compared values are not the same
   Actual   (result): ""
   Expected (output): "Jan. 1, 2008"
   Loc: [/tmp/guix-build-grantlee-5.1.0.drv-0/grantlee-5.1.0/templates/tests/testfilters.cpp(117)]
--8<---------------cut here---------------end--------------->8---

The tests in templates/tests/testfilters.cpp look like this:

 --8<---------------cut here---------------start------------->8---
  Dict dict;
 …
  QDateTime d(QDate(2008, 1, 1));

  dict.clear();
  dict.insert(QStringLiteral("d"), d);

  QTest::newRow("date01") << "{{ d|date:\"MM\" }}" << dict
                          << QStringLiteral("01") << NoError;
  QTest::newRow("date02") << QStringLiteral("{{ d|date }}") << dict
                          << d.toString(QStringLiteral("MMM. d, yyyy"))
                          << NoError;
--8<---------------cut here---------------end--------------->8---

The following test for “date03” passes:

--8<---------------cut here---------------start------------->8---
  dict.insert(QStringLiteral("d"), QStringLiteral("fail_string"));
  QTest::newRow("date03") << "{{ d|date:\"MM\" }}" << dict << QString()
                          << NoError;
--8<---------------cut here---------------end--------------->8---

IIUC this means: some non-date is injected and the template resulted in
the empty string.

--
Ricardo

             reply	other threads:[~2019-01-26 11:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-26 10:47 Ricardo Wurmus [this message]
2020-09-05 20:48 ` bug#34207: Closing Andreas Enge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a7jnvgp0.fsf@elephly.net \
    --to=rekado@elephly.net \
    --cc=34207@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).