From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brett Gilio Subject: bug#35484: GDM failing to start stumpwm after merge Date: Mon, 29 Apr 2019 19:44:27 -0500 Message-ID: <87a7g8qq38.fsf@posteo.net> References: <87zho9cu2a.fsf@posteo.net> <87pnp5q7d2.fsf@ngyro.com> <87d0l4re46.fsf@ngyro.com> <31a3e9cda50ae26c7771c104fdbf97bb@posteo.net> <87y33spr33.fsf@ngyro.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([209.51.188.92]:59248) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLGtM-0003Cy-39 for bug-guix@gnu.org; Mon, 29 Apr 2019 20:45:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLGtK-0000qP-MZ for bug-guix@gnu.org; Mon, 29 Apr 2019 20:45:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:54884) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hLGtK-0000qE-9D for bug-guix@gnu.org; Mon, 29 Apr 2019 20:45:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hLGtK-00078G-1h for bug-guix@gnu.org; Mon, 29 Apr 2019 20:45:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-reply-to: <87y33spr33.fsf@ngyro.com> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Timothy Sample Cc: 35484@debbugs.gnu.org Timothy Sample writes: > Hi Brett, > > brettg@posteo.net writes: > >> On 29.04.2019 18:05, Timothy Sample wrote: >>> >>> After doing some testing in a VM, it looks like this is an issue >>> with my >>> recent commit: 8caa458953eeac783c73a0e5aaa72842fe3914c9. >>> >>> I added a placeholder desktop entry file, and even though I did my best >>> to make it invisible, GDM is still selecting it. (I tested GNOME and >>> XFCE, but I guess they were preferred by GDM over the placeholder, >>> whereas StumpWM is not. Maybe the has to do with how the names are >>> sorted.) > > This is exactly the problem. To find a default session, it sorts the > names of all the =E2=80=9C.desktop=E2=80=9D files it can find (using =E2= =80=9Cg_strcmp0=E2=80=9D), and > picks the first. Since we have =E2=80=9CGNOME=E2=80=9D < =E2=80=9CXFCE= =E2=80=9D < =E2=80=9CFail=E2=80=9D < =E2=80=9Cstumpwm=E2=80=9D, > my tests did not catch this error. > > I can think of two options for a fix before 1.0 (which is supposed to be > tomorrow!). The cute one is to just rename =E2=80=9CFail=E2=80=9D to =E2= =80=9C~Fail=E2=80=9D, on the > expectation that this will come after most other names when sorted. The > ugly one is to patch GDM to exclude the placeholder file when looking > for =E2=80=9C.desktop=E2=80=9D files, and then to select it instead of ra= ising an error > when it can=E2=80=99t find anything. > > My preference is for the ugly one, because the cute one feels like > putting a silly hack on top of silly hack =E2=80=93 it=E2=80=99s just a b= it too much. > I=E2=80=99ve attached a patch. Thoughts? (If I don=E2=80=99t hear anyth= ing, I will > push it =E2=80=93 it=E2=80=99s important that this works for 1.0). > > > In the future, we should find a way to make GDM errors less > catastrophic, but I doubt we could do that in a day (I certainly > couldn=E2=80=99t)! > >> Thank you for looking into this Tim! I have gone back to SLiM for the >> time being until it is fixed :). >> >> If anybody else is having this issue, going back to SLiM is really >> easy, check out my commit for reference. >> >> https://github.com/brettgilio/guix-system/commit/64d389db13c2f78ee5c58af= 28c1639b098113c93 > > Thanks for providing this. Hopefully it helps anybody else having > problems. > > > -- Tim I think the uglier version is more generic and less likely to cause future errors. But, it is a matter of time. The uglier one is likely going to be more terse. Do you need any help on my end? Brett Gilio