From: "Ludovic Courtès" <ludo@gnu.org>
To: Tobias Geerinckx-Rice <me@tobias.gr>
Cc: 37744@debbugs.gnu.org, guix-security@gnu.org
Subject: bug#37744: Per-user profile directory hijack (CVE-2019-17365 for Nix)
Date: Wed, 16 Oct 2019 22:01:37 +0200 [thread overview]
Message-ID: <87a7a0jw7y.fsf@gnu.org> (raw)
In-Reply-To: <87imoook2l.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 16 Oct 2019 16:12:50 +0200")
Tobias Geerinckx-Rice <me@tobias.gr> skribis:
> Ludovic Courtès 写道:
>> diff --git a/nix/libstore/local-store.cc
>> b/nix/libstore/local-store.cc
>> index 3b08492c64..3793382361 100644
>> --- a/nix/libstore/local-store.cc
>> +++ b/nix/libstore/local-store.cc
>> @@ -88,8 +88,9 @@ LocalStore::LocalStore(bool reserveSpace)
>> Path perUserDir = profilesDir + "/per-user";
>> createDirs(perUserDir);
>> - if (chmod(perUserDir.c_str(), 01777) == -1)
>> - throw SysError(format("could not set permissions on
>> '%1%' to 1777") % perUserDir);
>> + if (chmod(perUserDir.c_str(), 0755) == -1)
>> + throw SysError(format("could not set permissions on
>> '%1%' to 755")
>> + % perUserDir);
>> mode_t perm = 01775;
>
> This is inside
>
> if (getuid() == 0 && settings.buildUsersGroup != "") {
> …
> }
>
> It's not clear to me why the second condition here is relevant, but I
> don't have the big picture. Nor do I suspect I want it.
Yeah ‘settings.buildUsersGroup != ""’ probably doesn’t make all that
much sense here but it was already there and we strongly discourage
against root without ‘--build-users-group’ anyway.
Thanks for having lynx eyes! :-)
Ludo’.
next prev parent reply other threads:[~2019-10-16 20:02 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 7:47 bug#37744: Per-user profile directory hijack (CVE-2019-17365 for Nix) Ludovic Courtès
2019-10-14 7:58 ` Ludovic Courtès
2019-10-14 11:53 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-14 16:37 ` Maxim Cournoyer
2019-10-15 12:34 ` Ludovic Courtès
2019-10-15 14:31 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 6:57 ` Ludovic Courtès
2019-10-16 10:22 ` Ludovic Courtès
2019-10-16 13:25 ` Ludovic Courtès
2019-10-16 14:22 ` pelzflorian (Florian Pelz)
2019-10-16 15:16 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 15:19 ` pelzflorian (Florian Pelz)
2019-10-16 15:23 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 17:05 ` Ludovic Courtès
2019-10-16 19:50 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 19:55 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 21:40 ` Ludovic Courtès
2019-10-16 21:41 ` Ludovic Courtès
2019-10-16 19:58 ` Julien Lepiller
2019-10-16 21:38 ` Ludovic Courtès
2019-10-16 15:37 ` pelzflorian (Florian Pelz)
2019-10-16 21:39 ` Ludovic Courtès
2019-10-17 2:58 ` pelzflorian (Florian Pelz)
2019-10-17 3:01 ` pelzflorian (Florian Pelz)
2019-10-16 20:28 ` Ludovic Courtès
2019-10-17 16:18 ` Ludovic Courtès
2019-10-17 19:01 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-17 20:25 ` Ludovic Courtès
2019-10-18 2:21 ` Bengt Richter
2019-10-18 14:36 ` Ludovic Courtès
2019-10-19 1:32 ` Bengt Richter
2019-10-16 14:12 ` Tobias Geerinckx-Rice via Bug reports for GNU Guix
2019-10-16 20:01 ` Ludovic Courtès [this message]
2019-10-16 16:28 ` Julien Lepiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7a0jw7y.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37744@debbugs.gnu.org \
--cc=guix-security@gnu.org \
--cc=me@tobias.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).