From: "Ludovic Courtès" <ludo@gnu.org>
To: Diego Nicola Barbato <dnbarbato@posteo.de>
Cc: 40405-done@debbugs.gnu.org
Subject: bug#40405: System log files are world readable
Date: Sun, 19 Apr 2020 16:28:24 +0200 [thread overview]
Message-ID: <87a73735yv.fsf@gnu.org> (raw)
In-Reply-To: <87pnciximi.fsf@GlaDOS.home> (Diego Nicola Barbato's message of "Wed, 08 Apr 2020 14:32:53 +0200")
Hi Diego,
Diego Nicola Barbato <dnbarbato@posteo.de> skribis:
>From 43c9ded791ce5b480504ce3528ee34578168f90e Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Tue, 7 Apr 2020 13:58:28 +0200
> Subject: [PATCH 1/2] service: Create log files as non-world-readable.
>
> * modules/shepherd/service.scm (exec-command): Create log-file with file
> permissions #o640.
[...]
>From e491436967a912e6e7372f582b3bf5c9784b8209 Mon Sep 17 00:00:00 2001
> From: Diego Nicola Barbato <dnbarbato@posteo.de>
> Date: Tue, 7 Apr 2020 13:38:47 +0200
> Subject: [PATCH 2/2] service: Add #:file-creation-mask to
> 'make-forkexec-constructor'.
>
> * modules/shepherd/service.scm (exec-command): Add #:file-creation-mask
> parameter and honor it.
> (fork+exec-command): Add #:file-creation-mask parameter and pass it to
> exec-command.
> (make-forkexec-constructor): Add #:file-creation-mask parameter and pass it
> to fork+exec-command.
> * doc/shepherd.texi (Service De- and Constructors): Adjust accordingly.
I went ahead and pushed these two patches.
We’ll need to test current Shepherd master on Guix, but I feel we’ve
accumulated enough improvements for a 0.7.1 release.
Thanks,
Ludo’.
next prev parent reply other threads:[~2020-04-19 14:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 13:19 bug#40405: System log files are world readable Diego Nicola Barbato
2020-04-03 13:34 ` Diego Nicola Barbato
2020-04-05 22:12 ` Ludovic Courtès
2020-04-06 22:07 ` Ludovic Courtès
2020-04-07 0:49 ` Bengt Richter
2020-04-07 7:30 ` Ludovic Courtès
2020-04-08 12:32 ` Diego Nicola Barbato
2020-04-08 19:49 ` Ludovic Courtès
2020-04-19 14:28 ` Ludovic Courtès [this message]
2020-04-22 20:04 ` Ludovic Courtès
2020-04-28 13:11 ` Diego Nicola Barbato
2020-04-28 20:57 ` Ludovic Courtès
2020-04-29 10:02 ` Diego Nicola Barbato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a73735yv.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=40405-done@debbugs.gnu.org \
--cc=dnbarbato@posteo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).