From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CD2BNDxK217nFQAA0tVLHw (envelope-from ) for ; Sat, 06 Jun 2020 07:48:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gDdtMDxK217BdgAA1q6Kng (envelope-from ) for ; Sat, 06 Jun 2020 07:48:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 780DE9404D3 for ; Sat, 6 Jun 2020 07:48:12 +0000 (UTC) Received: from localhost ([::1]:49900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhTYp-0002dF-GS for larch@yhetil.org; Sat, 06 Jun 2020 03:48:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41814) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhTYg-0002cw-4Q for bug-guix@gnu.org; Sat, 06 Jun 2020 03:48:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39051) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhTYf-0004J3-Rl for bug-guix@gnu.org; Sat, 06 Jun 2020 03:48:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhTYf-0005Qr-PO for bug-guix@gnu.org; Sat, 06 Jun 2020 03:48:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#41541: [PATCH 4/8] bootloader: grub: Add support for multiboot. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Sat, 06 Jun 2020 07:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41541 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: "Jan \(janneke\) Nieuwenhuizen" Received: via spool by 41541-submit@debbugs.gnu.org id=B41541.159142964020813 (code B ref 41541); Sat, 06 Jun 2020 07:48:01 +0000 Received: (at 41541) by debbugs.gnu.org; 6 Jun 2020 07:47:20 +0000 Received: from localhost ([127.0.0.1]:50597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTY0-0005Pd-Bh for submit@debbugs.gnu.org; Sat, 06 Jun 2020 03:47:20 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhTXy-0005PO-Mx for 41541@debbugs.gnu.org; Sat, 06 Jun 2020 03:47:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57527) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhTXt-00045m-DY; Sat, 06 Jun 2020 03:47:13 -0400 Received: from [2a01:e0a:fa:a50:809b:e323:9e90:279b] (port=37162 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jhTXs-00027r-B3; Sat, 06 Jun 2020 03:47:13 -0400 From: Mathieu Othacehe References: <20200604135914.4499-1-janneke@gnu.org> <20200604135914.4499-5-janneke@gnu.org> Date: Sat, 06 Jun 2020 09:47:09 +0200 In-Reply-To: <20200604135914.4499-5-janneke@gnu.org> (Jan Nieuwenhuizen's message of "Thu, 4 Jun 2020 15:59:10 +0200") Message-ID: <87a71gmy9u.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 41541@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: Nrc+QM02VJ4f > + (($ label device mount-point #f () #f kernel arguments modules) > + (let* ((target (%current-target-system))) This doesn't seem to be used anymore. Plus using %current-target-system here could not give the expected result. I think that the only two "safe" ways are to use (current-target-system) from a monadic context, or to use "let-system". We should maybe write something about that in the documentation. > + #~(format port " > +menuentry ~s { > + multiboot ~a root=device:hd0s1~a~a > +}~%" If we add support for EFI one day, then it could be "hd0s2". In "install-grub-disk-image", I manage to get to root-index from the caller. I think it will be harder to do the same thing here. It's ok for me if we leave it this way. Thanks, Mathieu