unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Michael Rohleder <mike@rohleder.de>
Cc: 42301@debbugs.gnu.org
Subject: bug#42301: [PATCH] gnu: solfage: fix build.
Date: Sun, 09 Aug 2020 13:08:52 +0200	[thread overview]
Message-ID: <87a6z4axff.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <20200807180326.20444-1-mike@rohleder.de> (Michael Rohleder's message of "Fri, 7 Aug 2020 20:03:26 +0200")

Hello,

Michael Rohleder <mike@rohleder.de> writes:

> * gnu/packages/music.scm (solfage): fix build (http://issues.guix.gnu.org/42301).
> ---
>  gnu/packages/music.scm | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
> index db2f1ff8d6..af65c40193 100644
> --- a/gnu/packages/music.scm
> +++ b/gnu/packages/music.scm
> @@ -1361,6 +1361,9 @@ re-sequencer LV2 plugin.")
>               (substitute* '("solfege/parsetree.py"
>                              "solfege/presetup.py")
>                 (("#!/usr/bin/python") (string-append "#!" (which "python"))))
> +             ;; fix build, see https://issues.guix.gnu.org/42301
> +             (with-fluids ((%default-port-encoding "ISO-8859-1"))
> +               (substitute* '("README") (("Malm.") "Malmoe")))

Thank you. Unfortunately, the build fails later on with the following
unrelated message, probably related to the latest Lilypond release:

    fatal error: Uninitialized variable `write-performances-midis' in module (lily)

Besides, you are adding this snippet to an unrelated phase, about Python
wrapping.

BTW, would it make sense to provide 3.23.4 release instead? It is
a development version, but development has stalled anyway. Also, it
relies on Python 3 intead of Python 2.

I tried to update it with the following source:

     (origin
       (method url-fetch)
       (uri (string-append "http://alpha.gnu.org/gnu/solfege/solfege-"
                           version ".tar.gz"))
       (sha256
        (base32 "0sc17vf4xz6gy0s0z9ghi68yskikdmyb4gdaxx6imrm40734k8mp")))

but it fails in the same way.

WDYT?

Regards,
-- 
Nicolas Goaziou




  reply	other threads:[~2020-08-09 11:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <b5beef52-b072-ff3a-8a97-2e462a402c65.ref@eastlincoln.net>
2020-07-09 17:43 ` bug#42301: Build of GNU Solfege fails Tim Magee
2020-08-07 18:03   ` bug#42301: [PATCH] gnu: solfage: fix build Michael Rohleder
2020-08-09 11:08     ` Nicolas Goaziou [this message]
2020-08-09 16:36       ` Michael Rohleder
2020-08-11 17:09         ` Nicolas Goaziou
2021-07-05 10:47   ` bug#42301: Build of GNU Solfege fails zimoun
2021-07-05 11:57     ` Nicolas Goaziou
2021-07-05 12:31       ` Michael Rohleder
2021-07-05 13:46         ` Tim Magee
2021-07-05 13:49           ` zimoun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a6z4axff.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=42301@debbugs.gnu.org \
    --cc=mike@rohleder.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).