From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id sDU2ORusdmE2dwEAgWs5BA (envelope-from ) for ; Mon, 25 Oct 2021 15:07:39 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id GKfeNBusdmEMegAAB5/wlQ (envelope-from ) for ; Mon, 25 Oct 2021 13:07:39 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 622101CC49 for ; Mon, 25 Oct 2021 15:07:39 +0200 (CEST) Received: from localhost ([::1]:50030 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mezhS-0006W2-AK for larch@yhetil.org; Mon, 25 Oct 2021 09:07:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59422) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mezVG-00048c-Ft for bug-guix@gnu.org; Mon, 25 Oct 2021 08:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:58559) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mezVG-00007v-0G for bug-guix@gnu.org; Mon, 25 Oct 2021 08:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mezVF-0003Om-Sh for bug-guix@gnu.org; Mon, 25 Oct 2021 08:55:01 -0400 Subject: bug#50672: nnpack is not reproducible Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-To: bug-guix@gnu.org Resent-Date: Mon, 25 Oct 2021 12:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 50672 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Kyle Meyer Mail-Followup-To: 50672@debbugs.gnu.org, ludovic.courtes@inria.fr, ludovic.courtes@inria.fr Received: via spool by 50672-done@debbugs.gnu.org id=D50672.163516647813017 (code D ref 50672); Mon, 25 Oct 2021 12:55:01 +0000 Received: (at 50672-done) by debbugs.gnu.org; 25 Oct 2021 12:54:38 +0000 Received: from localhost ([127.0.0.1]:41872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezUs-0003Nt-4Z for submit@debbugs.gnu.org; Mon, 25 Oct 2021 08:54:38 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:38385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mezUp-0003Nb-Jb for 50672-done@debbugs.gnu.org; Mon, 25 Oct 2021 08:54:36 -0400 IronPort-Data: A9a23:6ZJDwat/JTMZBbpiBcMblcnVV+fnVJZcMUV32f8akzHdYEJGY0x3ymUdW2/SO/uNZGGgLttwbt+w/EID65HdyYIwSFc9rCBgHilAwSbnLYTAfx2oZ0t+DeWaERk5t51GAjX4wXFdokb0/n9BCZC86ykjvU20buCkUredYnosHVYMpBoJ0nqPpcZo2+aEvvDpW2thifuqyyHuEAfNNwxcagr42IrfwP9bh8kejRtD1rAIiV+ni3eF/5UdJMp3yahctBIUSKEMdgKxb76rIL1UYgrkExkR5tONyt4Xc2UQQ7TYOg7mZnh+Avn5xEUa4HVriuBibaJ0hUR/0l1lm/h11dlKq527DwwuI7fQlf81Uh9CEig4M7cuFLrveiLu75XLp6HBWz62qxl0N2kkPIgf/KBrBnxS8uEeJRgCaxmCg6S9x7fTYrQ02Jt5acXsOo43tnxqxyzWFrApR42FRL/FjfdbzTM9rsNfGfvXYowSbj8HUfhqS3WjIX9OWcl4wb/u3yCnNWQB8DqoSWMMyzC75GRMPHLFabI5ouC3ePg= IronPort-HdrOrdr: A9a23:mF8E3araS27xvJRUKttpNckaV5pIeYIsimQD101hICG9Ffb0qynOpp8mPHDP6Qr5NEtOpTniAsO9qBHnlaKdiLN5VYtKNzOLhILHFu9f0bc= X-IronPort-AV: E=Sophos;i="5.87,180,1631570400"; d="scan'208";a="329610" Received: from unknown (HELO ribbon) ([193.50.110.110]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2021 14:54:29 +0200 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <875yuwsxad.fsf@inria.fr> <87a6k6j6uu.fsf@gnu.org> <87tuiam5ni.fsf@gnu.org> <87ilylf3yn.fsf@inria.fr> <87pmrxt6tf.fsf_-_@gnu.org> <87ee8ch0v1.fsf@kyleam.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 4 Brumaire an 230 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 25 Oct 2021 14:54:28 +0200 In-Reply-To: <87ee8ch0v1.fsf@kyleam.com> (Kyle Meyer's message of "Fri, 22 Oct 2021 23:32:50 -0400") Message-ID: <87a6ixl0xn.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: 50672-done@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1635167259; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-to: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=x3fCUnQoECzlDnODTKRq5UzbU2XtauDClgdekGyk4nM=; b=WbAhnDIOV8jII4rqHWfVJ2EhfQU0C3Su5w6jHot4G/GXcKOejkw2zwe2Xe3QfedjLilmxP xKWwcZQTnJ/IW20G14u0oPWOy8Hp7H0a+YLHP7LIqnF/0LGBhRxswj/cVDoDlrsyy/lInM XHvQvquzALrQAfeKjwxrbXSx934I3qTuhKO4idPIcFaXVRJ7p9Y1YDJu8uSZyXzKATP/EY bGqLUDXiCGG31rOzJ/+/1FJ4+g7Kw62OjMSd4CUlDbCta4D/HKbXLQHd0zQ0oOXcFF15ss 76QESp/zu230PDyzCmPpgFwIxe8bzrdyb3v+hxZ9w4JJoNHYjNtimKCSFa+nJQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1635167259; a=rsa-sha256; cv=none; b=O+mGUhuP+z7eGrE9y0M3YWM495fGvG1h3IkAqyic5KVqe1CX9VwudEEg+XEWB7XQxqOAAW Bh8034dXesycEqlsBD3cAZRBG/ZOlG1AhQRamKpHHso0ElOMwUOVgsYGQbSqqjOXtabfNm W9FndqLbYM7VwAM5xqIw1EQOPnB/uExIM0wKsrgIyRXwU7DfSUCP8KztDFJJmu+vXFz34M YSCmnnTkbgWFEmMPqOUvnTI3JPeldRY8kyXpdp18osxEiUoJPOQpZlwqfFNW0SjMaD9BFW 0sVpOHVIvqzTocrra7gNq47Nroshud6hUZ6ITk08vzBgCVZmpAEZ/i5K7HtwyA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Spam-Score: -2.43 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of bug-guix-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=bug-guix-bounces@gnu.org X-Migadu-Queue-Id: 622101CC49 X-Spam-Score: -2.43 X-Migadu-Scanner: scn0.migadu.com X-TUID: FCA9MyRB0p5m Hi! Kyle Meyer skribis: > Ludovic Court=C3=A8s writes: > >> For the record, I tried the attached patch in an attempt to sort things >> as discussed in the issue above, but it doesn=E2=80=99t have the intended >> effect. There must be other unsorted dictionaries elsewhere. > > Hmm, I don't think dictionaries are a likely culprit here because > Python's dict implementation preserves the insertion order as of Python > v3.6 (and that behavior is declared as part of the language spec with > v3.7). Ah, silly me. > In cases where the order of the keys isn't specified (i.e. Python 3.5 > and below), I think the end result after your change is the same: it > creates a new dictionary for sorted _input_, but things won't > necessarily come out in the same order. Noted, thanks for explaining. > I'm not familiar with PeachPy, but taking a peek at name.py, the sets > used for the values of the prenames dictionary could be the problem. > And if that's the case, one solution would be switching those values > from sets to dictionaries. > > With the change below (on top of PeachPy's 257881e), nnpack builds > reliably for me across a couple of attempts: > > $ guix-dev build --with-git-url=3Dpython-peachpy=3D$local --no-grafts -= -check nnpack > successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0= .0-1.c07e3a0.drv > successfully built /gnu/store/7z4nl55gssrf9na7wsvmw1dsqgawnj2p-nnpack-0= .0-1.c07e3a0.drv > /gnu/store/4ihjil42fbk53q73gpvdakynbv9q5q09-nnpack-0.0-1.c07e3a0 Your patch does the trick, indeed. I went ahead and pushed it as b87fe805aa66851f17f56078cb0e94f7cc4525df. Thank you! Ludo=E2=80=99.