From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6B0XM3Yb12E38AAAgWs5BA (envelope-from ) for ; Thu, 06 Jan 2022 17:40:22 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id 6ApBMHYb12Ey5wAA9RJhRA (envelope-from ) for ; Thu, 06 Jan 2022 17:40:22 +0100 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 5E690381EF for ; Thu, 6 Jan 2022 17:40:22 +0100 (CET) Received: from localhost ([::1]:39242 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n5VoL-0003EF-25 for larch@yhetil.org; Thu, 06 Jan 2022 11:40:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:35888) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n5Vo5-0003C8-Fw for bug-guix@gnu.org; Thu, 06 Jan 2022 11:40:05 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:49145) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n5Vo2-0003rU-CJ for bug-guix@gnu.org; Thu, 06 Jan 2022 11:40:05 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n5Vo2-0006RN-6X for bug-guix@gnu.org; Thu, 06 Jan 2022 11:40:02 -0500 X-Loop: help-debbugs@gnu.org Subject: bug#52908: 'tests/guix-system.sh' fails on aarch64-linux Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Thu, 06 Jan 2022 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52908 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Chris Marusich Received: via spool by 52908-submit@debbugs.gnu.org id=B52908.164148719824737 (code B ref 52908); Thu, 06 Jan 2022 16:40:02 +0000 Received: (at 52908) by debbugs.gnu.org; 6 Jan 2022 16:39:58 +0000 Received: from localhost ([127.0.0.1]:42048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Vnx-0006Qv-OG for submit@debbugs.gnu.org; Thu, 06 Jan 2022 11:39:58 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:40590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n5Vnv-0006QS-21 for 52908@debbugs.gnu.org; Thu, 06 Jan 2022 11:39:56 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 19C51256; Thu, 6 Jan 2022 17:39:48 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id w7nVD8m7YaHP; Thu, 6 Jan 2022 17:39:47 +0100 (CET) Received: from ribbon (91-160-117-201.subs.proxad.net [91.160.117.201]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 437BB53; Thu, 6 Jan 2022 17:39:46 +0100 (CET) From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87wnjgqm93.fsf@gmail.com> Date: Thu, 06 Jan 2022 17:39:45 +0100 In-Reply-To: <87wnjgqm93.fsf@gmail.com> (Chris Marusich's message of "Mon, 03 Jan 2022 18:15:52 -0800") Message-ID: <87a6g8es32.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: 19C51256 X-Spamd-Result: default: False [-0.10 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_SOME(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_CC(0.00)[famulari.name,gmail.com,debbugs.gnu.org] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aiko Kyle , 52908@debbugs.gnu.org Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641487222; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=Qs+C5PtPYq7EX6OP4YcSLtmTKHRO9YCsZyhihC5Vd10=; b=bdr0u5EzwDL0Q+u6h9nm8ihTcU6KpgXZqhepIMupOU9eZCs82sELba9deLK+ad187Drv+x sTBdNrLFYITRrspoWdiyUVIEjdaaODqn4GB9J1S0dZz6CHrLuCYuXis8YHuuiGtcORzQ/V FawWIyjtiZtJcE/EZab20DjhrN6nSiegYcXKQotQvTIXt07Fw8T8l4jZNOemmSG3JVMOrj VtL+LfezZpLti3OS9Rmx3On8odsqq/KRXuc1rN+UBU0Ze3kbWlup6wy51n9HCMeABvfEAv ZloxzLVZsQL0h9XOnh+eYl6RSj04x88RXWAOPYsUDqOOzRfY6drgsOl+Ulwfbg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641487222; a=rsa-sha256; cv=none; b=ct4UKI1CnbnfdmiNxhR6cvT0iApkgMMV1jyb2+fTYl/XTjjR/CVoDGR4n4Q+fnyMzWgN9d 1c0uMraRxDKlXTJJrDN3aQ8aVc0ix31OrSQ2iLxX2e2A314k5gS/xHt+eSBfj9lY1s/8Iu qzprAk/Syys4SCCaVr81H5f4du6fhtwR9BmjL19M0KpMb69F0XbxxLoaq3ryiN9y+pbPoj 0gEAcKkLQX+9/wNxniDSfomtCnP1sk9DAnEixF3kQL/vmWhskHjInqjVX7QnYcGFDM0PLv +gIV3LXdUEJx2sinKIeTzVjZ0g58+uflrg21Awmka0o5pcKw+IrS0ZSdAgCiQQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -4.60 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: 5E690381EF X-Spam-Score: -4.60 X-Migadu-Scanner: scn0.migadu.com X-TUID: AfKbGCraAIPO Hi, Chris Marusich skribis: > I've attached a different patch that attempts to fix the issue without > requiring callers of set-xorg-configuration to update their code. I > believe this is more consistent with the intent of Ludo's original > change in commit 49599fab564f203b8e92d32e9b28c99e99849bfb. [...] > From 09091cc8495e0b4c302a58961e79ac8455ecd208 Mon Sep 17 00:00:00 2001 > From: Chris Marusich > Date: Mon, 3 Jan 2022 14:59:35 -0800 > Subject: [PATCH] services: Consistently use SDDM rather than GDM on > non-x86_64. > > This is a follow-up to 49599fab564f203b8e92d32e9b28c99e99849bfb. Notably= , it > also deprecates (gnu services sddm) and moves what was there into (gnu > services xorg). > > Fixes: . I=E2=80=99d rather not move things and fix the bug in the same commit. (I= =E2=80=99m not even convinced sddm needs to leave its own module, plus it would break the API, which is not something to do lightly.) [...] > (define* (set-xorg-configuration config > #:optional > (login-manager-service-type > - gdm-service-type)) > + (let ((system (or (%current-target-sys= tem) > + (%current-system)))) > + (if (string-prefix? "x86_64" system) > + gdm-service-type > + sddm-service-type)))) [...] > --- a/gnu/system/examples/vm-image.tmpl > +++ b/gnu/system/examples/vm-image.tmpl > @@ -107,12 +107,12 @@ root ALL=3D(ALL) ALL > ;; Use the DHCP client service rather than NetworkManag= er. > (service dhcp-client-service-type)) >=20=20 > - ;; Remove GDM, ModemManager, NetworkManager, and wpa-supplica= nt, > - ;; which don't make sense in a VM. > + ;; Remove some services that don't make sense in a VM. > (remove (lambda (service) > (let ((type (service-kind service))) > (or (memq type > (list gdm-service-type > + sddm-service-type These bits LGTM. Thanks for fixing it! And yes, we=E2=80=99ll need to update the =E2=80=98guix=E2=80=99 package on= ce this fix is in. Ludo=E2=80=99.