From: "Ludovic Courtès" <ludo@gnu.org>
To: Maxime Devos <maximedevos@telenet.be>
Cc: 55367@debbugs.gnu.org, Rostislav Svoboda <rostislav.svoboda@gmail.com>
Subject: bug#55367: guix refresh fails. struct-vtable: Wrong type argument in position 1 (expecting struct)
Date: Thu, 12 May 2022 10:18:24 +0200 [thread overview]
Message-ID: <87a6bnmaen.fsf@gnu.org> (raw)
In-Reply-To: <60cd5b74cb5d7c9b706c5af70bfb1edd2f6736fd.camel@telenet.be> (Maxime Devos's message of "Wed, 11 May 2022 16:08:52 +0200")
Hi,
Maxime Devos <maximedevos@telenet.be> skribis:
> Ludovic Courtès schreef op wo 11-05-2022 om 15:49 [+0200]:
>> The code at guix/gnu-maintenance.scm:188:20 checks a URI, so my guess is
>> that the source of that package is not a valid URI, and thus
>> ‘string->uri’ returns #false.
>
> It's "gogdownloader://world_of_goo/en3installer0".
>
> (string->uri "gogdownloader://world_of_goo/en3installer0")
> $1 = #f
> (string->uri "gogdownloader://worldofgoo/en3installer0")
> $2 = #f
The second one works for me:
--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> (string->uri "gogdownloader://worldofgoo/en3installer0")
$7 = #<<uri> scheme: gogdownloader userinfo: #f host: "worldofgoo" port: #f path: "/en3installer0" query: #f fragment: #f>
--8<---------------cut here---------------end--------------->8---
The first one has an invalid authority part, which doesn’t match
‘authority-regexp’ (underscores are not permitted; I believe (web uri)
is correct here.)
> Worse, looks like non-ASCII characters (that are valid DNS names, at
> least ignoring punycode encodings and such) aren't supported:
>
> (string->uri "https://www.étoile.fr")
> $3 = #f
Right; I think ‘string->uri’ expects a Punycode-encoded string, which is
probably correct per RFC 3986.
That said, it’s beyond this scope of this bug report.
To me, the conclusion is that the package has a invalid URI, so it’s not
a Guix bug strictly speaking. However, we could change
gnu-maintenance.scm so that it deals with invalid URIs gracefully.
Thoughts?
Ludo’.
next prev parent reply other threads:[~2022-05-12 8:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-11 13:10 bug#55367: guix refresh fails. struct-vtable: Wrong type argument in position 1 (expecting struct) Rostislav Svoboda
[not found] ` <handler.55367.B.16522747076110.ack@debbugs.gnu.org>
2022-05-11 13:15 ` bug#55367: Acknowledgement (guix refresh fails. struct-vtable: Wrong type argument in position 1 (expecting struct)) Rostislav Svoboda
2022-05-11 13:49 ` bug#55367: guix refresh fails. struct-vtable: Wrong type argument in position 1 (expecting struct) Ludovic Courtès
2022-05-11 14:08 ` Maxime Devos
2022-05-11 14:13 ` Maxime Devos
2022-05-12 8:18 ` Ludovic Courtès [this message]
2022-05-12 8:57 ` Maxime Devos
2022-05-12 9:07 ` Maxime Devos
2022-05-12 9:47 ` Rostislav Svoboda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6bnmaen.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=55367@debbugs.gnu.org \
--cc=maximedevos@telenet.be \
--cc=rostislav.svoboda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).