From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id GPMCH+ozqGIIAAEAbAwnHQ (envelope-from ) for ; Tue, 14 Jun 2022 09:08:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id QNQTHuozqGKaHwEAG6o9tA (envelope-from ) for ; Tue, 14 Jun 2022 09:08:26 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id B41453D915 for ; Tue, 14 Jun 2022 09:08:25 +0200 (CEST) Received: from localhost ([::1]:50366 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o10f2-0003zq-Mk for larch@yhetil.org; Tue, 14 Jun 2022 03:08:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43410) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o10eg-0003wG-6p for bug-guix@gnu.org; Tue, 14 Jun 2022 03:08:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:38877) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o10ef-0000EK-TZ for bug-guix@gnu.org; Tue, 14 Jun 2022 03:08:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o10ef-0007LD-MF for bug-guix@gnu.org; Tue, 14 Jun 2022 03:08:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#55499: excessively large manifests due to propagation Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 14 Jun 2022 07:08:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55499 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 55499@debbugs.gnu.org Cc: Ricardo Wurmus Received: via spool by 55499-submit@debbugs.gnu.org id=B55499.165519042128138 (code B ref 55499); Tue, 14 Jun 2022 07:08:01 +0000 Received: (at 55499) by debbugs.gnu.org; 14 Jun 2022 07:07:01 +0000 Received: from localhost ([127.0.0.1]:32774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o10dh-0007Jh-0b for submit@debbugs.gnu.org; Tue, 14 Jun 2022 03:07:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o10df-0007JU-4D for 55499@debbugs.gnu.org; Tue, 14 Jun 2022 03:06:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:58482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o10dY-00005z-WD; Tue, 14 Jun 2022 03:06:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=jDpfROzEYheJaOVGi0nyi3px9d3DsBuYS4KymzQcAM0=; b=orNusn2IWrRS1X3+IRsr hdkcKHDjRT6690O1xGi0u//mKSS1F5wZ/sC6uMW2hiGuBn5QQwZwTo170+htvLzaYxtt8+6TyBde0 9c0GpfCvUvtKoZ7IxCx2ynOlDgNC8jmmEbc/MSs/YDmmlrkUj1damqtcErx5K7PJQv9fjbANUzb8K sEfzN9FF4QUx+hvF0jDohQS+Q9HaAG7u6mZiySoe1uLjcgNoYXwfDqrlqceKdF8Gxr3D3qQUtsYZA MGuRb+aqIRW8QAiqb54MG/bXmISpqRTifBva8vLBLyEwmoo7dQjDcIENvmmfD79pbGmJduWrCFr+w crZbRDyfoRSmyA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (port=51876 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o10dX-0000TY-09; Tue, 14 Jun 2022 03:06:52 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87sfp7kkim.fsf@elephly.net> <20220531160916.21508-1-ludo@gnu.org> Date: Tue, 14 Jun 2022 09:06:48 +0200 In-Reply-To: <20220531160916.21508-1-ludo@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 31 May 2022 18:09:13 +0200") Message-ID: <87a6afoh9z.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: "bug-Guix" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: US ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1655190506; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=jDpfROzEYheJaOVGi0nyi3px9d3DsBuYS4KymzQcAM0=; b=LOf+lvMfl218nIrN1OEy9kRttpdoPqcAbM4f2CBVSYvBHDc/hU/9jxgMjnttODcH6aa2kJ fkl0+Rwqk+KxaHWmwVUZH4HRg+yH9fFNGEltpkiAzaPhHyCfZDLcaGvz1SGhJ8IebZ1S33 /eRXtSkpuQU0y/wpSLs3ixDSfpZhtwTPcnAJlsNgAWGriiQx5SfvHdhr8ZdH3Iwk631Hky OjWmhfaevYfye4O11fRSgsOmR17E+uUPvroniYJGwOtrhpccgKQSlAUTz2j0c/xqVkTInc rdm3GNMfvuO350Alfx1X09RYhDzail54Yi6w6UKhVAqmN/L5WyseNZmx3jTUaQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1655190506; a=rsa-sha256; cv=none; b=NiBcyQKCpT9BURjXQ4bMS4UyILSTpoHTNWhRMUvKkItvNzbt91H3mT+6OWEJELrt3pLIEE oaPJXOPoDZwGhGsRnHgozm88GoUT5EcbthA5CtVvTi9X1Cy/CSguXrt8KXJjI/BMp1vEM4 G3swiO30qbFXV/4eeiR2YRlZrXCskuHV151sH7t8zxbsE8OjpjTKqkIt47EA6ESAByfu6C DGOCoxEqM/1HwezAX0FCbmCNRhluqk3tOUSsGxJ2o/6NTXZ4OinbD0CGmod5Lpa0sHvGSf IkxD83jr5d/FcfS5qJudBq3O+UbU08B7/1mhOZxyjJxc/CvTKldqNP9j57H5fA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=orNusn2I; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Spam-Score: -3.19 Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=orNusn2I; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org" X-Migadu-Queue-Id: B41453D915 X-Spam-Score: -3.19 X-Migadu-Scanner: scn0.migadu.com X-TUID: f+xGQR1lRgdp Hey Ricardo, Ludovic Court=C3=A8s skribis: > These patches implement what you suggested on IRC: not repeating > entire manifest entries and their propagated inputs. This has a > dramatic impact on the size of the =E2=80=98manifest=E2=80=99 file and on= the memory > and processing time to read it for the the use case you gave. > > The second patch goes a tiny bit further by making the =E2=80=98search-pa= ths=E2=80=99 > and =E2=80=98propagated-inputs=E2=80=99 fields optional, shaving another = ~10% on the > size of =E2=80=98manifest=E2=80=99 in this example. > > The second patch should be squashed with the first one (so we don=E2=80= =99t > bump version formats a second time and duplicate code). It=E2=80=99s kin= da > optional because it doesn=E2=80=99t bring much compared to the first patc= h and > causes a bit of extra complexity, but maybe it=E2=80=99s still worth keep= ing? > > Could you try this on your larger use cases and tell me how it goes? Did you have a chance to give it a try? Maybe I can double-check that everything=E2=80=99s alright and go ahead. Thanks, Ludo=E2=80=99.