From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id yAOvNEzcUGbPWAAAqHPOHw:P1 (envelope-from ) for ; Fri, 24 May 2024 20:28:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:303:e16b::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id yAOvNEzcUGbPWAAAqHPOHw (envelope-from ) for ; Fri, 24 May 2024 20:28:28 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=antr.me header.s=MBO0001 header.b=CPorSK6Y; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=antr.me (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1716575308; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=pRdg8uhQTb2GNEAIvn1Z+vVb52lU0ExktV9CANZsFvk=; b=ndCf8dabprrbAVi1ltCSnyY+msEJpcOV9nqGlX5+Otjgked/eZSL6LC7MrV/yljk/gnNKK Ris8fwlH5mhmCFXZwp+uVzxBj1l4f3nlhlqoshXgYLGOvNBHjaKKjL5OjMbA5xYqlRBArR wdix4GKk40/1/ImA8xxPsew4DSGP0SHrT8A6muoF/y2BNr6c+j820SLH1I9Jp82xy0Tclv n+5eX1mJjMOkxBD4xulun7uFtwNjh7b+jCLfOowmcZOtUPOHTA7CqNHuuCsdUjPkwjf+sp zjloczK2UdEWJCL+pra7s6nRDskbG0y8gVxNfyfW4CPUdB2riZFfxFo0D2mIqA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=antr.me header.s=MBO0001 header.b=CPorSK6Y; spf=pass (aspmx1.migadu.com: domain of "bug-guix-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="bug-guix-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed)" header.from=antr.me (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1716575308; a=rsa-sha256; cv=none; b=FDhCtxRPq0jBzF6NkWWRdQpC0n/xY44Z1++cq2szAoiACW1e4iJCGKGRYwTlMIBNMq0iTT 5IoKL/iga95X45zmNsovWQ1/UVsaeyUUb4mrO/G4rvlZxJh573ZPocD3LA3KZ+/nBxx8Fg 1EZaBeK7+JhNI7r5QaK2paGekWl+f0mR1zkTtbM8Dt5Jm54YpVL8fOrrE8Xl6IjhuEl+r5 pxngH+4gF2i7YH1Say8uys8tL/97FsYVM7B90R0eiEuWLEhKRnPb2QEzw67bwXdXt7If6c x2z8RbblJpsrGhCM82fzJnwga+ZC5rDDlX7INKeCdekft3GeMhOFS3hTfvo0RQ== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4CAB6102D0 for ; Fri, 24 May 2024 20:28:28 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAZe2-0000pM-TJ; Fri, 24 May 2024 14:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAZdz-0000jh-FE for bug-guix@gnu.org; Fri, 24 May 2024 14:27:55 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAZdy-0005L6-OJ for bug-guix@gnu.org; Fri, 24 May 2024 14:27:55 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAZe5-0005L7-Q5 for bug-guix@gnu.org; Fri, 24 May 2024 14:28:01 -0400 X-Loop: help-debbugs@gnu.org Subject: bug#71153: [PATCH] gnu: Validate substitute URLs for guix service. Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 May 2024 18:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71153 X-GNU-PR-Package: guix X-GNU-PR-Keywords: patch To: Richard Sent Cc: 71153@debbugs.gnu.org Received: via spool by 71153-submit@debbugs.gnu.org id=B71153.171657523920500 (code B ref 71153); Fri, 24 May 2024 18:28:01 +0000 Received: (at 71153) by debbugs.gnu.org; 24 May 2024 18:27:19 +0000 Received: from localhost ([127.0.0.1]:38492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAZdP-0005Ka-Bp for submit@debbugs.gnu.org; Fri, 24 May 2024 14:27:19 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:40232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAZdN-0005KU-Qr for 71153@debbugs.gnu.org; Fri, 24 May 2024 14:27:18 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4VmD5w6x1yz9sqP; Fri, 24 May 2024 20:27:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=antr.me; s=MBO0001; t=1716575221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pRdg8uhQTb2GNEAIvn1Z+vVb52lU0ExktV9CANZsFvk=; b=CPorSK6Ym8qF7Leh9QorXPJGkD69r7GFzeVM5b4IMEBCImk3ITN78ovGSQ7OaD39kNRdq0 jvlwjDCG4lLSIDTruI+e0wbWn82E0ktlmijutdG2P+E/Gmxw/EAOgZPOf4ERB+oWD0jm5f 1f4jRicavyVEfLmWRFXXSAgKDPZbW5/MdhSMEycUak5z9SfUxO+oDWLQGOAD7JxFEHhvOB 0w6zZCc1INfKd1YglUIgFuBxVd2IZ1j5ic5sADc/tztAyaSRuk8DGgWqk93sNfyRWT7SlK AyvDaloMhkJnUDvjTT2UabKv4QbbJmVNzqd3/Q1sXVJBhBLx+A1kI8XOiulaOQ== From: Antero Mejr In-Reply-To: <87cypbuwaz.fsf@freakingpenguin.com> (Richard Sent's message of "Fri, 24 May 2024 10:19:32 -0400") References: <87cypcrwe1.fsf@antr.me> <87cypbuwaz.fsf@freakingpenguin.com> Date: Fri, 24 May 2024 18:26:56 +0000 Message-ID: <87a5kfjcb3.fsf@antr.me> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guix@gnu.org List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+larch=yhetil.org@gnu.org Sender: bug-guix-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: 5.54 X-Spam-Score: 5.54 X-Migadu-Queue-Id: 4CAB6102D0 X-Migadu-Scanner: mx13.migadu.com X-TUID: TlKI5ruoieXF Richard Sent writes: > Should we instead create a validate-substitute-urls and use that as a > sanitizer for the guix-extension and guix-configuration records? This > would catch errors during record creation instead of service creation, > as well as still perform validation if anything else does or will use > those records in the future. The problem mentioned in the initial patch only occurs when the invalid URLs are used in the Guix service type. Having them in the record isn't a problem. I don't there there is a major difference in where the validation occurs though.