bug#72968: [PATCH] gnu: php: Fix build.

bug#72968: [PATCH] gnu: php: Fix build.

[Noé Lopez via Bug reports for GNU Guix]

[-- Attachment #1: Type: text/plain, Size: 80 bytes --]

Hi,

Here is a patch to fix the PHP build.

Have a good day,
Noé Lopez


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-php-Fix-build.patch --]
[-- Type: text/x-patch, Size: 1650 bytes --]

From 225bbd80ed6d67f4c9157ad31a344bae42ffb998 Mon Sep 17 00:00:00 2001
Message-ID: <225bbd80ed6d67f4c9157ad31a344bae42ffb998.1725287764.git.noelopez@free.fr>
From: =?UTF-8?q?No=C3=A9=20Lopez?= <noelopez@free.fr>
Date: Mon, 2 Sep 2024 15:54:29 +0200
Subject: [PATCH] gnu: php: Fix build.

* gnu/packages/php.scm (php): Add missing dependencies and
disable failing tests.

Change-Id: I3ddc47e5ad121a8177e3a12c5dfe154a8d6029b6
---
 gnu/packages/php.scm | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/gnu/packages/php.scm b/gnu/packages/php.scm
index 8f879dbdca..2f031ecd3d 100644
--- a/gnu/packages/php.scm
+++ b/gnu/packages/php.scm
@@ -252,6 +252,10 @@ (define-public php
                          "ext/gd/tests/bug72339.phpt"
                          ;; AVIF support disabled
                          "ext/gd/tests/imagecreatefromstring_avif.phpt"
+                         ;; No idea why
+                         "ext/gd/tests/bug79676.phpt"
+                         "ext/gd/tests/imageinterpolation_basic.phpt"
+                         "ext/gd/tests/imagescale_preserve_ratio.phpt"
 
                          ;; XXX: These test failures appear legitimate, needs investigation.
                          ;; open_basedir() restriction failure.
@@ -306,6 +310,10 @@ (define-public php
        ("bzip2" ,bzip2)
        ("curl" ,curl)
        ("cyrus-sasl" ,cyrus-sasl)
+       ("freetype" ,freetype)
+       ("fontconfig" ,fontconfig)
+       ("libjpeg-turbo" ,libjpeg-turbo)
+       ("libpng" ,libpng)
        ("gd" ,gd)
        ("gdbm" ,gdbm)
        ("gmp" ,gmp)

base-commit: e1c92c98f7afff13fb7060199ba0dd4d9c5c2c53
-- 
2.45.2

bug#72968: [PATCH] gnu: php: Fix build.

[Rutherther via Bug reports for GNU Guix]

Hello Noé,

thanks for your patch. Unfortunately, I don't think this is the
way to go. The issue here is that gd package has these in Requires.private
in the pkg-config file. That means every package that wants libgd
also has to get these inputs. Not only php. So gd has to be fixed here.
See issue #72943 where I sent a patch to make gd propagated inputs
and Carlo Zancanaro proposed returning code that was mistakenly
removed as part of core-updates.

The other part are the tests, where I think we should look into why they
are failing, and figure out if there is any issue in Guix or not
rather than removing them without investigating the cause.

Regards,
Ruther