From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: [PATCH] distro: Add Libusb.
Date: Tue, 18 Dec 2012 00:44:26 +0100
Message-ID: <878v8w2qhx.fsf@gnu.org>
References: <CAD15K4tJN_7b2Z0bkWwsOQ_NQ8KqTKYK5E5zOsW0mFFa5v1+QQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:58460)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TkkMI-0003vM-AV
	for bug-guix@gnu.org; Mon, 17 Dec 2012 18:44:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TkkMH-0004zb-7i
	for bug-guix@gnu.org; Mon, 17 Dec 2012 18:44:30 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:32751)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1TkkMH-0004zN-15
	for bug-guix@gnu.org; Mon, 17 Dec 2012 18:44:29 -0500
In-Reply-To: <CAD15K4tJN_7b2Z0bkWwsOQ_NQ8KqTKYK5E5zOsW0mFFa5v1+QQ@mail.gmail.com>
	(Nikita Karetnikov's message of "Mon, 17 Dec 2012 22:52:34 +0300")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita.karetnikov@gmail.com>
Cc: bug-guix@gnu.org

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> /tmp/nix-build-libusb-1.0.9.drv-0/libusb-1.0.9/libtool: line 1113:
> ldconfig: command not found

Yes, we don=E2=80=99t use ldconfig(1).  This warning is harmless.

> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/libusb=
-1.0.la:
> File format not recognized
> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/pkgcon=
fig/libusb-1.0.pc:
> File format not recognized

Harmless too: strip just warns about non-ELF files it is passed.

> I was using the following settings.
>
> nix.conf:
>
> build-users-group =3D nixbld
> build-use-chroot =3D true
> build-chroot-dirs =3D /dev /proc /bin
>
> or
>
> # ./pre-inst-env guix-daemon --build-users-group=3Dnixbld \
>> -C 0 --chroot-directory=3D/bin &

Good.

> Can I commit it?

Yes, please!  One minor thing below:

> +    (synopsis "Libusb is a user-space USB library")

The synopsis should not be a sentence; instead, it should be a concise
phrase.  So I=E2=80=99d replace =E2=80=9C is=E2=80=9D by =E2=80=9C, =E2=80=
=9D here.

Ludo=E2=80=99.