unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Nikita Karetnikov <nikita.karetnikov@gmail.com>
Cc: bug-guix@gnu.org
Subject: Re: [PATCH] distro: Add Libusb.
Date: Tue, 18 Dec 2012 00:44:26 +0100	[thread overview]
Message-ID: <878v8w2qhx.fsf@gnu.org> (raw)
In-Reply-To: <CAD15K4tJN_7b2Z0bkWwsOQ_NQ8KqTKYK5E5zOsW0mFFa5v1+QQ@mail.gmail.com> (Nikita Karetnikov's message of "Mon, 17 Dec 2012 22:52:34 +0300")

Hi,

Nikita Karetnikov <nikita.karetnikov@gmail.com> skribis:

> /tmp/nix-build-libusb-1.0.9.drv-0/libusb-1.0.9/libtool: line 1113:
> ldconfig: command not found

Yes, we don’t use ldconfig(1).  This warning is harmless.

> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/libusb-1.0.la:
> File format not recognized
> strip:/nix/store/1x3fy2fs9p4k80asqcasji82lhhfb5hp-libusb-1.0.9/lib/pkgconfig/libusb-1.0.pc:
> File format not recognized

Harmless too: strip just warns about non-ELF files it is passed.

> I was using the following settings.
>
> nix.conf:
>
> build-users-group = nixbld
> build-use-chroot = true
> build-chroot-dirs = /dev /proc /bin
>
> or
>
> # ./pre-inst-env guix-daemon --build-users-group=nixbld \
>> -C 0 --chroot-directory=/bin &

Good.

> Can I commit it?

Yes, please!  One minor thing below:

> +    (synopsis "Libusb is a user-space USB library")

The synopsis should not be a sentence; instead, it should be a concise
phrase.  So I’d replace “ is” by “, ” here.

Ludo’.

      reply	other threads:[~2012-12-17 23:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 19:52 [PATCH] distro: Add Libusb Nikita Karetnikov
2012-12-17 23:44 ` Ludovic Courtès [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878v8w2qhx.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=bug-guix@gnu.org \
    --cc=nikita.karetnikov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).