From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=)
Subject: Re: guix-package --roll-back
Date: Thu, 17 Jan 2013 22:47:06 +0100
Message-ID: <878v7r7a91.fsf@gnu.org>
References: <871uejyq9z.fsf@karetnikov.org> <874nj4sbfe.fsf@karetnikov.org>
	<87y5gf8sm1.fsf@gnu.org> <87hamy4yaj.fsf@karetnikov.org>
	<87pq1m5nxy.fsf@gnu.org> <87obh43j7r.fsf@karetnikov.org>
	<87vcbbqvw1.fsf@gnu.org> <87fw2ai3e1.fsf@karetnikov.org>
	<8738y8ekst.fsf@gnu.org> <87622whkvn.fsf@karetnikov.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:54365)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TvxIj-0001cv-Hp
	for bug-guix@gnu.org; Thu, 17 Jan 2013 16:47:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ludo@gnu.org>) id 1TvxIi-0003aq-G9
	for bug-guix@gnu.org; Thu, 17 Jan 2013 16:47:09 -0500
Received: from mail4-relais-sop.national.inria.fr ([192.134.164.105]:25401)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <ludo@gnu.org>)
	id 1TvxIi-0003aj-9i
	for bug-guix@gnu.org; Thu, 17 Jan 2013 16:47:08 -0500
In-Reply-To: <87622whkvn.fsf@karetnikov.org> (Nikita Karetnikov's message of
	"Wed, 16 Jan 2013 16:34:47 -0500")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Nikita Karetnikov <nikita@karetnikov.org>
Cc: bug-guix@gnu.org

Hi!

Nikita Karetnikov <nikita@karetnikov.org> skribis:

> I changed 'roll-back', but didn't add the command-line option.  Could
> you add it?

Yes, I just did it in 24e262f, along with a test case and documentation.

Thanks a lot for taking the time to work on this, I appreciate.

> Why do these lines raise the "non-literal format string" warning?
>
> +        (format (current-error-port)
> +                "error: '~a' is not a valid profile~%"
> +                profile)

Hmm, could be a bug, but I don=E2=80=99t seem to have them here.

> Also, is it possible to remove nested if statements?

Yes, with =E2=80=98cond=E2=80=99 or =E2=80=98match=E2=80=99.

I think we now have something that works well.  Commit 9241172 slightly
changes =E2=80=98roll-back=E2=80=99 to support roll-back when a past genera=
tion is
missing (which could happen when the user deletes it.)

So now I think I=E2=80=99m almost ready to tag 0.1 later tonight!

Thanks!

Ludo=E2=80=99.