From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#21280: test failures: nar, syscalls, containers
Date: Tue, 25 Aug 2015 00:07:44 +0200
Message-ID: <878u90s5lb.fsf@gnu.org>
References: <1439783007.1743108.357849649.18351DEC@webmail.messagingengine.com>
	<87si7gfejf.fsf@gnu.org>
	<1439949357.1343604.359857913.0408A579@webmail.messagingengine.com>
	<87614a50sk.fsf@gnu.org>
	<1440044072.3615090.360939601.63AA1D36@webmail.messagingengine.com>
	<87bne22s6v.fsf@gnu.org>
	<1440109544.937009.361720705.14632458@webmail.messagingengine.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZTzuP-00058m-Hq
	for bug-guix@gnu.org; Mon, 24 Aug 2015 18:08:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZTzuM-0000Kz-C1
	for bug-guix@gnu.org; Mon, 24 Aug 2015 18:08:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:45076)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZTzuM-0000Ku-8J
	for bug-guix@gnu.org; Mon, 24 Aug 2015 18:08:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ZTzuL-0003Wm-Se
	for bug-guix@gnu.org; Mon, 24 Aug 2015 18:08:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.21280.B21280.144045407713552@debbugs.gnu.org>
In-Reply-To: <1440109544.937009.361720705.14632458@webmail.messagingengine.com>
	(Leo Famulari's message of "Thu, 20 Aug 2015 18:25:44 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
To: Leo Famulari <leo@famulari.name>
Cc: 21280@debbugs.gnu.org

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Leo Famulari <leo@famulari.name> skribis:

> On Thu, Aug 20, 2015, at 06:02, Ludovic Court=C3=A8s wrote:

[...]

>> I suspect the =E2=80=98nlink=E2=80=99 count on directories work differen=
tly on btrfs, or
>> something like that.

[...]

> %%%% Starting test nar  (Writing full log to "nar.log")
>
> ;;; (stat-output "./test-nar-7151" 1)
> tests/nar.scm:203: FAIL write-file + restore-file
>
> ;;; (stat-output "./test-nar-7151" 1)
> tests/nar.scm:220: FAIL write-file + restore-file with symlinks

Indeed, that confirms what I thought.

This looks like buggy or at least borderline behavior from Btrfs.
However, it seems that this =E2=80=98nlink=E2=80=99 test can be sidestepped=
 altogether.

Could you apply this last patch and run:

  make check TESTS=3Dtests/nar.scm

again?

If it works for you, I=E2=80=99ll just apply it.

Thanks!

Ludo=E2=80=99.


--=-=-=
Content-Type: text/x-patch
Content-Disposition: inline

diff --git a/tests/nar.scm b/tests/nar.scm
index b8e50c7..58adb95 100644
--- a/tests/nar.scm
+++ b/tests/nar.scm
@@ -121,7 +121,7 @@
                     (lambda (name stat errno result)
                       (pk 'error name stat errno)
                       #f)
-                    (> (stat:nlink (stat output)) 2)
+                    #t
                     input
                     lstat))
 

--=-=-=--