From mboxrd@z Thu Jan  1 00:00:00 1970
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
Subject: bug#23605: /dev/urandom not seeded across reboots
Date: Sat, 28 May 2016 15:57:06 +0200
Message-ID: <878tyumgjx.fsf@gnu.org>
References: <20160523175832.GA10646@jasmine> <87d1obabj8.fsf@gnu.org>
	<20160525163815.GA19996@jasmine> <87vb229ixp.fsf@gnu.org>
	<20160526164707.GA11671@jasmine>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36983)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6ekg-0001cF-Uo
	for bug-guix@gnu.org; Sat, 28 May 2016 09:58:07 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6ekc-0007j2-Lc
	for bug-guix@gnu.org; Sat, 28 May 2016 09:58:05 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:60814)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6ekc-0007iy-He
	for bug-guix@gnu.org; Sat, 28 May 2016 09:58:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1b6ekc-0001tI-CJ
	for bug-guix@gnu.org; Sat, 28 May 2016 09:58:02 -0400
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.23605.B23605.14644438437218@debbugs.gnu.org>
In-Reply-To: <20160526164707.GA11671@jasmine> (Leo Famulari's message of "Thu,
	26 May 2016 12:47:07 -0400")
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: Leo Famulari <leo@famulari.name>
Cc: 23605@debbugs.gnu.org

Leo Famulari <leo@famulari.name> skribis:

> On Wed, May 25, 2016 at 06:54:58PM +0200, Ludovic Court=C3=A8s wrote:
>>=20
>> Yes, it=E2=80=99s:
>>=20
>>   (service TYPE VALUE)
>>=20
>> but I think there=E2=80=99s no meaningful value for this service, so you=
 could
>> do:
>>=20
>>   (service urandom-seed-service-type #f)

[...]

> gnu/services/base.scm:1217:0: In procedure urandom-seed-shepherd-service:
> gnu/services/base.scm:1217:0: Wrong number of arguments to #<procedure ur=
andom-seed-shepherd-service ()>

[...]

> +(define (urandom-seed-shepherd-service)

[...]

> +(define urandom-seed-service-type
> +  (service-type (name 'urandom-seed)
> +                (extensions
> +                 (list (service-extension shepherd-root-service-type
> +                                          urandom-seed-shepherd-service)

Service extension procedures are called with one argument, which is the
service=E2=80=99s value (info "(guix) Service Reference").

Usually, the service=E2=80=99s value is a configuration object, but in this
case, the service=E2=80=99s value doesn=E2=80=99t matter, so you could simp=
ly write:

  (define (urandom-seed-shepherd-service _)
    =E2=80=A6)

> +                       ;; Add urandom-seed to the system profile
> +                       (service-extension profile-service-type list)))))

The =E2=80=98profile-service-type=E2=80=99 represents the system profile, i=
.e.,
/run/current-system/profile.  Extending it means adding a package to
it.

But here, IIUC, there=E2=80=99s no package to be added to the profile, so y=
ou
should just remove it.

Last round and we=E2=80=99re done!  :-)

Thanks for persevering, and sorry it=E2=80=99s not easier.  Maybe you=E2=80=
=99ll have
ideas on how to improve the manual and/or the API?

Ludo=E2=80=99.