From: "Clément Lassieur" <clement@lassieur.org>
To: Danny Milosavljevic <dannym@scratchpost.org>
Cc: 32300@debbugs.gnu.org
Subject: bug#32300: [PATCH] database: Fix the builds limit issue.
Date: Wed, 08 Aug 2018 13:44:44 +0200 [thread overview]
Message-ID: <878t5h13rn.fsf@lassieur.org> (raw)
In-Reply-To: <20180807124626.29e6a12a@scratchpost.org>
Hi Danny,
Danny Milosavljevic <dannym@scratchpost.org> writes:
> The more complicated version is a LOT faster - and was added because
> the version in this patch was just way too slow (unusably slow).
>
> I think it's better to also remove the call to db-get-outputs (and
> the entry #:outputs) entirely. I don't think our overview page even
> shows the outputs in the first place, so why fetch them?
As you can see on my test machine with a Berlin database, it's almost
instantaneous. Also, with my commit that merges the Derivations and the
Builds tables, the queries are way lighter: they return about 100 builds
per evaluation, instead of 20000.
Plus, the outputs are used to get the build log.
https://cuirass.lassieur.org:8081/jobset/guix-master
WDYT?
Clément
next prev parent reply other threads:[~2018-08-08 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-28 23:21 bug#32300: Cuirass: the 'nr' filter doesn't when builds have multiple outputs Clément Lassieur
2018-07-28 23:26 ` bug#32300: Cuirass: the 'nr' filter doesn't work " Clément Lassieur
2018-08-04 16:00 ` bug#32300: [PATCH] database: Fix the builds limit issue Clément Lassieur
2018-08-04 16:10 ` Clément Lassieur
2018-08-07 10:46 ` Danny Milosavljevic
2018-08-08 11:44 ` Clément Lassieur [this message]
2018-08-08 15:32 ` Clément Lassieur
2018-08-09 5:57 ` Danny Milosavljevic
2018-08-09 8:02 ` Clément Lassieur
2018-08-16 20:59 ` Clément Lassieur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878t5h13rn.fsf@lassieur.org \
--to=clement@lassieur.org \
--cc=32300@debbugs.gnu.org \
--cc=dannym@scratchpost.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).