From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxim Cournoyer Subject: bug#33100: [libssh] fatal: dumb http transport does not support shallow capabilities Date: Fri, 26 Oct 2018 22:05:52 -0400 Message-ID: <878t2kuosf.fsf@gmail.com> References: <87zhv94as1.fsf@gmail.com> <87in1w90iu.fsf@gnu.org> <87va5w3rtj.fsf@gmail.com> <875zxupapd.fsf@gnu.org> <87o9bj33e4.fsf@gmail.com> <20181024141523.GB5988@jasmine.lan> <87h8hbyqr4.fsf@gnu.org> <87k1m63ilz.fsf@gmail.com> <87lg6musc4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:36555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gGE0H-0005I3-G5 for bug-guix@gnu.org; Fri, 26 Oct 2018 22:07:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gGE0E-00035O-AR for bug-guix@gnu.org; Fri, 26 Oct 2018 22:07:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:40220) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gGE0E-00035K-4w for bug-guix@gnu.org; Fri, 26 Oct 2018 22:07:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gGE0D-0003Xj-U6 for bug-guix@gnu.org; Fri, 26 Oct 2018 22:07:01 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87lg6musc4.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Thu, 25 Oct 2018 14:24:43 +0200") List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 33100-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello! ludo@gnu.org (Ludovic Court=C3=A8s) writes: >>>> I like it, but it doesn't seem to actually print anything for me when I >>>> trigger the failing case, for example by fetching the libssh source ov= er >>>> HTTP. >>> >>> If might be that current-output-port is fully buffered. What if you >>> add: >>> >>> (setvbuf (current-output-port) 'line) >>> >>> before the =E2=80=98format=E2=80=99 call? >>> >>> Thanks, >>> Ludo=E2=80=99, who is found guilty of not actually running the code. >> >> What is preferable, between your solution or using (force-output)? > > I=E2=80=99d go for line buffering since you only need to do it once for a= ll. I finally got around to reproducing the problem and testing the fix; it was costly to build using --no-substitutes. Is it OK to push this patch into master? Thanks, Maxim --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-git-download-Print-a-message-when-falling-back-to-a-.patch >From 44782db3f63a29cdbd98cddb77eab8a473806765 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Wed, 24 Oct 2018 08:49:50 -0400 Subject: [PATCH] git-download: Print a message when falling back to a full fetch. Otherwise the user might believe that git-fetch stalled, observing the lack of output following a 'fatal' git error message (see: https://debbugs.gnu.org/33100). * guix/build/git.scm (git-fetch): Print message when falling back to a full fetch. --- guix/build/git.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/guix/build/git.scm b/guix/build/git.scm index 14d415a6f..2d1700a9b 100644 --- a/guix/build/git.scm +++ b/guix/build/git.scm @@ -45,6 +45,8 @@ recursively. Return #t on success, #f otherwise." (if (zero? (system* git-command "fetch" "--depth" "1" "origin" commit)) (invoke git-command "checkout" "FETCH_HEAD") (begin + (setvbuf (current-output-port) 'line) + (format #t "Failed to do a shallow fetch; retrying a full fetch...~%") (invoke git-command "fetch" "origin") (invoke git-command "checkout" commit))) (when recursive? -- 2.19.0 --=-=-=--