From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Bakke Subject: bug#35521: Mariadb test suite failures on x86_64-linux Date: Fri, 12 Jul 2019 16:58:48 +0200 Message-ID: <878st3mh93.fsf@devup.no> References: <87tveemt19.fsf@netris.org> <87tveemt19.fsf@netris.org> <87h8aemrow.fsf@netris.org> <87pnmil8dq.fsf_-_@gmail.com> <87wogpn6f7.fsf@devup.no> <87ef2xlgmb.fsf@netris.org> <87ims8mds7.fsf@devup.no> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:52785) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hlx0q-0002Im-5T for bug-guix@gnu.org; Fri, 12 Jul 2019 10:59:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hlx0o-00072g-Pv for bug-guix@gnu.org; Fri, 12 Jul 2019 10:59:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:59932) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hlx0o-00072B-IX for bug-guix@gnu.org; Fri, 12 Jul 2019 10:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hlx0o-0002IY-Ej for bug-guix@gnu.org; Fri, 12 Jul 2019 10:59:02 -0400 Sender: "Debbugs-submit" Resent-Message-ID: In-Reply-To: <87ims8mds7.fsf@devup.no> List-Id: Bug reports for GNU Guix List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org Sender: "bug-Guix" To: Mark H Weaver Cc: Platoxia , 35521@debbugs.gnu.org --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Marius Bakke writes: > Mark H Weaver writes: > >> Hi, >> >> Marius Bakke writes: >> >>> Chris Marusich writes: >>> >>>> Hi, >>>> >>>> I've been encountering this failure off and on for a few weeks now, and >>>> I'd like to help fix it. In short, it seems like non-deterministic test >>>> failures, to me. I think we should gather data and report the issue >>>> upstream, and maybe disable the offending tests in the meantime. >>> >>> I agree. I notice many of these failing tests are for the TokuDB >>> backend, which I doubt anyone is using in Guix anyway. >>> >>> Here is a patch that disables all tests mentioned in this report. I >>> would like to push it to core-updates. Are there others? >> >> I'm concerned by how frequently and casually we simply disable failing >> tests. What is the utility of running test suites at all, if this is >> how we respond? > > I had no idea this issue was so widespread until I noticed Berlins > builders hit it more often than not. I have not been able to reproduce > these failures on my machines. So it was kind of a panic reaction, > being the person responsible for running these tests and all. > > Looking further into the changes between 10.1.37 and 10.1.38, I notice > the 'tokudb.*' tests were enabled: > > https://github.com/MariaDB/server/commit/4c490d6df63695dc97b2c808e59954e6877d3a51 > > Watching the build on Berlin in real time, I also see that the test > output grind nearly to a halt while running those. > 'tokudb.hotindex-insert-2' took 2700439 milliseconds, or 45 minutes, if > I'm reading the test output correctly. > > The default test case timeout is 40 minutes (as specified in the Guix > package), but I'm using 80 for this build (60 was insufficient). > > I suspect the problem is that the 'tokudb.*' tests put a lot of strain > on the file system, which causes these other tests to fail. It's > interesting that disabling parallel build was insufficient though. Update: Berlin built mariadb twice on core-updates with this patch: --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=db.diff diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm index 6bfeaad9a2..64bc0938b6 100644 --- a/gnu/packages/databases.scm +++ b/gnu/packages/databases.scm @@ -753,7 +753,7 @@ Language.") (with-directory-excursion "mysql-test" (invoke "./mtr" "--verbose" "--retry=3" - "--testcase-timeout=40" + "--testcase-timeout=80" "--suite-timeout=600" "--parallel" (number->string (parallel-job-count)) "--skip-test-list=unstable-tests")) --=-=-= Content-Type: text/plain Mark, Chris: Can you try this change with MariaDB 10.1.40 and see if it works for you? --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl0ooCgACgkQoqBt8qM6 VPq/FggAtPX7+OrcwlSI12IbUfUqhEZnQrocXIy9okA1Bl5NiV+Hy8k2rfg5/Q1K Rqix5TSkPCGLPtQYkW/IIyZiPaJZQuKWpUlphbFlZDQ1vGs2Q4WlbS0gOLJnEV3T EkRaj2rweRsTKel5OPMSKaV3VGTc+TchyRFvhjGfhSrBdokrBD2Z6cSWtf4rhss3 rge+11QhSBX3ZIqSghSSTd9GZ1D4XCIEdvUfxK0qoWH1bLhSmTQh/PNV8+wtl1os Xmrb8zXNXu1WP2FyaCnPeDS2vOEYBDogT0kDszadxWC0lNXzwxuRfbc4dJVhcI/Q SWQXWbvO88PyTjRep6zJ5iu6DjG1fw== =RYR1 -----END PGP SIGNATURE----- --==-=-=--