unofficial mirror of bug-guix@gnu.org 
 help / color / mirror / code / Atom feed
From: Pierre Neidhardt <mail@ambrevar.xyz>
To: Raghav Gururajan <raghavgururajan@disroot.org>
Cc: 41025@debbugs.gnu.org
Subject: bug#41025: blueman does not start
Date: Sun, 10 May 2020 11:27:54 +0200	[thread overview]
Message-ID: <878si0cf6t.fsf@ambrevar.xyz> (raw)
In-Reply-To: <2beca260-cf82-3099-8d4f-c246314d7121@disroot.org>

[-- Attachment #1: Type: text/plain, Size: 1767 bytes --]

Sorry to disappoint :p  Sadly this patch does not work yet ;)

- You've hardcoded the python version (3.7) while you should get it
dynamically from the one you are using.

You can try using something like

--8<---------------cut here---------------start------------->8---
,(version-major+minor (package-version python))
--8<---------------cut here---------------end--------------->8---

- You've hardcoded paths to ~/.guix-profile which should be avoided
  because profiles can be anywhere.

--8<---------------cut here---------------start------------->8---
+             (substitute*
+                 '("apps/blueman-mechanism.in" "blueman/Functions.py")
+               (("/usr/bin:/bin:/usr/sbin:/sbin")
+                (string-append
+                 "~/.guix-profile/bin:"
+                 "/run/current-system/profile/bin:"
+                 "~/.guix-profile/sbin:"
+                 "/run/current-system/profile/sbin"))
+               ((":/sbin:/usr/sbin")
+                (string-append
+                 ":/run/current-system/profile/sbin:"
+                 "~/.guix-profile/sbin")))
--8<---------------cut here---------------end--------------->8---

I think this should be replace by the Python equivalent of `(getenv "PATH")`.

- In the following comment, the ';' should be a colon.  "patching"
  should probably be something like "we patch".

--8<---------------cut here---------------start------------->8---
+         ;; Python references are not being patched in patch-phase of build;
+         ;; despite using python-wrapper as input. So patching them manually.
--8<---------------cut here---------------end--------------->8---

Stay put, almost there! :)

-- 
Pierre Neidhardt
https://ambrevar.xyz/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

  reply	other threads:[~2020-05-10  9:29 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-02 13:39 bug#41025: blueman does not start Pierre Neidhardt
2020-05-02 13:56 ` Raghav Gururajan
2020-05-02 18:45   ` Pierre Neidhardt
2020-05-03 15:24     ` Raghav Gururajan
2020-05-03 16:13       ` Pierre Neidhardt
2020-05-04  3:18         ` Raghav Gururajan
2020-05-04  8:47           ` Pierre Neidhardt
2020-05-04  9:11             ` Pierre Neidhardt
2020-05-09  6:29             ` Raghav Gururajan
2020-05-09  9:12               ` Pierre Neidhardt
2020-05-09 21:49                 ` Raghav Gururajan
2020-05-09 22:03                   ` Raghav Gururajan
2020-05-10  9:27                     ` Pierre Neidhardt [this message]
2020-05-11 10:05                       ` Raghav Gururajan
2020-05-14 17:16                         ` Pierre Neidhardt
2020-05-14 23:37                           ` Raghav Gururajan
2020-05-15  0:56                             ` Raghav Gururajan
2020-05-15  9:52                               ` Pierre Neidhardt
2020-05-10 21:29                     ` Marius Bakke
2020-05-11 10:07                       ` Raghav Gururajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878si0cf6t.fsf@ambrevar.xyz \
    --to=mail@ambrevar.xyz \
    --cc=41025@debbugs.gnu.org \
    --cc=raghavgururajan@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).